From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id 15CF419E0047 for ; Mon, 28 Dec 2015 10:18:02 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id 699C3B5D872 for ; Mon, 28 Dec 2015 10:50:36 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id AF95218CC7E7 for ; Mon, 28 Dec 2015 10:50:36 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 2C2EA1205CA; Mon, 28 Dec 2015 10:50:35 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o2.heroku.sendgrid.net (o2.heroku.sendgrid.net [67.228.50.55]) by neon.ruby-lang.org (Postfix) with ESMTPS id 14EF51205B7 for ; Mon, 28 Dec 2015 10:50:31 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=aT1fnZpidZR3ucGJg4tJNJAilM4=; b=UOpeZaLXJM7NRFNJ3/ qKXeUnaL9wooeLmOrAIKhX5wpy0Ioh5yxyRsihoc/XfTLhwBPL55T5Y7+a7anPR8 mBUKy8l4KsZvZ+hypHGMoSr5rxj2LFhLAYEG9g2KiwbvvPruqH7aMf+rQ/5C6ktT jxa2Lttws7Jrt3eNubrnkcDrQ= Received: by filter0654p1mdw1.sendgrid.net with SMTP id filter0654p1mdw1.8964.56809565C 2015-12-28 01:50:29.066874672 +0000 UTC Received: from herokuapp.com (ec2-54-205-165-91.compute-1.amazonaws.com [54.205.165.91]) by ismtpd0006p1iad1.sendgrid.net (SG) with ESMTP id Z3ODf2GGQRG2JE4O0GWUyQ for ; Mon, 28 Dec 2015 01:50:29.086 +0000 (UTC) Date: Mon, 28 Dec 2015 01:50:29 +0000 From: headius@headius.com To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 47135 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 11339 X-Redmine-Issue-Author: normalperson X-Redmine-Sender: headius X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS4AaDwY77BSIN9ox9y+oWDcHyFhjMrU79RbmG WEH3yQXa9I/NZkQDFpPC9MjiV9uMj1oamDvW8nB2+E5sq+IEPgJVUTaWS2uPpzDU+p8qyY1InZbbkB bw31tY2zlxp+GExIvkCTEAEVQTAfGyiPZOfGqmInQ5tc8u3NZ/WItXSTqg== X-ML-Name: ruby-core X-Mail-Count: 72535 Subject: [ruby-core:72535] [Ruby trunk - Feature #11339] [PATCH] io.c: avoid kwarg parsing in C API X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #11339 has been updated by Charles Nutter. Eric Wong wrote: > Anyways, if somebody can design a good API for internal use, > we can use it. Current rb_get_kwargs() and even rb_scan_args() > are inefficient and even error-prone: > http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-core/68507 Something along the lines of vm_get_current_kwarg(name) could simply use existing interpreter structures for managing in-flight keyword arguments. > It's still a work-in-progress, obviously; but the current state > already speeds things up for `exception: false' users. > Implementation details will change, of course; but we need > freedom to change them by having a smaller public C API. I just hope this isn't a trend, since it's a pretty ugly way to work around keyword arguments not optimizing well for calls from Ruby to C. Imagine a world where every core method that accepts keywords went the same route. I think we want a better option before that happens. ---------------------------------------- Feature #11339: [PATCH] io.c: avoid kwarg parsing in C API https://bugs.ruby-lang.org/issues/11339#change-55800 * Author: Eric Wong * Status: Closed * Priority: Normal * Assignee: ---------------------------------------- ~~~ rb_scan_args and hash lookups for kwargs in the C API are clumsy and slow. Instead of improving the C API for performance, use Ruby instead :) Implement IO#read_nonblock and IO#write_nonblock in prelude.rb to avoid argument parsing via rb_scan_args and hash lookups. This speeds up IO#write_nonblock and IO#read_nonblock benchmarks in both cases, including the original non-idiomatic case where the `exception: false' hash is pre-allocated to avoid GC pressure. Now, writing the kwargs in natural, idiomatic Ruby is fastest. I've added the noex2 benchmark to show this. target 0: a (ruby 2.3.0dev (2015-07-08 trunk 51190) [x86_64-linux]) at "a/ruby" target 1: b (ruby 2.3.0dev (2015-07-08 nonblock-kwarg 51190) [x86_64-linux]) at "b/ruby" ----------------------------------------------------------- raw data: [["io_nonblock_noex", [[2.5436805468052626, 2.5724728293716908, 2.4915440678596497], [2.478000810369849, 2.4285155069082975, 2.462410459294915]]], ["io_nonblock_noex2", [[3.012514788657427, 3.034533655270934, 2.9972082190215588], [2.135501991957426, 2.146781364455819, 2.0429874528199434]]]] Elapsed time: 30.348340944 (sec) ----------------------------------------------------------- benchmark results: minimum results in each 3 measurements. Execution time (sec) name a b io_nonblock_noex 2.492 2.429 io_nonblock_noex2 2.997 2.043 Speedup ratio: compare with the result of `a' (greater is better) name b io_nonblock_noex 1.026 io_nonblock_noex2 1.467 Note: I plan to followup commits for other *_nonblock methods Eventually, I even wish to deprecate rb_scan_args :D For what it's worth, I'm more excited about this change than usual and hope to use prelude.rb more. ~~~ ---Files-------------------------------- 0001-io.c-avoid-kwarg-parsing-in-C-API.patch (6.88 KB) -- https://bugs.ruby-lang.org/