From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id 6000E17DC3CC for ; Wed, 23 Dec 2015 10:09:07 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id C8C28B5D86D for ; Wed, 23 Dec 2015 10:41:27 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id 066C218CC7B8 for ; Wed, 23 Dec 2015 10:41:28 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 921751204A0; Wed, 23 Dec 2015 10:41:27 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o10.shared.sendgrid.net (o10.shared.sendgrid.net [173.193.132.135]) by neon.ruby-lang.org (Postfix) with ESMTPS id 22727120474 for ; Wed, 23 Dec 2015 10:41:22 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=yUWKESeA93CSoTe+cjVchLkuaNs=; b=zcM8UX5XmhLVYkeKTC yL/FAgRYWm+NGsMvBXXuToHO7BUl3LZLuYDq6/C3MPUG857SE4iOiAgpzB4IOL8R EfE9aGnKFfeTowycWeq3IeHCQ1NrNRknHw+FC3X2Y0ayqb/bx3uI2wAZHVvTr+lF RGIfdIVAMlxLEIflDsmCX1fFk= Received: by filter0847p1mdw1.sendgrid.net with SMTP id filter0847p1mdw1.14635.5679FBBE10 2015-12-23 01:41:18.1926745 +0000 UTC Received: from herokuapp.com (ec2-54-226-203-109.compute-1.amazonaws.com [54.226.203.109]) by ismtpd0002p1iad1.sendgrid.net (SG) with ESMTP id 5fFaPAWWQxupOVQB5DmQ9g for ; Wed, 23 Dec 2015 01:41:18.041 +0000 (UTC) Date: Wed, 23 Dec 2015 01:41:18 +0000 From: osman@surkatty.org To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 47049 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 11864 X-Redmine-Issue-Author: breadtk X-Redmine-Issue-Assignee: akr X-Redmine-Sender: breadtk X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS4Ozm09zZebcm44OY9pzYFseE+VISeDrGJNXW oItcKqkiiRi6utS8+8eQWqplXx2UEfTPdOTBdrqaGluS5QrE0fHwJ/5kaANLomI7HTW/3wqve1PwkQ B4xv3Dx5Zxz9oO7ZnOsv8/Sa3qBJgDInt1s63M/kjQidFAUlj+jkI77r4A== X-ML-Name: ruby-core X-Mail-Count: 72447 Subject: [ruby-core:72447] [Ruby trunk - Bug #11864] Resolv incorrectly accepts invalid hostnames and caches records between sessions X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #11864 has been updated by Osman Surkatty. Assignee set to Akira Tanaka Assigning directly to Akira Tanaka, the Resolv maintainer per https://bugs.ruby-lang.org/projects/ruby/wiki/MaintainersStdlib ---------------------------------------- Bug #11864: Resolv incorrectly accepts invalid hostnames and caches records between sessions https://bugs.ruby-lang.org/issues/11864#change-55741 * Author: Osman Surkatty * Status: Open * Priority: Normal * Assignee: Akira Tanaka * ruby -v: ruby 2.2.3p173 (2015-08-18 revision 51636) [x86_64-darwin14] * Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN ---------------------------------------- Hello, While working on a DNS related project I noticed that Resolv's getaddresses() and getaddress() functions will incorrectly accepts an empty String and additionally returns a cached record if a new IRB session is invoked. Resolv correctly rejects nil or empty arguments, but I believe the issue here is that the validation of String should require at a minimum a single valid String character. Here is an example of what I mean: $ irb irb(main):001:0> RUBY_VERSION => "2.2.3" irb(main):002:0> require 'resolv' => true irb(main):003:0> Resolv.getaddresses("surkatty.org") => ["54.244.9.126"] irb(main):004:0> Resolv.getaddresses("example.com") => ["93.184.216.34"] irb(main):005:0> Resolv.getaddresses("NX") => [] irb(main):006:0> Resolv.getaddresses("") => ["54.244.9.126"] irb(main):007:0> Resolv.getaddresses() ArgumentError: wrong number of arguments (0 for 1) from /usr/local/Cellar/ruby/2.2.3/lib/ruby/2.2.0/resolv.rb:48:in `getaddresses' from (irb):7 from /usr/local/bin/irb:11:in `
' irb(main):008:0> On line 006:0, I would have expected Resolv.getaddresses("") to return either: 1. Raise an ArgumentError or some other indicating an invalid String was passed 2. Return an empty Array I've also attached a screenshot from my commandline showing the output between IRB sessions as well. ---Files-------------------------------- dns.png (71.5 KB) -- https://bugs.ruby-lang.org/