From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (smtp.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id A2F8917DC893 for ; Tue, 22 Dec 2015 11:04:34 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id 63A75B5D89F for ; Tue, 22 Dec 2015 11:36:52 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id 0BF0818CC7E6 for ; Tue, 22 Dec 2015 11:36:51 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 8CBF6120525; Tue, 22 Dec 2015 11:36:51 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o2.heroku.sendgrid.net (o2.heroku.sendgrid.net [67.228.50.55]) by neon.ruby-lang.org (Postfix) with ESMTPS id 5C00B120522 for ; Tue, 22 Dec 2015 11:36:45 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=5ZpgWa3F/PnnD7lx8bp/mb03q5w=; b=pKnpU5njLuDjJ6kbsS pWoNx5DbOK5mdlOh0R6IsYwREDA6bLAJdQLx9QqcMeO5NZx0CwuN0sMZ+DshGpzc jqJaruXRB4oYQO9SMW7YffzYnk96IKviPAh0ymWSfGYp3IAETz8x32/QqASbwBGq Vc1VqI7GlaOWw2LSrXienTlf0= Received: by filter0646p1mdw1.sendgrid.net with SMTP id filter0646p1mdw1.13881.5678B73620 2015-12-22 02:36:38.351086037 +0000 UTC Received: from herokuapp.com (ec2-54-81-108-186.compute-1.amazonaws.com [54.81.108.186]) by ismtpd0002p1iad1.sendgrid.net (SG) with ESMTP id 4q9HNbF5SpC9EhehOwC21A for ; Tue, 22 Dec 2015 02:36:38.388 +0000 (UTC) Date: Tue, 22 Dec 2015 02:36:38 +0000 From: shugo@ruby-lang.org To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Redmine-MailingListIntegration-Message-Ids: 47026 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 11740 X-Redmine-Issue-Author: Eregon X-Redmine-Issue-Assignee: ko1 X-Redmine-Sender: shugo X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS7q1LEDMK4Prc01xWku+IIjQfWEbEWIXmrPvG /FuO2Qeb170bZrgEd3CD+JQ81RLDzMJRVtkTe315pzKfx+vAwBkBlXvnJW2a8EF5S7aYeyld4q7vzc fs9Zs2B00TaeR68k4hTDMHVoFluyxDRt4/kIaw9yhdljEP2IKdEZn2nBKQ== X-ML-Name: ruby-core X-Mail-Count: 72425 Subject: [ruby-core:72425] [Ruby trunk - Bug #11740] ObjectSpace.each_object exposes internal metaclasses X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #11740 has been updated by Shugo Maeda. Koichi Sasada wrote: > Maybe I missed some points. > Any idea? You shouldn't hide singleton classes of non-class objects. ```diff diff --git a/gc.c b/gc.c index 12be1ea..a574656 100644 --- a/gc.c +++ b/gc.c @@ -2400,6 +2400,14 @@ internal_object_p(VALUE obj) case T_NODE: case T_ZOMBIE: break; + case T_CLASS: + { + if (FL_TEST(obj, FL_SINGLETON)) { + int rb_singleton_class_has_metaclass_p(VALUE sklass); + return RB_TYPE_P(rb_attr_get(obj, id__attached__), T_CLASS) && + rb_singleton_class_has_metaclass_p(obj) == 0; + } + } default: if (!p->as.basic.klass) break; return 0; ``` ---------------------------------------- Bug #11740: ObjectSpace.each_object exposes internal metaclasses https://bugs.ruby-lang.org/issues/11740#change-55718 * Author: Benoit Daloze * Status: Assigned * Priority: Normal * Assignee: Koichi Sasada * ruby -v: ruby 2.3.0dev (2015-11-19 trunk 52672) [x86_64-linux] * Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN ---------------------------------------- ObjectSpace.each_object exposes internal metaclasses and this might result in assumptions being violated since the metaclass structure is not well preserved. See the attached script for an example. The #bla method should always be defined on the metaclass of "klass". See https://bugs.ruby-lang.org/issues/11360#note-2 as well in which I warned against this problem ;) ---Files-------------------------------- objspace_expose_intern_meta.rb (413 Bytes) -- https://bugs.ruby-lang.org/