From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id 1619B17DC3CC for ; Sat, 19 Dec 2015 08:20:49 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id 8BC8DB5D828 for ; Sat, 19 Dec 2015 08:52:58 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id AA5CC18CC7AF for ; Sat, 19 Dec 2015 08:52:58 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 4E1F312048F; Sat, 19 Dec 2015 08:52:56 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o10.shared.sendgrid.net (o10.shared.sendgrid.net [173.193.132.135]) by neon.ruby-lang.org (Postfix) with ESMTPS id 965B8120456 for ; Sat, 19 Dec 2015 08:52:52 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=xbWoJid+WKeoNcHwf+Nd/YY7Bzs=; b=MTkDsNkV58Zi0O5MWF JizuP3m6Bhis6QhSn7gofI/jEWa/4EjizYzsIB6Z3dJ/p9qEh7coqADj9lolF3Tn 4JMSORc0wkgrPKicVhELF8pGC1DzRMUS+Vy4HTBbxJADJueR4Vr+b2gyMMyeXxmh GciyR3NCtI4vj1jXomamJTo1k= Received: by filter0500p1mdw1.sendgrid.net with SMTP id filter0500p1mdw1.8002.56749C4E43 2015-12-18 23:52:46.743396122 +0000 UTC Received: from herokuapp.com (ec2-54-80-126-249.compute-1.amazonaws.com [54.80.126.249]) by ismtpd0004p1iad1.sendgrid.net (SG) with ESMTP id UI2QD7luSF-7o4ITWr9dKg for ; Fri, 18 Dec 2015 23:52:46.662 +0000 (UTC) Date: Fri, 18 Dec 2015 23:52:46 +0000 From: shugo@ruby-lang.org To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Redmine-MailingListIntegration-Message-Ids: 46964 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 11841 X-Redmine-Issue-Author: deepj X-Redmine-Sender: shugo X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS7WMeLVPwsqDpZVSDhYFLGNNW65J5re6IbmFR cLWlRXNH323/p+qO5WfAeUNwChs1M+h9eSHzf2GHM/tXpeVzSzwBgZu0Livcp1ELvP9jIi6DVTTMun r4XqGrXgrOdxza3SSw5EYmY864tOdmKz8+aoLD3L2DfuUZEeD7UBglUfUg== X-SendGrid-Contentd-ID: {"test_id":"1450482768"} X-ML-Name: ruby-core X-Mail-Count: 72370 Subject: [ruby-core:72370] [Ruby trunk - Bug #11841] [Rejected] StringIO with read and `nil, ''` arguments broken with enabled frozen string literal X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #11841 has been updated by Shugo Maeda. Status changed from Open to Rejected deepj # wrote: > ~~~ > # frozen_string_literal: true > > io = StringIO.new('') > > io.read(*[nil, '']) > ~~~ The second argument of StringIO#read is a buffer to read, so it shouldn't be frozen. ``` io.read(*[nil, String.new]) ``` ---------------------------------------- Bug #11841: StringIO with read and `nil, ''` arguments broken with enabled frozen string literal https://bugs.ruby-lang.org/issues/11841#change-55661 * Author: deepj # * Status: Rejected * Priority: Normal * Assignee: * ruby -v: ruby 2.3.0dev (2015-12-19 trunk 53195) [x86_64-darwin15] * Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN ---------------------------------------- I'm not sure what behavior is expected here. But the following use case is used in rack (https://github.com/rack/rack/blob/master/test/spec_lint.rb#L496). If frozen string literal is enabled it throws `read': can't modify frozen String (RuntimeError), otherwise nothing. ~~~ # frozen_string_literal: true io = StringIO.new('') io.read(*[nil, '']) ~~~ -- https://bugs.ruby-lang.org/