From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id 4FACD17DBC17 for ; Thu, 17 Dec 2015 11:25:48 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id 6CA71B5D841 for ; Thu, 17 Dec 2015 11:57:52 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id AFEBD18CC7B9 for ; Thu, 17 Dec 2015 11:57:51 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 4AD971204B3; Thu, 17 Dec 2015 11:57:50 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o2.heroku.sendgrid.net (o2.heroku.sendgrid.net [67.228.50.55]) by neon.ruby-lang.org (Postfix) with ESMTPS id 5F7F91204A7 for ; Thu, 17 Dec 2015 11:57:47 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=ja/XTDhPuhn/JJjUta20i+ygasE=; b=mjsA6kTLWQgVRR9xiI 8nnLkwWRIaOCxwSynXbdEcDx7AOj2mZMrdy1w0kV+LrQSWTalozAg9OBoQToUBzb RAHnMGf8uqwXB74h0LBvaz1qEMD/nLQy1SBUjGJsa2VFXLsWkP8Ac3ic5SbP2EcM oRYQNM6pssbYVKkE1ewNxQ9QM= Received: by filter0828p1mdw1.sendgrid.net with SMTP id filter0828p1mdw1.2539.567224A811 2015-12-17 02:57:44.209824609 +0000 UTC Received: from herokuapp.com (ec2-54-196-68-32.compute-1.amazonaws.com [54.196.68.32]) by ismtpd0005p1iad1.sendgrid.net (SG) with ESMTP id ESFXNygCTvquk34IiuoTww for ; Thu, 17 Dec 2015 02:57:44.181 +0000 (UTC) Date: Thu, 17 Dec 2015 02:57:44 +0000 From: nobu@ruby-lang.org To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Redmine-MailingListIntegration-Message-Ids: 46912 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 11740 X-Redmine-Issue-Author: Eregon X-Redmine-Issue-Assignee: ko1 X-Redmine-Sender: nobu X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS5mL9uTCsmg9DbB0EqrhjI1yxyNWuoEjUnJe1 XEPJqE6kCP0gZbRdBKwHewCdR6iM9prMAxyCZoF0/n/Ab5hsn+DeisqRQLUVDPJkDUDHntjcAgmyWj eHlUAhLPQzVeS2XeR0Qa8UVACvs0pcUqUuDBFO1uZ4aCc2aQpLn6OykH/g== X-ML-Name: ruby-core X-Mail-Count: 72202 Subject: [ruby-core:72202] [Ruby trunk - Bug #11740] ObjectSpace.each_object exposes internal metaclasses X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #11740 has been updated by Nobuyoshi Nakada. Koichi Sasada wrote: > ```diff > +int > +rb_singleton_class_has_metaclass_p(VALUE sklass) > +{ > + return rb_ivar_get(METACLASS_OF(sklass), id_attached) == sklass; > +} Should be `rb_attr_get` instead. Benoit Daloze wrote: > PS: How should I apply the patch? I tried `patch < x.patch` but I got a rejected hunk in gc.c Redmine seems expand tabs, you can see markdown source from a pencil icon. ---------------------------------------- Bug #11740: ObjectSpace.each_object exposes internal metaclasses https://bugs.ruby-lang.org/issues/11740#change-55613 * Author: Benoit Daloze * Status: Open * Priority: Normal * Assignee: Koichi Sasada * ruby -v: ruby 2.3.0dev (2015-11-19 trunk 52672) [x86_64-linux] * Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN ---------------------------------------- ObjectSpace.each_object exposes internal metaclasses and this might result in assumptions being violated since the metaclass structure is not well preserved. See the attached script for an example. The #bla method should always be defined on the metaclass of "klass". See https://bugs.ruby-lang.org/issues/11360#note-2 as well in which I warned against this problem ;) ---Files-------------------------------- objspace_expose_intern_meta.rb (413 Bytes) -- https://bugs.ruby-lang.org/