From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id CDE9719E0032 for ; Mon, 7 Dec 2015 16:19:51 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id BFFD6B5D836 for ; Mon, 7 Dec 2015 16:51:28 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id 3A6F718CC7D1 for ; Mon, 7 Dec 2015 16:51:29 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 3601F1204DA; Mon, 7 Dec 2015 16:51:29 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o2.heroku.sendgrid.net (o2.heroku.sendgrid.net [67.228.50.55]) by neon.ruby-lang.org (Postfix) with ESMTPS id 8806412049A for ; Mon, 7 Dec 2015 16:51:25 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=h8YWKeBZZXIw6ceQct/C+hMOCpY=; b=PuCQpH7ZHRApzOD+pp y3k1KYQumu5mRpbukNgAoyoXbI5F92ONXYaPFJYJlLrnDjUoPnEOcE+dRlic5+2l 8QXXgA2zKieG4kW+V9KWWmRGEsFfP1fZogHAfPOLaDlrkUy59A5Dwwuq9k2jSLiI b/9DYYdv5SALwhee76ZJp/qDo= Received: by filter0559p1mdw1.sendgrid.net with SMTP id filter0559p1mdw1.2415.56653A7A2E 2015-12-07 07:51:22.526382081 +0000 UTC Received: from herokuapp.com (ec2-54-198-241-74.compute-1.amazonaws.com [54.198.241.74]) by ismtpd0002p1iad1.sendgrid.net (SG) with ESMTP id fPfWYwAjSDGquQqyw8EV4A Mon, 07 Dec 2015 07:51:22.437 +0000 (UTC) Date: Mon, 07 Dec 2015 07:51:22 +0000 From: nobu@ruby-lang.org To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Redmine-MailingListIntegration-Message-Ids: 46588 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 11735 X-Redmine-Issue-Author: sikachu X-Redmine-Issue-Assignee: matz X-Redmine-Sender: nobu X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS5b/hVdhCeYyExohT5hVDzpgHqeLFLnE6A3fo au/2k0jwfauR7yPOtw8NT+e/rGjq0WwJkXP1S3Q72O2XzdZ23CCkwJB3youcT60fDPX/AlWr3yp09S lUieS3MfQvf7K8MoHCChEQLUMaFrRFeOQ0mW X-ML-Name: ruby-core X-Mail-Count: 71891 Subject: [ruby-core:71891] [Ruby trunk - Feature #11735] Porting String#squish and String#squish! from Ruby on Rails' Active Support X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #11735 has been updated by Nobuyoshi Nakada. https://github.com/ruby/ruby/compare/trunk...nobu:feature/11735-squish ---------------------------------------- Feature #11735: Porting String#squish and String#squish! from Ruby on Rails' Active Support https://bugs.ruby-lang.org/issues/11735#change-55297 * Author: Prem Sichanugrist * Status: Open * Priority: Normal * Assignee: Yukihiro Matsumoto ---------------------------------------- Hi, I have been using this `String#squish` method so many time when I'm using Rails, and I think it should be a useful addition to core. Here's the method on Rails' documentation: http://api.rubyonrails.org/v4.2.5/classes/String.html#method-i-squish This method is very useful when you have to write a multi-line string using heredoc, but you actually does not care about the white-spaces before, after, and in-between the string. For example: ~~~ruby <<-SQL.squish SELECT * FROM users WHERE users.username = 'sikachu' SQL #=> "SELECT * FROM users WHERE users.username='sikachu'" ~~~ Another example usage is when you are on the project that have a line length code standard, and you have to write a long warning message that needs to be printed to stdout: ~~~ruby puts <<-WARNING.squish Unable to connect to the server. Please double-check that you are currently connecting to the internet and your proxy server is working. WARNING #=> Unable to connect to the server. Please double-check that you are currently connecting to the internet and your proxy server is working. ~~~ By the way, this is my first patch and my first time writing something in C, so there might be something that does not look right to you. I'll happy to revise this patch (and learn about C in the process!) from your feedback. Thank you, Prem ---Files-------------------------------- 0001-Introduce-String-squish-and-String-squish.patch (4.67 KB) -- https://bugs.ruby-lang.org/