From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id 8A3C719C0578 for ; Wed, 2 Dec 2015 15:40:39 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id D3204B5D897 for ; Wed, 2 Dec 2015 16:12:02 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id 4930418CC7E4 for ; Wed, 2 Dec 2015 16:12:03 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id BDF7112046B; Wed, 2 Dec 2015 16:12:00 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o10.shared.sendgrid.net (o10.shared.sendgrid.net [173.193.132.135]) by neon.ruby-lang.org (Postfix) with ESMTPS id F038012046B for ; Wed, 2 Dec 2015 16:11:29 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=I/V9Ud0L+PQYfy6vbDGz7VfS/Bs=; b=hlCaelG9xE4zZa9dha K9fzAqVI+4+JS/tifmzYnQtJCRcFb2J53zpBGv3Lr7gftO/si53zUj9ZcRNPb61e f0nhFa7+zVg5C5HtyK7avB5LvSgLowUbdiWv9b2CcV5AfyO0gs5yalUiDKvJXqBZ ke6An2RTgrKG/LWZPqDj+ZlN4= Received: by filter0570p1mdw1.sendgrid.net with SMTP id filter0570p1mdw1.10817.565E999B6D 2015-12-02 07:11:23.913863865 +0000 UTC Received: from herokuapp.com (ec2-107-20-68-221.compute-1.amazonaws.com [107.20.68.221]) by ismtpd0004p1iad1.sendgrid.net (SG) with ESMTP id IuB1exbLRQegpwv5zj60lw Wed, 02 Dec 2015 07:11:24.099 +0000 (UTC) Date: Wed, 02 Dec 2015 07:11:24 +0000 From: colin@invoca.com To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Redmine-MailingListIntegration-Message-Ids: 46485 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 11759 X-Redmine-Issue-Author: mperham X-Redmine-Sender: colindkelley X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS7BJ0TTVoR8HQYs4FV8o+DZlxhKt0tENfxwMS p8gmvil5IQhThcZHQ868OU+w9AxSnp9r5emcrSa4E0JL7jc7E5CvnKrgzeEwkx8jjBi7O3WWrhmVeL rLZS0FrGwThKX/EAWEA7ZSdnY5rX/hwxGDZB X-ML-Name: ruby-core X-Mail-Count: 71797 Subject: [ruby-core:71797] [Ruby trunk - Bug #11759] URI breaks with frozen strings X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #11759 has been updated by Colin Kelley. File 11759.patch added Isn't it sufficient to initialize the string buffer with String.new? I've attached a patch that also includes the magic comment to indicate that this file has been converted. ---------------------------------------- Bug #11759: URI breaks with frozen strings https://bugs.ruby-lang.org/issues/11759#change-55205 * Author: Mike Perham * Status: Open * Priority: Normal * Assignee: * ruby -v: 2.3.0-preview1 * Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN ---------------------------------------- It appears URI uses String mutation and breaks frozen string mode. ~~~ $ RUBYOPT="--enable-frozen-string-literal" bundle exec rake /Users/mike/.rubies/ruby-2.3.0-preview1/lib/ruby/2.3.0/uri/generic.rb:1344:in `to_s': can't modify frozen String (RuntimeError) /Users/mike/.gem/ruby/2.3.0/gems/bundler-1.10.6/lib/bundler/source/rubygems.rb:257:in `normalize_uri' /Users/mike/.gem/ruby/2.3.0/gems/bundler-1.10.6/lib/bundler/source/rubygems.rb:198:in `add_remote' /Users/mike/.gem/ruby/2.3.0/gems/bundler-1.10.6/lib/bundler/source/rubygems.rb:25:in `block in initialize' /Users/mike/.gem/ruby/2.3.0/gems/bundler-1.10.6/lib/bundler/source/rubygems.rb:25:in `reverse_each' /Users/mike/.gem/ruby/2.3.0/gems/bundler-1.10.6/lib/bundler/source/rubygems.rb:25:in `initialize' ~~~ ---Files-------------------------------- 0001-Do-not-mutate-strings-in-URI-to_s.patch (1.76 KB) 11759.patch (610 Bytes) -- https://bugs.ruby-lang.org/