From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id C5B2619C02F7 for ; Wed, 25 Nov 2015 04:11:09 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id 7BBECB5D839 for ; Wed, 25 Nov 2015 04:42:13 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id 726F318CC7B6 for ; Wed, 25 Nov 2015 04:42:13 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id B681412048F; Wed, 25 Nov 2015 04:42:11 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o2.heroku.sendgrid.net (o2.heroku.sendgrid.net [67.228.50.55]) by neon.ruby-lang.org (Postfix) with ESMTPS id 69A33120465 for ; Wed, 25 Nov 2015 04:42:08 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=wdiomKq7OoSoKEWWemHzjxszO6o=; b=UkfrjLoaBNB7kSBefx LIBdx+zBxUlmwTdMrNzoxWwo8Mg7e6GmJpIW/8CNp1HrkI8QvkaiYK/19PiM8voA ZTkF9RWKAABM8aPmjENZEqa52fWjNhWBNDOjMV2ItaY3nIkeYUngjhLNYD9rLgSO fm63Y+Ix21HxAM443tMbfsslc= Received: by filter0464p1mdw1.sendgrid.net with SMTP id filter0464p1mdw1.412.5654BD8930 2015-11-24 19:42:01.69236672 +0000 UTC Received: from herokuapp.com (ec2-23-20-162-181.compute-1.amazonaws.com [23.20.162.181]) by ismtpd0002p1iad1.sendgrid.net (SG) with ESMTP id XNmda23XTPebBXQHmjvvWA Tue, 24 Nov 2015 19:42:01.651 +0000 (UTC) Date: Tue, 24 Nov 2015 19:42:01 +0000 From: s@sikac.hu To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Redmine-MailingListIntegration-Message-Ids: 46335 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 11735 X-Redmine-Issue-Author: sikachu X-Redmine-Sender: sikachu X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS6OCi9qfA7v2CXNTI0nSooYzgGLO70Q19w84r uNC18f990GF3Fuyy8FfYB5WFRvyTOs4LA9/Jx15voL6dsvEr+5jFzzkOE2WUhufDIHzt+PO/zOmpOC /HBPWSvJ9K/h3V8= X-ML-Name: ruby-core X-Mail-Count: 71660 Subject: [ruby-core:71660] [Ruby trunk - Feature #11735] Porting String#squish and String#squish! from Ruby on Rails' Active Support X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #11735 has been updated by Prem Sichanugrist. Description updated ---------------------------------------- Feature #11735: Porting String#squish and String#squish! from Ruby on Rails' Active Support https://bugs.ruby-lang.org/issues/11735#change-55064 * Author: Prem Sichanugrist * Status: Open * Priority: Normal * Assignee: ---------------------------------------- Hi, I have been using this `String#squish` method so many time when I'm using Rails, and I think it should be a useful addition to core. Here's the method on Rails' documentation: http://api.rubyonrails.org/v4.2.5/classes/String.html#method-i-squish This method is very useful when you have to write a multi-line string using heredoc, but you actually does not care about the white-spaces before, after, and in-between the string. For example: ~~~ <<-SQL.squish SELECT * FROM users WHERE users.username = 'sikachu' SQL #=> "SELECT * FROM users WHERE users.username='sikachu'" ~~~ Another example usage is when you are on the project that have a line length code standard, and you have to write a long warning message that needs to be printed to stdout: ~~~ puts <<-WARNING.squish Unable to connect to the server. Please double-check that you are currently connecting to the internet and your proxy server is working. WARNING #=> Unable to connect to the server. Please double-check that you are currently connecting to the internet and your proxy server is working. ~~~ By the way, this is my first patch and my first time writing something in C, so there might be something that does not look right to you. I'll happy to revise this patch (and learn about C in the process!) from your feedback. Thank you, Prem ---Files-------------------------------- 0001-Introduce-String-squish-and-String-squish.patch (4.67 KB) -- https://bugs.ruby-lang.org/