From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id 834C319C0017 for ; Thu, 19 Nov 2015 10:07:34 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id 5B50EB5D858 for ; Thu, 19 Nov 2015 10:38:17 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id 78CE618CC7B5 for ; Thu, 19 Nov 2015 10:38:17 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id C5B5A120451; Thu, 19 Nov 2015 10:38:15 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o2.heroku.sendgrid.net (o2.heroku.sendgrid.net [67.228.50.55]) by neon.ruby-lang.org (Postfix) with ESMTPS id 28283120433 for ; Thu, 19 Nov 2015 10:38:11 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=KS6HBYOIeL3Up+7owU3YIajzaXU=; b=oC06ekrQ2jF1xrFvC0 kC6yMCTxV4hzO2OY0TwxSpSrhcwNF2VH/cj30ge31qixbvmCAb0+ZMk/NBal0COa HTxjoeC7e06f6h8KzlilE+cRa1xtAnH4BWlZfcxjFDbUAAk1CSyosmls5VBFuQM+ IJ7mRzPjmyrpBuD01uHgVBaT4= Received: by filter0793p1mdw1.sendgrid.net with SMTP id filter0793p1mdw1.23398.564D27FF7 2015-11-19 01:38:07.103905518 +0000 UTC Received: from herokuapp.com (ec2-54-145-145-74.compute-1.amazonaws.com [54.145.145.74]) by ismtpd0005p1iad1.sendgrid.net (SG) with ESMTP id f97WyjZASwOUAlf532C7FQ Thu, 19 Nov 2015 01:38:07.198 +0000 (UTC) Date: Thu, 19 Nov 2015 01:38:07 +0000 From: prijutme4ty@gmail.com To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Redmine-MailingListIntegration-Message-Ids: 46232 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 10984 X-Redmine-Issue-Author: olivierlacan X-Redmine-Issue-Assignee: akr X-Redmine-Sender: prijutme4ty X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS79wOgJb7ZGMgDkk6zOOVXD5U4gzZAxN310dU 1R42ohvKpqZGPX+0fRu8TQJ1LUq1xpFwEhtUI45b8wa5kRzQ2513FmTeqf1W0uuhOyaNNA1Ulms+XY Xx7EgXRdaL3RpH6xMk8508nsq8Kz/ilYKYzZ X-ML-Name: ruby-core X-Mail-Count: 71569 Subject: [ruby-core:71569] [Ruby trunk - Bug #10984] Hash#contain? to check whether hash contains other hash X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #10984 has been updated by Ilya Vorontsov. Tracker changed from Feature to Bug > Akira Tanaka wrote: > > ``` > % ruby -e ' > class Hash > def <=(other) > self.merge(other) == other > end > def >=(other) > self.merge(other) == self > end > def <(other) > self <= other && self != other > end > def >(other) > self >= other && self != other > end > end > ``` This implies that ```ruby {a: 1, b: 2} <= {a: 1, b: 3} {a: 1, b: 3} <= {a: 1, b: 2} ``` Is that expected? This breaks the main use-case in testing method results. ---------------------------------------- Bug #10984: Hash#contain? to check whether hash contains other hash https://bugs.ruby-lang.org/issues/10984#change-54949 * Author: Olivier Lacan * Status: Closed * Priority: Normal * Assignee: Akira Tanaka * ruby -v: * Backport: ---------------------------------------- Comparing hashes seems like a common practice but there currently isn't a method to ask a hash instance whether it includes another hash instance. The most intuitive method to reach for would be `Hash#include?` but it is in fact an alias to `Hash#has_key?` What I'm looking for can be achieved with: ~~~ class Hash def contain?(other) self.merge(other) == self end end ~~~ Here's a simple demo of `#contain?` in use: ~~~ { a: true, b: false }.contain?({ a: true}) # => true { a: true, b: false }.contain?({ b: false}) # => true { a: true, b: false }.contain?({ a: false}) # => false { a: true, b: false }.contain?({ c: true}) # => false ~~~ One important note is that this method is *not checking for nested hash matches*. This may need to be addressed when the parameters include a nested hash perhaps. Thanks to Terence Lee's help, nobu created a patch for this feature last year. I've only modified the name of the method from [his original patch](https://gist.github.com/nobu/dfe8ba14a48fc949f2ed) and attached it to this issue. ---Files-------------------------------- Hash#contain_.patch (2.22 KB) -- https://bugs.ruby-lang.org/