From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id D1BA419C0048 for ; Wed, 11 Nov 2015 14:03:58 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id AE4E4B5D927 for ; Wed, 11 Nov 2015 14:33:40 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id 0904E18CC7B5 for ; Wed, 11 Nov 2015 14:33:40 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 976FE120450; Wed, 11 Nov 2015 14:33:36 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o2.heroku.sendgrid.net (o2.heroku.sendgrid.net [67.228.50.55]) by neon.ruby-lang.org (Postfix) with ESMTPS id 5AC86120410 for ; Wed, 11 Nov 2015 14:33:33 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=pPDZ4L/EfN3hdGKPn2NfCPRuWJE=; b=xknhUQvFvjIau+n9VQ xY7fVDO3jw++P96rrAW3XVdyYvvCRbxjQ/MWwpYvFKEp4SwRyNBar41ixdpJXU4a oGbJ31DsZsI5nvaC491alnhd1mpXsvCazFgMvrmdhpK+lVDZF5UvCzwnAQ1IBKgY GqZoYu1vo4qqVEPxvcTxEbD6Y= Received: by filter0811p1mdw1.sendgrid.net with SMTP id filter0811p1mdw1.12235.5642D32943 2015-11-11 05:33:29.867608467 +0000 UTC Received: from herokuapp.com (ec2-50-17-101-52.compute-1.amazonaws.com [50.17.101.52]) by ismtpd0001p1iad1.sendgrid.net (SG) with ESMTP id ilwKaP3GTFuUkauFRAsm9A Wed, 11 Nov 2015 05:33:30.035 +0000 (UTC) Date: Wed, 11 Nov 2015 05:33:29 +0000 From: akr@fsij.org To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Redmine-MailingListIntegration-Message-Ids: 46080 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 10984 X-Redmine-Issue-Author: olivierlacan X-Redmine-Issue-Assignee: akr X-Redmine-Sender: akr X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS4h7O1KZTyNXSb43MJDe5P4gIu0dTAdZ7NZDE HSMk4Or1yWz/0mmZMCE1VFjoUvWL/3UMaEqDqXyH/qv2MlYiB6tHXZxNsOqnh+VDgxKqZZT7lurHL+ lFwmQEMJGyvfpczAgFEFNFQ3cCGdVHJksWWu X-ML-Name: ruby-core X-Mail-Count: 71440 Subject: [ruby-core:71440] [Ruby trunk - Feature #10984] Hash#contain? to check whether hash contains other hash X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #10984 has been updated by Akira Tanaka. Akira Tanaka wrote: > ``` > % ruby -e ' > class Hash > def <=(other) > self.merge(other) == other > end > def >=(other) > self.merge(other) == self > end > def <(other) > self <= other && self != other > end > def >(other) > self >= other && self != other > end > end > hs = [{a:1, b:2}, {a:1, b:2, c:3}] > ops = %w[<= >= < >] > ops.each {|op| > hs.each {|h1| > hs.each {|h2| > puts "#{h1} #{op} #{h2} = #{h1.send(op, h2)}" > } > } > } > ' > {:a=>1, :b=>2} <= {:a=>1, :b=>2} = true > {:a=>1, :b=>2} <= {:a=>1, :b=>2, :c=>3} = true > {:a=>1, :b=>2, :c=>3} <= {:a=>1, :b=>2} = false > {:a=>1, :b=>2, :c=>3} <= {:a=>1, :b=>2, :c=>3} = true > {:a=>1, :b=>2} >= {:a=>1, :b=>2} = true > {:a=>1, :b=>2} >= {:a=>1, :b=>2, :c=>3} = false > {:a=>1, :b=>2, :c=>3} >= {:a=>1, :b=>2} = true > {:a=>1, :b=>2, :c=>3} >= {:a=>1, :b=>2, :c=>3} = true > {:a=>1, :b=>2} < {:a=>1, :b=>2} = false > {:a=>1, :b=>2} < {:a=>1, :b=>2, :c=>3} = true > {:a=>1, :b=>2, :c=>3} < {:a=>1, :b=>2} = false > {:a=>1, :b=>2, :c=>3} < {:a=>1, :b=>2, :c=>3} = false > {:a=>1, :b=>2} > {:a=>1, :b=>2} = false > {:a=>1, :b=>2} > {:a=>1, :b=>2, :c=>3} = false > {:a=>1, :b=>2, :c=>3} > {:a=>1, :b=>2} = true > {:a=>1, :b=>2, :c=>3} > {:a=>1, :b=>2, :c=>3} = false > ``` For the record, this sample implementation was wrong. It should consider that two hashs may have different values for same key. ``` % ruby -e ' class Hash def <=(other) self.merge(other) {|k,v1,v2| v1 } == other end def >=(other) self.merge(other) {|k,v1,v2| v2 } == self end def <(other) self <= other && self != other end def >(other) self >= other && self != other end end hs = [{a:1}, {a:2}] ops = %w[<= >= < >] ops.each {|op| hs.each {|h1| hs.each {|h2| puts "#{h1} #{op} #{h2} = #{h1.send(op, h2)}" } } } ' {:a=>1} <= {:a=>1} = true {:a=>1} <= {:a=>2} = false {:a=>2} <= {:a=>1} = false {:a=>2} <= {:a=>2} = true {:a=>1} >= {:a=>1} = true {:a=>1} >= {:a=>2} = false {:a=>2} >= {:a=>1} = false {:a=>2} >= {:a=>2} = true {:a=>1} < {:a=>1} = false {:a=>1} < {:a=>2} = false {:a=>2} < {:a=>1} = false {:a=>2} < {:a=>2} = false {:a=>1} > {:a=>1} = false {:a=>1} > {:a=>2} = false {:a=>2} > {:a=>1} = false {:a=>2} > {:a=>2} = false ``` Note that nobu's implementation already committed has no problem. ---------------------------------------- Feature #10984: Hash#contain? to check whether hash contains other hash https://bugs.ruby-lang.org/issues/10984#change-54808 * Author: Olivier Lacan * Status: Closed * Priority: Normal * Assignee: Akira Tanaka ---------------------------------------- Comparing hashes seems like a common practice but there currently isn't a method to ask a hash instance whether it includes another hash instance. The most intuitive method to reach for would be `Hash#include?` but it is in fact an alias to `Hash#has_key?` What I'm looking for can be achieved with: ~~~ class Hash def contain?(other) self.merge(other) == self end end ~~~ Here's a simple demo of `#contain?` in use: ~~~ { a: true, b: false }.contain?({ a: true}) # => true { a: true, b: false }.contain?({ b: false}) # => true { a: true, b: false }.contain?({ a: false}) # => false { a: true, b: false }.contain?({ c: true}) # => false ~~~ One important note is that this method is *not checking for nested hash matches*. This may need to be addressed when the parameters include a nested hash perhaps. Thanks to Terence Lee's help, nobu created a patch for this feature last year. I've only modified the name of the method from [his original patch](https://gist.github.com/nobu/dfe8ba14a48fc949f2ed) and attached it to this issue. ---Files-------------------------------- Hash#contain_.patch (2.22 KB) -- https://bugs.ruby-lang.org/