From: kosaki.motohiro@gmail.com
To: ruby-core@ruby-lang.org
Subject: [ruby-core:71197] [Ruby trunk - Feature #11607] [PATCH] fiddle: release GVL for ffi_call
Date: Mon, 26 Oct 2015 21:27:03 +0000 [thread overview]
Message-ID: <redmine.journal-54575.20151026212702.3860d3119fffd2da@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-11607.20151019214639@ruby-lang.org
Issue #11607 has been updated by Motohiro KOSAKI.
Nevermind. I did misinterpret your code. I'm ok either.
----------------------------------------
Feature #11607: [PATCH] fiddle: release GVL for ffi_call
https://bugs.ruby-lang.org/issues/11607#change-54575
* Author: Eric Wong
* Status: Open
* Priority: Normal
* Assignee: Aaron Patterson
----------------------------------------
Some external functions I wish to call may take a long time
and unnecessarily block other threads. This may lead to performance
regressions for fast functions as releasing/acquiring the GVL is not
cheap, but can improve performance for long-running functions
in multi-threaded applications.
This also means we must reacquire the GVL when calling Ruby-defined
callbacks for Fiddle::Closure, meaning we must detect whether the
current thread has the GVL by exporting ruby_thread_has_gvl_p
in internal.h
---Files--------------------------------
0001-fiddle-release-GVL-for-ffi_call.patch (11.3 KB)
fiddle-release-GVL-for-ffi_call-v2.patch (11.2 KB)
--
https://bugs.ruby-lang.org/
next prev parent reply other threads:[~2015-10-26 20:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <redmine.issue-11607.20151019214639@ruby-lang.org>
2015-10-19 21:46 ` [ruby-core:71121] [Ruby trunk - Feature #11607] [Open] [PATCH] fiddle: release GVL for ffi_call normalperson
2015-10-20 22:28 ` [ruby-core:71127] [Ruby trunk - Feature #11607] " normalperson
2015-10-26 8:25 ` [ruby-core:71183] " KOSAKI Motohiro
2015-10-26 20:11 ` [ruby-core:71196] " Eric Wong
2015-10-26 21:27 ` kosaki.motohiro [this message]
2015-10-27 8:43 ` [ruby-core:71211] " naruse
2015-10-27 8:54 ` [ruby-core:71212] " Eric Wong
2015-10-28 14:47 ` [ruby-core:71246] " Aaron Patterson
2015-10-28 20:36 ` [ruby-core:71254] " Eric Wong
2015-11-13 5:08 ` [ruby-core:71474] " Eric Wong
2015-11-23 15:41 ` [ruby-core:71642] " Aaron Patterson
2015-12-03 3:14 ` [ruby-core:71808] " ngotogenome
2015-12-03 3:59 ` [ruby-core:71809] " Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-54575.20151026212702.3860d3119fffd2da@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).