From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id 6364219C003F for ; Sun, 25 Oct 2015 00:24:03 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id 29550B5D87E for ; Sun, 25 Oct 2015 00:51:28 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id 280FB95241E for ; Sun, 25 Oct 2015 00:51:27 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 25DB61204DE; Sun, 25 Oct 2015 00:51:27 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o10.shared.sendgrid.net (o10.shared.sendgrid.net [173.193.132.135]) by neon.ruby-lang.org (Postfix) with ESMTPS id BCEF1120467 for ; Sun, 25 Oct 2015 00:51:23 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=nEs5k0oTR4o1axm9/PYkBT4FOlw=; b=sX/ezZcx3HwxG1BaOf MkewHQRXM3WlZ14v3rin7xol+EjGVHH7Fiz4NCkfYWRbp3Q3C/IlsYXGxvkXvkSA P10x5yfMfKYAltmvhGw7J92D8c8yOKOTq12xFITG/nnDODmfQFus8CjM+VI7Uwjt LRf1QWTKAt6Z5fHv9tpmCspM4= Received: by filter-402.sjc1.sendgrid.net with SMTP id filter-402.29127.562BA8F756 2015-10-24 15:51:19.958212278 +0000 UTC Received: from herokuapp.com (ec2-23-20-122-32.compute-1.amazonaws.com [23.20.122.32]) by ismtpd0003p1iad1.sendgrid.net (SG) with ESMTP id 1oaGHhETT66JLf9qpXo4gg Sat, 24 Oct 2015 15:51:19.969 +0000 (UTC) Date: Sat, 24 Oct 2015 15:51:19 +0000 From: yosy101@gmail.com To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Redmine-MailingListIntegration-Message-Ids: 45807 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 11599 X-Redmine-Issue-Author: yosiat X-Redmine-Issue-Assignee: nobu X-Redmine-Sender: yosiat X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS5kYxN/5hm/5GhttaSKnggp4g0U5Fk3kavMWS 9Ikp/8Jhe4RFX9rvw79aS+NqTIGUMUSLuym1cr+DEOX2joXytzyfWhxBqUeKAZ5AkFSAYk0H4PEsDw 9+IaC8I5iGBm7aM= X-ML-Name: ruby-core X-Mail-Count: 71180 Subject: [ruby-core:71180] [Ruby trunk - Feature #11599] Dump entries of hash in ObjectSpace X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #11599 has been updated by Yosi Attias. What is the status of the patch? Is this ok? something to fix? ---------------------------------------- Feature #11599: Dump entries of hash in ObjectSpace https://bugs.ruby-lang.org/issues/11599#change-54560 * Author: Yosi Attias * Status: Open * Priority: Normal * Assignee: Nobuyoshi Nakada ---------------------------------------- Hi, *This is my first c code contribution :)* I am helping developing heap-analyzer (github.com/tenderlove/heap-analyzer), and currently the dumps lacks of "type metadata" information, like: * Hash entries - the keys and value * Array items - the items of the array etc. In the included patch, I have changed the dump of hash to add entries of hash. For example, given the next hash: ~~~ruby hash = { int_key: 1, str_key: "This is my string", inner_hash: { b: 2 } } ~~~ The dump result (ObjectSpace.dump(hash)) will be: ~~~json { "address": "0x007fbc01110340", "type": "HASH", "class": "0x007fbc0109b400", "size": 3, "entries": [ { "is_key_address": false, "key": ":int_key", "is_value_address": false, "value": "1" }, { "is_key_address": false, "key": ":str_key", "is_value_address": true, "value": "0x007fbc01110390" }, { "is_key_address": false, "key": ":inner_hash", "is_value_address": true, "value": "0x007fbc01110368" } ], "references": [ "0x007fbc01110390", "0x007fbc01110368" ], "memsize": 232, "flags": { "wb_protected": true } } ~~~ As you can see, I have the "entries" array, where each entry contains: "is_key_address", "is_value_address" - if the key/value are special consts the inspected value will be printed in the "key"/"value" properties, other their address will be print. Hope you will accept the patch (and I can submit another one for arrays), Yosi. ---Files-------------------------------- objspace_dump_hash_entries.patch (4.8 KB) objspace_dump.patch (4.53 KB) -- https://bugs.ruby-lang.org/