From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id 6C83819C0029 for ; Mon, 19 Oct 2015 14:01:44 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id EF3F9B5D832 for ; Mon, 19 Oct 2015 14:28:27 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id 011B4952446 for ; Mon, 19 Oct 2015 14:28:27 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 11537120468; Mon, 19 Oct 2015 14:28:26 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o10.shared.sendgrid.net (o10.shared.sendgrid.net [173.193.132.135]) by neon.ruby-lang.org (Postfix) with ESMTPS id CAE5112041F for ; Mon, 19 Oct 2015 14:28:21 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=2PxGCpQmIrx8wtcOAguCWDFe3o8=; b=LniubfDmvSh58JuklN qqHVwfx2k8IkRv4H7vCOw0T7fhf5BeA6+ifi9xKrK3pSj+pV3vgq4G8dRL8zUnao SDtrxHeNCci97TJ3FCYWNmSGPX9yC30B63a0dKqiDIdm/FRoNomPa1FTBh1E4IwQ 407w60m8j5AszCI4d9s1OCCmI= Received: by filter0507p1mdw1.sendgrid.net with SMTP id filter0507p1mdw1.18513.56247F7011 2015-10-19 05:28:16.228494149 +0000 UTC Received: from herokuapp.com (ec2-54-167-102-41.compute-1.amazonaws.com [54.167.102.41]) by ismtpd0002p1iad1.sendgrid.net (SG) with ESMTP id rloGzoYoTAOd9hLCrQXHLA Mon, 19 Oct 2015 05:28:16.037 +0000 (UTC) Date: Mon, 19 Oct 2015 05:28:16 +0000 From: yosy101@gmail.com To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Redmine-MailingListIntegration-Message-Ids: 45733 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 11599 X-Redmine-Issue-Author: yosiat X-Redmine-Sender: yosiat X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS54Vc007YjSvg8hUdHw7QOOLkAdF11JMcyVfL 3vOa3ojGt/IEgzGnMva34gNx+VsEBeykZrbf0JoqUIBRSkbgmFptC58Wc7ZvGbELFuuMdnxJu4phFV UTxKl40xH9+vGnLTK/YTeToBEqt6VtMWhyea X-ML-Name: ruby-core X-Mail-Count: 71109 Subject: [ruby-core:71109] [Ruby trunk - Feature #11599] Dump entries of hash in ObjectSpace X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #11599 has been updated by Yosi Attias. Nobuyoshi Nakada wrote: > Yosi Attias wrote: > > and to make sure there are no confusion some one did some like this: > > > > ~~~ruby > > h = {address: "0x007fbc01110368" } > > ~~~ > > I can't get your point here. > `{"key":":a","value":"0x007f8f3c8baf88"}` seems clear enough to me. Yes, but how can you distinguish between string value which is address or address to other ruby object: `h = {a: "0x007f8f3c8baf88"}` to `h = {a: {b: 1}}` ---------------------------------------- Feature #11599: Dump entries of hash in ObjectSpace https://bugs.ruby-lang.org/issues/11599#change-54480 * Author: Yosi Attias * Status: Open * Priority: Normal * Assignee: ---------------------------------------- Hi, *This is my first c code contribution :)* I am helping developing heap-analyzer (github.com/tenderlove/heap-analyzer), and currently the dumps lacks of "type metadata" information, like: * Hash entries - the keys and value * Array items - the items of the array etc. In the included patch, I have changed the dump of hash to add entries of hash. For example, given the next hash: ~~~ruby hash = { int_key: 1, str_key: "This is my string", inner_hash: { b: 2 } } ~~~ The dump result (ObjectSpace.dump(hash)) will be: ~~~json { "address": "0x007fbc01110340", "type": "HASH", "class": "0x007fbc0109b400", "size": 3, "entries": [ { "is_key_address": false, "key": ":int_key", "is_value_address": false, "value": "1" }, { "is_key_address": false, "key": ":str_key", "is_value_address": true, "value": "0x007fbc01110390" }, { "is_key_address": false, "key": ":inner_hash", "is_value_address": true, "value": "0x007fbc01110368" } ], "references": [ "0x007fbc01110390", "0x007fbc01110368" ], "memsize": 232, "flags": { "wb_protected": true } } ~~~ As you can see, I have the "entries" array, where each entry contains: "is_key_address", "is_value_address" - if the key/value are special consts the inspected value will be printed in the "key"/"value" properties, other their address will be print. Hope you will accept the patch (and I can submit another one for arrays), Yosi. ---Files-------------------------------- objspace_dump_hash_entries.patch (4.8 KB) -- https://bugs.ruby-lang.org/