From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id 93CE519C002A for ; Sun, 18 Oct 2015 21:58:14 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id 293E1B5D864 for ; Sun, 18 Oct 2015 22:24:52 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id 0FD6F95241E for ; Sun, 18 Oct 2015 22:24:51 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 60A3A120461; Sun, 18 Oct 2015 22:24:50 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o2.heroku.sendgrid.net (o2.heroku.sendgrid.net [67.228.50.55]) by neon.ruby-lang.org (Postfix) with ESMTPS id 43D68120421 for ; Sun, 18 Oct 2015 22:24:45 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=cOc7y87Dv3KKZrXXifaeWzPExkM=; b=vh4LDuArL2Tt9n0Ani DAxfdJRuKlQW2N91sRp9Fp1ow++ZL+XpgzYDk8o2EGL1wpwp2bE4dQTRrXvUBEra vEAOYOMmcEVGQvaZUBkVz8s2kWj2icTCIWeb2TRniidAtwU28Kx0T7e5Lo8jVWHt mQL0gUbvVj9th2dck0pHDYLdM= Received: by filter0593p1mdw1.sendgrid.net with SMTP id filter0593p1mdw1.6611.56239D9A36 2015-10-18 13:24:42.770006505 +0000 UTC Received: from herokuapp.com (ec2-54-81-127-82.compute-1.amazonaws.com [54.81.127.82]) by ismtpd0001p1iad1.sendgrid.net (SG) with ESMTP id Rc6uMhvETBOUc9QTB8pp7w Sun, 18 Oct 2015 13:24:42.704 +0000 (UTC) Date: Sun, 18 Oct 2015 13:24:42 +0000 From: nobu@ruby-lang.org To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Redmine-MailingListIntegration-Message-Ids: 45727 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 11599 X-Redmine-Issue-Author: yosiat X-Redmine-Sender: nobu X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS5y7CxqrPRyh18s6KyyvV7gNQU2/WnS+DLd0k 3mMBfxYtHTk+ovky6ecj9ocaZ1OoKjKx16jEEkW514+FKfTG7w9qptvylP60Xo2QqBQ9Us78LFJXYH GRuah5s4fnRn3NQQwz3Uj1drKxZiu1Gpi7vJ X-ML-Name: ruby-core X-Mail-Count: 71103 Subject: [ruby-core:71103] [Ruby trunk - Feature #11599] Dump entries of hash in ObjectSpace X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #11599 has been updated by Nobuyoshi Nakada. Description updated Are `is_{key,value}_address` necessary? ---------------------------------------- Feature #11599: Dump entries of hash in ObjectSpace https://bugs.ruby-lang.org/issues/11599#change-54473 * Author: Yosi Attias * Status: Open * Priority: Normal * Assignee: ---------------------------------------- Hi, *This is my first c code contribution :)* I am helping developing heap-analyzer (github.com/tenderlove/heap-analyzer), and currently the dumps lacks of "type metadata" information, like: * Hash entries - the keys and value * Array items - the items of the array etc. In the included patch, I have changed the dump of hash to add entries of hash. For example, given the next hash: ~~~ruby hash = { int_key: 1, str_key: "This is my string", inner_hash: { b: 2 } } ~~~ The dump result (ObjectSpace.dump(hash)) will be: ~~~json { "address": "0x007fbc01110340", "type": "HASH", "class": "0x007fbc0109b400", "size": 3, "entries": [ { "is_key_address": false, "key": ":int_key", "is_value_address": false, "value": "1" }, { "is_key_address": false, "key": ":str_key", "is_value_address": true, "value": "0x007fbc01110390" }, { "is_key_address": false, "key": ":inner_hash", "is_value_address": true, "value": "0x007fbc01110368" } ], "references": [ "0x007fbc01110390", "0x007fbc01110368" ], "memsize": 232, "flags": { "wb_protected": true } } ~~~ As you can see, I have the "entries" array, where each entry contains: "is_key_address", "is_value_address" - if the key/value are special consts the inspected value will be printed in the "key"/"value" properties, other their address will be print. Hope you will accept the patch (and I can submit another one for arrays), Yosi. ---Files-------------------------------- objspace_dump_hash_entries.patch (4.8 KB) -- https://bugs.ruby-lang.org/