[ruby-core:70930] [Ruby trunk - Bug #11556] [Open] [PERF] app_strconcat

[ruby-core:70930] [Ruby trunk - Bug #11556] [Open] [PERF] app_strconcat

[tgx_world]

Issue #11556 has been reported by Guo Xiang Tan.

----------------------------------------
Bug #11556: [PERF] app_strconcat
https://bugs.ruby-lang.org/issues/11556

* Author: Guo Xiang Tan
* Status: Open
* Priority: Normal
* Assignee: 
* ruby -v: ruby 2.3.0dev (2015-09-10 trunk 51820) [x86_64-linux]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
total: 2 trial(s) (2 trial(s) for 1 benchmark(s))
..
-----------------------------------------------------------
benchmark results:
Execution time (sec)
name  ruby 2.3.0dev (2015-09-10 trunk 51818) [x86_64-linux]
app_strconcat 0.923

total: 2 trial(s) (2 trial(s) for 1 benchmark(s))
..
-----------------------------------------------------------
benchmark results:
Execution time (sec)
name  ruby 2.3.0dev (2015-09-10 trunk 51820) [x86_64-linux]
app_strconcat 1.045

View full graph at http://rubybench.org/ruby/ruby/commits?result_type=app_strconcat

Let me know if more information is needed :) Thanks!



-- 
https://bugs.ruby-lang.org/

[ruby-core:70942] [Ruby trunk - Bug #11556] [PERF] app_strconcat

[nobu]

Issue #11556 has been updated by Nobuyoshi Nakada.


Thank you.

BTW, when will a new benchmark appear there?

----------------------------------------
Bug #11556: [PERF] app_strconcat
https://bugs.ruby-lang.org/issues/11556#change-54304

* Author: Guo Xiang Tan
* Status: Closed
* Priority: Normal
* Assignee: 
* ruby -v: ruby 2.3.0dev (2015-09-10 trunk 51820) [x86_64-linux]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
total: 2 trial(s) (2 trial(s) for 1 benchmark(s))
..
-----------------------------------------------------------
benchmark results:
Execution time (sec)
name  ruby 2.3.0dev (2015-09-10 trunk 51818) [x86_64-linux]
app_strconcat 0.923

total: 2 trial(s) (2 trial(s) for 1 benchmark(s))
..
-----------------------------------------------------------
benchmark results:
Execution time (sec)
name  ruby 2.3.0dev (2015-09-10 trunk 51820) [x86_64-linux]
app_strconcat 1.045

View full graph at http://rubybench.org/ruby/ruby/commits?result_type=app_strconcat

Let me know if more information is needed :) Thanks!



-- 
https://bugs.ruby-lang.org/

[ruby-core:70948] [Ruby trunk - Bug #11556] [PERF] app_strconcat

[tgx_world]

Issue #11556 has been updated by Guo Xiang Tan.


Hi Nobu!

Currently the new commits will appear whenever I rebase my fork of the Ruby repo. Do you know who I can reach out to in order to insert a Github hook into the Ruby repro?

Thanks for fixing the issue!

----------------------------------------
Bug #11556: [PERF] app_strconcat
https://bugs.ruby-lang.org/issues/11556#change-54312

* Author: Guo Xiang Tan
* Status: Closed
* Priority: Normal
* Assignee: 
* ruby -v: ruby 2.3.0dev (2015-09-10 trunk 51820) [x86_64-linux]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
total: 2 trial(s) (2 trial(s) for 1 benchmark(s))
..
-----------------------------------------------------------
benchmark results:
Execution time (sec)
name  ruby 2.3.0dev (2015-09-10 trunk 51818) [x86_64-linux]
app_strconcat 0.923

total: 2 trial(s) (2 trial(s) for 1 benchmark(s))
..
-----------------------------------------------------------
benchmark results:
Execution time (sec)
name  ruby 2.3.0dev (2015-09-10 trunk 51820) [x86_64-linux]
app_strconcat 1.045

View full graph at http://rubybench.org/ruby/ruby/commits?result_type=app_strconcat

Let me know if more information is needed :) Thanks!



-- 
https://bugs.ruby-lang.org/

[ruby-core:70949] [Ruby trunk - Bug #11556] [PERF] app_strconcat

[nobu]

Issue #11556 has been updated by Nobuyoshi Nakada.


Guo Xiang Tan wrote:
> Currently the new commits will appear whenever I rebase my fork of the Ruby repo. Do you know who I can reach out to in order to insert a Github hook into the Ruby repro?

@hsbt could manage it, I think.

> Thanks for fixing the issue!

It seems worse than before on your system, while it was better on my system...



----------------------------------------
Bug #11556: [PERF] app_strconcat
https://bugs.ruby-lang.org/issues/11556#change-54313

* Author: Guo Xiang Tan
* Status: Closed
* Priority: Normal
* Assignee: 
* ruby -v: ruby 2.3.0dev (2015-09-10 trunk 51820) [x86_64-linux]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
total: 2 trial(s) (2 trial(s) for 1 benchmark(s))
..
-----------------------------------------------------------
benchmark results:
Execution time (sec)
name  ruby 2.3.0dev (2015-09-10 trunk 51818) [x86_64-linux]
app_strconcat 0.923

total: 2 trial(s) (2 trial(s) for 1 benchmark(s))
..
-----------------------------------------------------------
benchmark results:
Execution time (sec)
name  ruby 2.3.0dev (2015-09-10 trunk 51820) [x86_64-linux]
app_strconcat 1.045

View full graph at http://rubybench.org/ruby/ruby/commits?result_type=app_strconcat

Let me know if more information is needed :) Thanks!



-- 
https://bugs.ruby-lang.org/

[ruby-core:70950] [Ruby trunk - Bug #11556] [PERF] app_strconcat

[nobu]

Issue #11556 has been updated by Nobuyoshi Nakada.


Guo Xiang Tan wrote:
> Currently the new commits will appear whenever I rebase my fork of the Ruby repo. Do you know who I can reach out to in order to insert a Github hook into the Ruby repro?

I meant http://rubybench.org/ruby/ruby/commits?result_type=vm_symbol_block_pass was missing.
New benchmark files are added manually?

----------------------------------------
Bug #11556: [PERF] app_strconcat
https://bugs.ruby-lang.org/issues/11556#change-54314

* Author: Guo Xiang Tan
* Status: Closed
* Priority: Normal
* Assignee: 
* ruby -v: ruby 2.3.0dev (2015-09-10 trunk 51820) [x86_64-linux]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
total: 2 trial(s) (2 trial(s) for 1 benchmark(s))
..
-----------------------------------------------------------
benchmark results:
Execution time (sec)
name  ruby 2.3.0dev (2015-09-10 trunk 51818) [x86_64-linux]
app_strconcat 0.923

total: 2 trial(s) (2 trial(s) for 1 benchmark(s))
..
-----------------------------------------------------------
benchmark results:
Execution time (sec)
name  ruby 2.3.0dev (2015-09-10 trunk 51820) [x86_64-linux]
app_strconcat 1.045

View full graph at http://rubybench.org/ruby/ruby/commits?result_type=app_strconcat

Let me know if more information is needed :) Thanks!



-- 
https://bugs.ruby-lang.org/

[ruby-core:70951] [Ruby trunk - Bug #11556] [PERF] app_strconcat

[tgx_world]

Issue #11556 has been updated by Guo Xiang Tan.


Ah yes I have to add it in manually to https://github.com/ruby-bench/ruby-bench-suite.

Also, I'm seeing a regression on this issue. Let me know if you need more information :) 


Ran locally.
total: 2 trial(s) (2 trial(s) for 1 benchmark(s))
..
-----------------------------------------------------------
benchmark results:
Execution time (sec)
name	ruby 2.3.0dev (2015-09-29 trunk 51970) [x86_64-linux]
app_strconcat	1.065


----------------------------------------
Bug #11556: [PERF] app_strconcat
https://bugs.ruby-lang.org/issues/11556#change-54315

* Author: Guo Xiang Tan
* Status: Closed
* Priority: Normal
* Assignee: 
* ruby -v: ruby 2.3.0dev (2015-09-10 trunk 51820) [x86_64-linux]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
total: 2 trial(s) (2 trial(s) for 1 benchmark(s))
..
-----------------------------------------------------------
benchmark results:
Execution time (sec)
name  ruby 2.3.0dev (2015-09-10 trunk 51818) [x86_64-linux]
app_strconcat 0.923

total: 2 trial(s) (2 trial(s) for 1 benchmark(s))
..
-----------------------------------------------------------
benchmark results:
Execution time (sec)
name  ruby 2.3.0dev (2015-09-10 trunk 51820) [x86_64-linux]
app_strconcat 1.045

View full graph at http://rubybench.org/ruby/ruby/commits?result_type=app_strconcat

Let me know if more information is needed :) Thanks!



-- 
https://bugs.ruby-lang.org/

[ruby-core:70952] [Ruby trunk - Bug #11556] [PERF] app_strconcat

[tgx_world]

Issue #11556 has been updated by Guo Xiang Tan.


> It seems worse than before on your system, while it was better on my system...

Ah I missed this. Hmm is there more information I can provide to help you?

----------------------------------------
Bug #11556: [PERF] app_strconcat
https://bugs.ruby-lang.org/issues/11556#change-54316

* Author: Guo Xiang Tan
* Status: Closed
* Priority: Normal
* Assignee: 
* ruby -v: ruby 2.3.0dev (2015-09-10 trunk 51820) [x86_64-linux]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
total: 2 trial(s) (2 trial(s) for 1 benchmark(s))
..
-----------------------------------------------------------
benchmark results:
Execution time (sec)
name  ruby 2.3.0dev (2015-09-10 trunk 51818) [x86_64-linux]
app_strconcat 0.923

total: 2 trial(s) (2 trial(s) for 1 benchmark(s))
..
-----------------------------------------------------------
benchmark results:
Execution time (sec)
name  ruby 2.3.0dev (2015-09-10 trunk 51820) [x86_64-linux]
app_strconcat 1.045

View full graph at http://rubybench.org/ruby/ruby/commits?result_type=app_strconcat

Let me know if more information is needed :) Thanks!



-- 
https://bugs.ruby-lang.org/

[ruby-core:70958] [Ruby trunk - Bug #11556] [PERF] app_strconcat

[tgx_world]

Issue #11556 has been updated by Guo Xiang Tan.


@nobu could we reopen this?

I compiled locally instead of Docker and got the following results.


-----------------------------------------------------------
benchmark results:
Execution time (sec)
name	ruby 2.3.0dev (2015-09-29 test_branch 51970) [x86_64-linux]
app_strconcat	                                                      0.995

Log file: bmlog-20151001-144505.11698.tsv

-----------------------------------------------------------
benchmark results:
Execution time (sec)
name	ruby 2.3.0dev (2015-09-10 test_branch 51820) [x86_64-linux]
app_strconcat	                                                      0.999

Log file: bmlog-20151001-144523.11780.tsv

-----------------------------------------------------------
benchmark results:
Execution time (sec)
name	ruby 2.3.0dev (2015-09-10 test_branch 51818) [x86_64-linux]
app_strconcat	                                                      0.901

Log file: bmlog-20151001-144534.11846.tsv


----------------------------------------
Bug #11556: [PERF] app_strconcat
https://bugs.ruby-lang.org/issues/11556#change-54329

* Author: Guo Xiang Tan
* Status: Closed
* Priority: Normal
* Assignee: 
* ruby -v: ruby 2.3.0dev (2015-09-10 trunk 51820) [x86_64-linux]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
total: 2 trial(s) (2 trial(s) for 1 benchmark(s))
..
-----------------------------------------------------------
benchmark results:
Execution time (sec)
name  ruby 2.3.0dev (2015-09-10 trunk 51818) [x86_64-linux]
app_strconcat 0.923

total: 2 trial(s) (2 trial(s) for 1 benchmark(s))
..
-----------------------------------------------------------
benchmark results:
Execution time (sec)
name  ruby 2.3.0dev (2015-09-10 trunk 51820) [x86_64-linux]
app_strconcat 1.045

View full graph at http://rubybench.org/ruby/ruby/commits?result_type=app_strconcat

Let me know if more information is needed :) Thanks!



-- 
https://bugs.ruby-lang.org/

[ruby-core:70959] [Ruby trunk - Bug #11556] [Open] [PERF] app_strconcat

[nobu]

Issue #11556 has been updated by Nobuyoshi Nakada.

Status changed from Closed to Open

----------------------------------------
Bug #11556: [PERF] app_strconcat
https://bugs.ruby-lang.org/issues/11556#change-54330

* Author: Guo Xiang Tan
* Status: Open
* Priority: Normal
* Assignee: 
* ruby -v: ruby 2.3.0dev (2015-09-10 trunk 51820) [x86_64-linux]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
total: 2 trial(s) (2 trial(s) for 1 benchmark(s))
..
-----------------------------------------------------------
benchmark results:
Execution time (sec)
name  ruby 2.3.0dev (2015-09-10 trunk 51818) [x86_64-linux]
app_strconcat 0.923

total: 2 trial(s) (2 trial(s) for 1 benchmark(s))
..
-----------------------------------------------------------
benchmark results:
Execution time (sec)
name  ruby 2.3.0dev (2015-09-10 trunk 51820) [x86_64-linux]
app_strconcat 1.045

View full graph at http://rubybench.org/ruby/ruby/commits?result_type=app_strconcat

Let me know if more information is needed :) Thanks!



-- 
https://bugs.ruby-lang.org/

[ruby-core:71034] [Ruby trunk - Bug #11556] [PERF] app_strconcat

[tgx_world]

Issue #11556 has been updated by Guo Xiang Tan.


benchmark results:
Execution time (sec)

name         |ruby 2.3.0dev (2015-10-09 trunk 52095) [x86_64-linux]|ruby 2.3.0dev (2015-09-10 test_branch 51820) [x86_64-linux]|ruby 2.3.0dev (2015-09-10 test_branch 51818) [x86_64-linux]
-------------|----------------------------------------------------:|----------------------------------------------------------:|----------------------------------------------------------:
app_strconcat|                                                0.952|                                                      1.031|                                                      0.926

@nobu Am I right to say you fixed this? I'm seeing the performance return to the previous level. :)

----------------------------------------
Bug #11556: [PERF] app_strconcat
https://bugs.ruby-lang.org/issues/11556#change-54408

* Author: Guo Xiang Tan
* Status: Open
* Priority: Normal
* Assignee: 
* ruby -v: ruby 2.3.0dev (2015-09-10 trunk 51820) [x86_64-linux]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
total: 2 trial(s) (2 trial(s) for 1 benchmark(s))
..
-----------------------------------------------------------
benchmark results:
Execution time (sec)
name  ruby 2.3.0dev (2015-09-10 trunk 51818) [x86_64-linux]
app_strconcat 0.923

total: 2 trial(s) (2 trial(s) for 1 benchmark(s))
..
-----------------------------------------------------------
benchmark results:
Execution time (sec)
name  ruby 2.3.0dev (2015-09-10 trunk 51820) [x86_64-linux]
app_strconcat 1.045

View full graph at http://rubybench.org/ruby/ruby/commits?result_type=app_strconcat

Let me know if more information is needed :) Thanks!



-- 
https://bugs.ruby-lang.org/