[ruby-core:70608] [Ruby trunk - Bug #11492] [Open] TracePoint API report extra return for defined method

[ruby-core:70608] [Ruby trunk - Bug #11492] [Open] TracePoint API report extra return for defined method

[os97673]

Issue #11492 has been reported by Oleg Sukhodolsky.

----------------------------------------
Bug #11492: TracePoint API report extra return for defined method
https://bugs.ruby-lang.org/issues/11492

* Author: Oleg Sukhodolsky
* Status: Open
* Priority: Normal
* Assignee: Koichi Sasada
* ruby -v: ruby 2.2.3p173 (2015-08-18 revision 51636) [x86_64-darwin14]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
~~~ruby
class A
  define_method "method1" do
    # puts "#{method_name}(#{arg})"
    return 1
  end
end

a = A.new

TracePoint.new do |tp|
  printf "%8s %13s %s:%-2d\n", tp.event, tp.method_id, tp.path, tp.lineno
end.enable do
  a.method1
end
~~~



-- 
https://bugs.ruby-lang.org/

[ruby-core:70609] [Ruby trunk - Bug #11492] TracePoint API report extra return for defined method

[os97673]

Issue #11492 has been updated by Oleg Sukhodolsky.


MRI 2.2.3 introduced problem with TracePoint events.
For the provided test it reports extra return event for method1

~~~
  b_call               ruby-17051.rb:14
    line               ruby-17051.rb:15
    call       method1 ruby-17051.rb:2 
  b_call       method1 ruby-17051.rb:2 
    line       method1 ruby-17051.rb:4 
b_return       method1 ruby-17051.rb:4 
  return       method1 ruby-17051.rb:4 
  return       method1 ruby-17051.rb:15
b_return               ruby-17051.rb:16
~~~

while 2.2.2 reports

~~~
  b_call               ruby-17051.rb:14
    line               ruby-17051.rb:15
    call       method1 ruby-17051.rb:2 
  b_call       method1 ruby-17051.rb:2 
    line       method1 ruby-17051.rb:4 
b_return       method1 ruby-17051.rb:4 
  return       method1 ruby-17051.rb:15
b_return               ruby-17051.rb:16
~~~

This breaks calculation of frame stack's size which is used in debase and byebug

----------------------------------------
Bug #11492: TracePoint API report extra return for defined method
https://bugs.ruby-lang.org/issues/11492#change-54015

* Author: Oleg Sukhodolsky
* Status: Open
* Priority: Normal
* Assignee: Koichi Sasada
* ruby -v: ruby 2.2.3p173 (2015-08-18 revision 51636) [x86_64-darwin14]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
~~~ruby
class A
  define_method "method1" do
    # puts "#{method_name}(#{arg})"
    return 1
  end
end

a = A.new

TracePoint.new do |tp|
  printf "%8s %13s %s:%-2d\n", tp.event, tp.method_id, tp.path, tp.lineno
end.enable do
  a.method1
end
~~~



-- 
https://bugs.ruby-lang.org/

[ruby-core:70614] [Ruby trunk - Bug #11492] [Assigned] TracePoint API report extra return for defined method

[nagachika00]

Issue #11492 has been updated by Tomoyuki Chikanaga.

Status changed from Open to Assigned
Backport changed from 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN to 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: REQUIRED

----------------------------------------
Bug #11492: TracePoint API report extra return for defined method
https://bugs.ruby-lang.org/issues/11492#change-54020

* Author: Oleg Sukhodolsky
* Status: Assigned
* Priority: Normal
* Assignee: Koichi Sasada
* ruby -v: ruby 2.2.3p173 (2015-08-18 revision 51636) [x86_64-darwin14]
* Backport: 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: REQUIRED
----------------------------------------
~~~ruby
class A
  define_method "method1" do
    # puts "#{method_name}(#{arg})"
    return 1
  end
end

a = A.new

TracePoint.new do |tp|
  printf "%8s %13s %s:%-2d\n", tp.event, tp.method_id, tp.path, tp.lineno
end.enable do
  a.method1
end
~~~



-- 
https://bugs.ruby-lang.org/

[ruby-core:70624] [Ruby trunk - Bug #11492] TracePoint API report extra return for defined method

[deivid.rodriguez]

Issue #11492 has been updated by David Rodríguez.


Oleg, could you link to the original report where you found this out? I'd like to know what kind of bug reports to expect and maybe add a regression test in byebug itself.

----------------------------------------
Bug #11492: TracePoint API report extra return for defined method
https://bugs.ruby-lang.org/issues/11492#change-54030

* Author: Oleg Sukhodolsky
* Status: Closed
* Priority: Normal
* Assignee: Koichi Sasada
* ruby -v: ruby 2.2.3p173 (2015-08-18 revision 51636) [x86_64-darwin14]
* Backport: 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: REQUIRED
----------------------------------------
~~~ruby
class A
  define_method "method1" do
    # puts "#{method_name}(#{arg})"
    return 1
  end
end

a = A.new

TracePoint.new do |tp|
  printf "%8s %13s %s:%-2d\n", tp.event, tp.method_id, tp.path, tp.lineno
end.enable do
  a.method1
end
~~~



-- 
https://bugs.ruby-lang.org/

[ruby-core:70625] [Ruby trunk - Bug #11492] TracePoint API report extra return for defined method

[os97673]

Issue #11492 has been updated by Oleg Sukhodolsky.


David Rodríguez wrote:
> Oleg, could you link to the original report where you found this out? I'd like to know what kind of bug reports to expect and maybe add a regression test in byebug itself.

originally the problem has reported here (https://youtrack.jetbrains.com/issue/RUBY-17051) unfortunately user was unable to provide test and I've investigated the problem using log of event reported by debase

----------------------------------------
Bug #11492: TracePoint API report extra return for defined method
https://bugs.ruby-lang.org/issues/11492#change-54031

* Author: Oleg Sukhodolsky
* Status: Closed
* Priority: Normal
* Assignee: Koichi Sasada
* ruby -v: ruby 2.2.3p173 (2015-08-18 revision 51636) [x86_64-darwin14]
* Backport: 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: REQUIRED
----------------------------------------
~~~ruby
class A
  define_method "method1" do
    # puts "#{method_name}(#{arg})"
    return 1
  end
end

a = A.new

TracePoint.new do |tp|
  printf "%8s %13s %s:%-2d\n", tp.event, tp.method_id, tp.path, tp.lineno
end.enable do
  a.method1
end
~~~



-- 
https://bugs.ruby-lang.org/

[ruby-core:70628] [Ruby trunk - Bug #11492] TracePoint API report extra return for defined method

[deivid.rodriguez]

Issue #11492 has been updated by David Rodríguez.


Thanks!

----------------------------------------
Bug #11492: TracePoint API report extra return for defined method
https://bugs.ruby-lang.org/issues/11492#change-54033

* Author: Oleg Sukhodolsky
* Status: Closed
* Priority: Normal
* Assignee: Koichi Sasada
* ruby -v: ruby 2.2.3p173 (2015-08-18 revision 51636) [x86_64-darwin14]
* Backport: 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: REQUIRED
----------------------------------------
~~~ruby
class A
  define_method "method1" do
    # puts "#{method_name}(#{arg})"
    return 1
  end
end

a = A.new

TracePoint.new do |tp|
  printf "%8s %13s %s:%-2d\n", tp.event, tp.method_id, tp.path, tp.lineno
end.enable do
  a.method1
end
~~~



-- 
https://bugs.ruby-lang.org/

[ruby-core:70629] [Ruby trunk - Bug #11492] TracePoint API report extra return for defined method

[os97673]

Issue #11492 has been updated by Oleg Sukhodolsky.


Reporter of original bug confirmed that ruby-head does fix the problem.

----------------------------------------
Bug #11492: TracePoint API report extra return for defined method
https://bugs.ruby-lang.org/issues/11492#change-54034

* Author: Oleg Sukhodolsky
* Status: Closed
* Priority: Normal
* Assignee: Koichi Sasada
* ruby -v: ruby 2.2.3p173 (2015-08-18 revision 51636) [x86_64-darwin14]
* Backport: 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: REQUIRED
----------------------------------------
~~~ruby
class A
  define_method "method1" do
    # puts "#{method_name}(#{arg})"
    return 1
  end
end

a = A.new

TracePoint.new do |tp|
  printf "%8s %13s %s:%-2d\n", tp.event, tp.method_id, tp.path, tp.lineno
end.enable do
  a.method1
end
~~~



-- 
https://bugs.ruby-lang.org/

[ruby-core:71225] [Ruby trunk - Bug #11492] TracePoint API report extra return for defined method

[nagachika00]

Issue #11492 has been updated by Tomoyuki Chikanaga.

Backport changed from 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: REQUIRED to 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: DONE

Backported into `ruby_2_2` branch at r52308.

----------------------------------------
Bug #11492: TracePoint API report extra return for defined method
https://bugs.ruby-lang.org/issues/11492#change-54605

* Author: Oleg Sukhodolsky
* Status: Closed
* Priority: Normal
* Assignee: Koichi Sasada
* ruby -v: ruby 2.2.3p173 (2015-08-18 revision 51636) [x86_64-darwin14]
* Backport: 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: DONE
----------------------------------------
~~~ruby
class A
  define_method "method1" do
    # puts "#{method_name}(#{arg})"
    return 1
  end
end

a = A.new

TracePoint.new do |tp|
  printf "%8s %13s %s:%-2d\n", tp.event, tp.method_id, tp.path, tp.lineno
end.enable do
  a.method1
end
~~~



-- 
https://bugs.ruby-lang.org/

[ruby-core:71259] [Ruby trunk - Bug #11492] TracePoint API report extra return for defined method

[deivid.rodriguez]

Issue #11492 has been updated by David Rodríguez.


Hi, this is indeed a regression in 2.2.3, but also a bug present in 2.1.7. Could we get it backported to 2.1 as well? Thanks!

----------------------------------------
Bug #11492: TracePoint API report extra return for defined method
https://bugs.ruby-lang.org/issues/11492#change-54632

* Author: Oleg Sukhodolsky
* Status: Closed
* Priority: Normal
* Assignee: Koichi Sasada
* ruby -v: ruby 2.2.3p173 (2015-08-18 revision 51636) [x86_64-darwin14]
* Backport: 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: DONE
----------------------------------------
~~~ruby
class A
  define_method "method1" do
    # puts "#{method_name}(#{arg})"
    return 1
  end
end

a = A.new

TracePoint.new do |tp|
  printf "%8s %13s %s:%-2d\n", tp.event, tp.method_id, tp.path, tp.lineno
end.enable do
  a.method1
end
~~~



-- 
https://bugs.ruby-lang.org/

[ruby-core:71303] [Ruby trunk - Bug #11492] TracePoint API report extra return for defined method

[usa]

Issue #11492 has been updated by Usaku NAKAMURA.

Backport changed from 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: DONE to 2.0.0: DONTNEED, 2.1: REQUIRED, 2.2: DONE

----------------------------------------
Bug #11492: TracePoint API report extra return for defined method
https://bugs.ruby-lang.org/issues/11492#change-54676

* Author: Oleg Sukhodolsky
* Status: Closed
* Priority: Normal
* Assignee: Koichi Sasada
* ruby -v: ruby 2.2.3p173 (2015-08-18 revision 51636) [x86_64-darwin14]
* Backport: 2.0.0: DONTNEED, 2.1: REQUIRED, 2.2: DONE
----------------------------------------
~~~ruby
class A
  define_method "method1" do
    # puts "#{method_name}(#{arg})"
    return 1
  end
end

a = A.new

TracePoint.new do |tp|
  printf "%8s %13s %s:%-2d\n", tp.event, tp.method_id, tp.path, tp.lineno
end.enable do
  a.method1
end
~~~



-- 
https://bugs.ruby-lang.org/

[ruby-core:71547] [Ruby trunk - Bug #11492] TracePoint API report extra return for defined method

[usa]

Issue #11492 has been updated by Usaku NAKAMURA.

Backport changed from 2.0.0: DONTNEED, 2.1: REQUIRED, 2.2: DONE to 2.0.0: DONTNEED, 2.1: DONE, 2.2: DONE

ruby_2_1 r52639 merged revision(s) 51713.

----------------------------------------
Bug #11492: TracePoint API report extra return for defined method
https://bugs.ruby-lang.org/issues/11492#change-54923

* Author: Oleg Sukhodolsky
* Status: Closed
* Priority: Normal
* Assignee: Koichi Sasada
* ruby -v: ruby 2.2.3p173 (2015-08-18 revision 51636) [x86_64-darwin14]
* Backport: 2.0.0: DONTNEED, 2.1: DONE, 2.2: DONE
----------------------------------------
~~~ruby
class A
  define_method "method1" do
    # puts "#{method_name}(#{arg})"
    return 1
  end
end

a = A.new

TracePoint.new do |tp|
  printf "%8s %13s %s:%-2d\n", tp.event, tp.method_id, tp.path, tp.lineno
end.enable do
  a.method1
end
~~~



-- 
https://bugs.ruby-lang.org/