From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id AC7AC1980866 for ; Mon, 17 Aug 2015 17:07:50 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [133.44.2.201]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id 884A7B5D8C8 for ; Mon, 17 Aug 2015 17:43:30 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (localhost.nagaokaut.ac.jp [127.0.0.1]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id 9FC3797A826 for ; Mon, 17 Aug 2015 17:43:32 +0900 (JST) X-Virus-Scanned: amavisd-new at nagaokaut.ac.jp Authentication-Results: funfun.nagaokaut.ac.jp (amavisd-new); dkim=fail (1024-bit key) reason="fail (message has been altered)" header.d=sendgrid.me Received: from funfun.nagaokaut.ac.jp ([127.0.0.1]) by funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tz48XBPC9rNH for ; Mon, 17 Aug 2015 17:43:32 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id 6433897A820 for ; Mon, 17 Aug 2015 17:43:32 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id 1BBD795241E for ; Mon, 17 Aug 2015 17:43:29 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 44BF112046C; Mon, 17 Aug 2015 17:43:28 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o2.heroku.sendgrid.net (o2.heroku.sendgrid.net [67.228.50.55]) by neon.ruby-lang.org (Postfix) with ESMTPS id 853B3120476 for ; Mon, 17 Aug 2015 17:43:21 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=YzU0RQm4PZf5Hh68XpB5bro/aGY=; b=xdUtDK/Su8rB0iw8zG jqyYVLd1kIfmc6NXaGcjkER8s+E3Q/y8a/t6xoZY9UblYXMAiy9r3rdnEijx4K1N sjMS1SW8lVnUfGBzp+cWHv4wP4EA7tD24ZFWl89q+Kd9evSbb6VEk9EpVyzK+EPF 7qMFGRuojlcZcgm0V8KMWYbyk= Received: by filter0542p1mdw1.sendgrid.net with SMTP id filter0542p1mdw1.24155.55D19EA65 2015-08-17 08:43:18.181110167 +0000 UTC Received: from herokuapp.com (ec2-54-158-69-236.compute-1.amazonaws.com [54.158.69.236]) by ismtpd0003p1iad1.sendgrid.net (SG) with ESMTP id YgCZ4XffRduWrdwc09F4aw for ; Mon, 17 Aug 2015 08:43:18 +0000 (UTC) Date: Mon, 17 Aug 2015 08:43:18 +0000 From: usa@garbagecollect.jp To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Redmine-MailingListIntegration-Message-Ids: 45025 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 11260 X-Redmine-Issue-Author: Eregon X-Redmine-Issue-Assignee: Eregon X-Redmine-Sender: usa X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS7M7mAykOkkhxHEG7/xEc4YPDc++fxJD7rEKI Cv1O/2OBOkrOttValb+wpw7j+FJGk3sCIZzJJLAGCojRLCIxLEK3BHHCa/7cVkX5h82VA7YqtiE2G9 7ZFRk0Ab8wRVWX5e9vTM7E7nGRY83h8+xvRP X-ML-Name: ruby-core X-Mail-Count: 70417 Subject: [ruby-core:70417] [Ruby trunk - Bug #11260] [PATCH] Net::FTP keeps a TCPServer opened when sending the data port fails X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #11260 has been updated by Usaku NAKAMURA. Backport changed from 2.0.0: WONTFIX, 2.1: REQUIRED, 2.2: DONE to 2.0.0: WONTFIX, 2.1: DONE, 2.2: DONE ruby_2_1 r51610 merged revision(s) 51046. ---------------------------------------- Bug #11260: [PATCH] Net::FTP keeps a TCPServer opened when sending the data port fails https://bugs.ruby-lang.org/issues/11260#change-53825 * Author: Benoit Daloze * Status: Closed * Priority: Normal * Assignee: Benoit Daloze * ruby -v: ruby 2.2.2p95 (2015-04-13 revision 50295) [x86_64-linux] * Backport: 2.0.0: WONTFIX, 2.1: DONE, 2.2: DONE ---------------------------------------- `Net::FTP` will keep the `TCPServer` created in `makeport` opened if `sendport` fails. The patch sends the port in its (only) caller instead, so the TCPServer is appropriately closed no matter the outcome. This was detected with RubySpec and a leak checker based on test/lib/leakchecker.rb. ---Files-------------------------------- 0001-lib-net-ftp.rb-makeport-close-the-TCPServer.patch (3.43 KB) -- https://bugs.ruby-lang.org/