From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id 629A219807DC for ; Mon, 17 Aug 2015 16:14:37 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [133.44.2.201]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id CF4E8B5DA17 for ; Mon, 17 Aug 2015 16:50:16 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (localhost.nagaokaut.ac.jp [127.0.0.1]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id CAA4D97A85B for ; Mon, 17 Aug 2015 16:50:18 +0900 (JST) X-Virus-Scanned: amavisd-new at nagaokaut.ac.jp Authentication-Results: funfun.nagaokaut.ac.jp (amavisd-new); dkim=fail (1024-bit key) reason="fail (message has been altered)" header.d=sendgrid.me Received: from funfun.nagaokaut.ac.jp ([127.0.0.1]) by funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BUYuB8Yy-sMT for ; Mon, 17 Aug 2015 16:50:18 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id 8EFF597A859 for ; Mon, 17 Aug 2015 16:50:18 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id 81F85952448 for ; Mon, 17 Aug 2015 16:50:16 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 790D112045C; Mon, 17 Aug 2015 16:50:15 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o10.shared.sendgrid.net (o10.shared.sendgrid.net [173.193.132.135]) by neon.ruby-lang.org (Postfix) with ESMTPS id B2BB0120446 for ; Mon, 17 Aug 2015 16:50:10 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=vDWHwGP4+0oWis5mpBHR18K6zlo=; b=OFIIjGZE3O9sOaw83U pcbt7gAlwOGpWT/cdEP2L3PfuLkPHoiWdkN4C9dBEUJsqc2BYxnrCXmsSZ6PfDX7 VV5N+34zrp+WIKDwLNBXovvnJ0IxAb5yLHTloeNF4CD3WW/p07HvG4pisFCBJEsX CWilRig8paPDTM1LjZ2XsDnj4= Received: by filter0606p1mdw1.sendgrid.net with SMTP id filter0606p1mdw1.736.55D1922F3 2015-08-17 07:50:07.214139435 +0000 UTC Received: from herokuapp.com (ec2-54-81-40-69.compute-1.amazonaws.com [54.81.40.69]) by ismtpd0001p1iad1.sendgrid.net (SG) with ESMTP id ZiZdym5SSLyfwt8wDYqT2A for ; Mon, 17 Aug 2015 07:50:07 +0000 (UTC) Date: Mon, 17 Aug 2015 07:50:07 +0000 From: usa@garbagecollect.jp To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Redmine-MailingListIntegration-Message-Ids: 45016 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 11285 X-Redmine-Issue-Author: littlechu X-Redmine-Sender: usa X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS7QB3ulhxXbGCAGdbAeAPjtbljYVuUnF4B4Qa iP85RGEfm+UqX+o/s7E1wy9vW7S2EQ40ojujIz19Dr5AlOSM3YsRQseSt+YZjYfAAm0zIppH7AtWdS 1ELX0fGUSHunZo8= X-ML-Name: ruby-core X-Mail-Count: 70410 Subject: [ruby-core:70410] [Ruby trunk - Bug #11285] Net::HTTP should handle content-coding with case-insensitive X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #11285 has been updated by Usaku NAKAMURA. Backport changed from 2.0.0: REQUIRED, 2.1: REQUIRED, 2.2: DONE to 2.0.0: REQUIRED, 2.1: DONE, 2.2: DONE ruby_2_1 r51602 merged revision(s) 51061,51063,51091. ---------------------------------------- Bug #11285: Net::HTTP should handle content-coding with case-insensitive https://bugs.ruby-lang.org/issues/11285#change-53816 * Author: Andy Chu * Status: Closed * Priority: Normal * Assignee: * ruby -v: * Backport: 2.0.0: REQUIRED, 2.1: DONE, 2.2: DONE ---------------------------------------- When Ruby Net::HTTP sent a request. It by default set the content to be compress with header: Accept-Encoding But if server return with content-encoding = GZIP (or any case other then all lower case) it will not tread the body as compressed. According to HTTP 1.1 spec, Content-Encoding should be value used by content-coding, and the value of content-coding should be case-insensitive content-coding: http://www.w3.org/Protocols/rfc2616/rfc2616-sec3.html#sec3.5 I think simply change the code here: https://github.com/ruby/ruby/blob/trunk/lib/net/http/response.rb#L253 from case self['content-encoding'] to case self['content-encoding'].downcase should work -- https://bugs.ruby-lang.org/