From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id 05117198023F for ; Thu, 13 Aug 2015 01:06:04 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (smtp.nagaokaut.ac.jp [133.44.2.201]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id 7C36CB5D8B7 for ; Thu, 13 Aug 2015 01:40:44 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (localhost.nagaokaut.ac.jp [127.0.0.1]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id A249B97A820 for ; Thu, 13 Aug 2015 01:40:45 +0900 (JST) X-Virus-Scanned: amavisd-new at nagaokaut.ac.jp Authentication-Results: funfun.nagaokaut.ac.jp (amavisd-new); dkim=fail (1024-bit key) reason="fail (message has been altered)" header.d=sendgrid.me Received: from funfun.nagaokaut.ac.jp ([127.0.0.1]) by funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Apm1e1jPO-IA for ; Thu, 13 Aug 2015 01:40:45 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id 6230D97A82B for ; Thu, 13 Aug 2015 01:40:45 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id 51C9895241E for ; Thu, 13 Aug 2015 01:40:42 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 25631120489; Thu, 13 Aug 2015 01:40:43 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o2.heroku.sendgrid.net (o2.heroku.sendgrid.net [67.228.50.55]) by neon.ruby-lang.org (Postfix) with ESMTPS id 8F29E120492 for ; Thu, 13 Aug 2015 01:40:37 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=Oe3Uaujqzom6WvMVY+5sRuAYNHk=; b=ufBVDOFl8erMQu79pu JXd88Ofcq2vuEn/3TRJmcXEv6U2G4L1V9W+19lxsb3PmN4BzwS8HP/9TlQavG/Rr 7XlpTwT5Ak1kg20qZYQBE0chBzZlYzTGMJ04uCkpf6H+TVHDFBOmB2ek0o3b+K5B 9DdljrL9QiI/g1a7rIhdObEow= Received: by filter0646p1mdw1.sendgrid.net with SMTP id filter0646p1mdw1.10514.55CB77017 2015-08-12 16:40:33.218667093 +0000 UTC Received: from herokuapp.com (ec2-54-158-109-139.compute-1.amazonaws.com [54.158.109.139]) by ismtpd0001p1iad1.sendgrid.net (SG) with ESMTP id ruap_Ok0TAC9l3-Q4bt3ug for ; Wed, 12 Aug 2015 16:40:33 +0000 (UTC) Date: Wed, 12 Aug 2015 16:40:33 +0000 From: nagachika00@gmail.com To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Redmine-MailingListIntegration-Message-Ids: 44962 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 11260 X-Redmine-Issue-Author: Eregon X-Redmine-Issue-Assignee: Eregon X-Redmine-Sender: nagachika X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS5BSwYjgy0S16X83wdwIvmHOPDi4hJEVfWyuZ YZ9ljz4msjhuCWqJIfOku63IUPPYDgSzJqRtK2YVa2em0B7VfpjKZQvRxj/ZK1GjJm+LgZjTGYcPmu vRQzma/VyR+1uXHfqmJuZWmWP9OsJ2l/nDw2 X-ML-Name: ruby-core X-Mail-Count: 70354 Subject: [ruby-core:70354] [Ruby trunk - Bug #11260] [PATCH] Net::FTP keeps a TCPServer opened when sending the data port fails X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #11260 has been updated by Tomoyuki Chikanaga. Backport changed from 2.0.0: WONTFIX, 2.1: REQUIRED, 2.2: REQUIRED to 2.0.0: WONTFIX, 2.1: REQUIRED, 2.2: DONE Backported into `ruby_2_2` branch at r51556. ---------------------------------------- Bug #11260: [PATCH] Net::FTP keeps a TCPServer opened when sending the data port fails https://bugs.ruby-lang.org/issues/11260#change-53770 * Author: Benoit Daloze * Status: Closed * Priority: Normal * Assignee: Benoit Daloze * ruby -v: ruby 2.2.2p95 (2015-04-13 revision 50295) [x86_64-linux] * Backport: 2.0.0: WONTFIX, 2.1: REQUIRED, 2.2: DONE ---------------------------------------- `Net::FTP` will keep the `TCPServer` created in `makeport` opened if `sendport` fails. The patch sends the port in its (only) caller instead, so the TCPServer is appropriately closed no matter the outcome. This was detected with RubySpec and a leak checker based on test/lib/leakchecker.rb. ---Files-------------------------------- 0001-lib-net-ftp.rb-makeport-close-the-TCPServer.patch (3.43 KB) -- https://bugs.ruby-lang.org/