From: mame@ruby-lang.org
To: ruby-core@ruby-lang.org
Subject: [ruby-core:70028] [Ruby trunk - Bug #11363] Fix tests for String#crypt
Date: Sat, 18 Jul 2015 12:01:29 +0000 [thread overview]
Message-ID: <redmine.journal-53453.20150718120128.0450fa4b612db476@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-11363.20150717213108@ruby-lang.org
Issue #11363 has been updated by Yusuke Endoh.
Do the tests cause any actual issue? Failed on OpenBSD?
Ruby's tests are not conformance test. They should include a test of implementation-defined behavior and it is actually useful to detect an unintentional change of behavior.
--
Yusuke Endoh <mame@ruby-lang.org>
----------------------------------------
Bug #11363: Fix tests for String#crypt
https://bugs.ruby-lang.org/issues/11363#change-53453
* Author: Jeremy Evans
* Status: Open
* Priority: Normal
* Assignee:
* ruby -v: ruby 2.3.0dev (2015-07-16 openbsd 51261) [x86_64-openbsd]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
The String#crypt documentation states "the format and the result
are system and implementation dependent", so the tests should not
be checking for specific results. We should only be checking that
the method returns a string, that the results are different
if you use a different password or different salt, and the results
are the same if the using the encypted password as the salt
results in the same encrypted password.
---Files--------------------------------
0001-Fix-tests-for-String-crypt.patch (2.02 KB)
--
https://bugs.ruby-lang.org/
next prev parent reply other threads:[~2015-07-18 11:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <redmine.issue-11363.20150717213108@ruby-lang.org>
2015-07-17 21:31 ` [ruby-core:70015] [Ruby trunk - Bug #11363] [Open] Fix tests for String#crypt merch-redmine
2015-07-18 12:01 ` mame [this message]
2015-07-18 15:33 ` [ruby-core:70031] [Ruby trunk - Bug #11363] " merch-redmine
2019-05-24 3:28 ` [ruby-core:92811] [Ruby trunk Bug#11363] Fix tests for String#crypt so they pass on OpenBSD merch-redmine
2019-05-25 22:45 ` [ruby-core:92844] " merch-redmine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-53453.20150718120128.0450fa4b612db476@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).