From: nobu@ruby-lang.org
To: ruby-core@ruby-lang.org
Subject: [ruby-core:69855] [Ruby trunk - Bug #11326] Defining a writer as a Struct member allowed?
Date: Fri, 03 Jul 2015 09:25:43 +0000 [thread overview]
Message-ID: <redmine.journal-53256.20150703092542.7dfc01da82fdfb66@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-11326.20150703073852@ruby-lang.org
Issue #11326 has been updated by Nobuyoshi Nakada.
Description updated
Eric Wong wrote:
> I suggest banning it (barely-tested patch):
+1
----------------------------------------
Bug #11326: Defining a writer as a Struct member allowed?
https://bugs.ruby-lang.org/issues/11326#change-53256
* Author: Peter Suschlik
* Status: Open
* Priority: Normal
* Assignee:
* ruby -v: 2.2
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
Hi,
yesterday I've stumbled on weird behavior defining writers as Struct members.
While this code works on MRI it breaks on JRuby and Rubinius:
```ruby
Struct.new(:x=).new(nil).x = 23
```
On JRuby it fails with:
```
ArgumentError: wrong number of arguments calling `x=` (1 for 0)
from (irb):1:in `evaluate'
from org/jruby/RubyKernel.java:1111:in `eval'
from org/jruby/RubyKernel.java:1511:in `loop'
from org/jruby/RubyKernel.java:1274:in `catch'
from org/jruby/RubyKernel.java:1274:in `catch'
from /home/ps/.rvm/rubies/jruby-1.7.20/bin/irb:13:in `(root)'
```
On Rubinius it gives:
```
ArgumentError: given 1, expected 0
from (irb):1
from kernel/common/block_environment.rb:53:in `call_on_instance'
from kernel/common/eval.rb:176:in `eval'
from kernel/common/kernel.rb:510:in `loop'
from kernel/bootstrap/proc.rb:20:in `call'
from kernel/common/throw_catch.rb:30:in `catch'
from kernel/common/throw_catch.rb:8:in `register'
from kernel/common/throw_catch.rb:29:in `catch'
from kernel/bootstrap/proc.rb:20:in `call'
from kernel/common/throw_catch.rb:30:in `catch'
from kernel/common/throw_catch.rb:8:in `register'
from kernel/common/throw_catch.rb:29:in `catch'
from /home/ps/.rvm/gems/rbx-2.5.2@global/gems/rubysl-irb-2.1.1/bin/irb:12:in `__script__'
from kernel/common/kernel.rb:497:in `load'
from /home/ps/.rvm/gems/rbx-2.5.2@global/bin/irb:23:in `__script__'
from kernel/delta/code_loader.rb:66:in `load_script'
from kernel/delta/code_loader.rb:152:in `load_script'
from kernel/loader.rb:655:in `script'
from kernel/loader.rb:809:in `main'
```
I've reported this as a bug to the JRuby team at https://github.com/jruby/jruby/issues/3097
Charles rejected it and said:
> I think I'm going to call this a bug in MRI and ask you to re-file it with them. I believe the `:x=` should be kicked out as an invalid attribute name rather than defined as a write-only attribute. I believe the latter behavior is happening only accidentally because of how MRI detects that you're defining an `=` method.
So here I am.
I don't have a strong opinion whether defining a writer member should be possible or not.
It would be nice to have one single behavior across the 3 major Ruby implementations :)
What do you think?
Kind regards,
Peter
--
https://bugs.ruby-lang.org/
next prev parent reply other threads:[~2015-07-03 8:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <redmine.issue-11326.20150703073852@ruby-lang.org>
2015-07-03 7:38 ` [ruby-core:69849] [Ruby trunk - Bug #11326] [Open] Defining a writer as a Struct member allowed? peter-rl
2015-07-03 8:21 ` [ruby-core:69850] " Eric Wong
2015-07-03 9:25 ` nobu [this message]
2015-07-04 4:38 ` [ruby-core:69869] Re: [Ruby trunk - Bug #11326] " Eric Wong
2019-07-05 17:10 ` [ruby-core:93563] [Ruby master Bug#11326] " merch-redmine
2019-08-29 4:32 ` [ruby-core:94641] " matz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-53256.20150703092542.7dfc01da82fdfb66@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).