From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id 7F4A917D7AAB for ; Tue, 30 Jun 2015 11:46:15 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [133.44.2.201]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id 1267EB5D87A for ; Tue, 30 Jun 2015 12:11:31 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (localhost.nagaokaut.ac.jp [127.0.0.1]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id 66AAB97A826 for ; Tue, 30 Jun 2015 12:11:32 +0900 (JST) X-Virus-Scanned: amavisd-new at nagaokaut.ac.jp Authentication-Results: funfun.nagaokaut.ac.jp (amavisd-new); dkim=fail (1024-bit key) reason="fail (message has been altered)" header.d=sendgrid.me Received: from funfun.nagaokaut.ac.jp ([127.0.0.1]) by funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jRYXtjk0o_dJ for ; Tue, 30 Jun 2015 12:11:32 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id 21E1397A820 for ; Tue, 30 Jun 2015 12:11:32 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id BDFDA952446 for ; Tue, 30 Jun 2015 12:11:30 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 931F6120481; Tue, 30 Jun 2015 12:11:29 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o2.heroku.sendgrid.net (o2.heroku.sendgrid.net [67.228.50.55]) by neon.ruby-lang.org (Postfix) with ESMTPS id 6D5AF12045E for ; Tue, 30 Jun 2015 12:11:26 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=DD6X6CFSQNwAxLZqkYsRmcowIB0=; b=pwOsK6Q/fz2QCQoKA+ nM5FO+JS7LBHRSSbfKDCiiCJ1+AzBKCfRrGWXI9IzLsA8taKNou1PcobnQxEL4+K p/wDPa8dA5SoSVS1bHGNL+S3FtDMXnA01b7lXTNPHZL3cxqE0JewyH3ZqLHLKcDU KgW3/tlHKkVPuH8KC6FqqCImc= Received: by filter0443p1mdw1.sendgrid.net with SMTP id filter0443p1mdw1.7093.559208D95 2015-06-30 03:11:22.250160916 +0000 UTC Received: from herokuapp.com (ec2-54-159-222-128.compute-1.amazonaws.com [54.159.222.128]) by ismtpd-028 (SG) with ESMTP id 14e427294c2.1d3.7247cd for ; Tue, 30 Jun 2015 03:11:22 +0000 (UTC) Date: Tue, 30 Jun 2015 03:11:22 +0000 From: usa@garbagecollect.jp To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Redmine-MailingListIntegration-Message-Ids: 44368 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 11260 X-Redmine-Issue-Author: Eregon X-Redmine-Issue-Assignee: Eregon X-Redmine-Sender: usa X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS7TYUsMF/d7bgj4sAQmhMWYxmJd2/7SRCS9oH nGMyyubouUaXDA5GtupK2d6WdcR90feQvLcO/ezNn3JjvS6T5pwTiz9V/LV0/Cdxf3F9SFufxx1djT qtCRCw/BNPGOwtw= X-ML-Name: ruby-core X-Mail-Count: 69786 Subject: [ruby-core:69786] [Ruby trunk - Bug #11260] [PATCH] Net::FTP keeps a TCPServer opened when sending the data port fails X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #11260 has been updated by Usaku NAKAMURA. Backport changed from 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN to 2.0.0: WONTFIX, 2.1: REQUIRED, 2.2: REQUIRED ---------------------------------------- Bug #11260: [PATCH] Net::FTP keeps a TCPServer opened when sending the data port fails https://bugs.ruby-lang.org/issues/11260#change-53164 * Author: Benoit Daloze * Status: Closed * Priority: Normal * Assignee: Benoit Daloze * ruby -v: ruby 2.2.2p95 (2015-04-13 revision 50295) [x86_64-linux] * Backport: 2.0.0: WONTFIX, 2.1: REQUIRED, 2.2: REQUIRED ---------------------------------------- `Net::FTP` will keep the `TCPServer` created in `makeport` opened if `sendport` fails. The patch sends the port in its (only) caller instead, so the TCPServer is appropriately closed no matter the outcome. This was detected with RubySpec and a leak checker based on test/lib/leakchecker.rb. ---Files-------------------------------- 0001-lib-net-ftp.rb-makeport-close-the-TCPServer.patch (3.43 KB) -- https://bugs.ruby-lang.org/