From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id 1055D1960041 for ; Sat, 27 Jun 2015 18:49:15 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [133.44.2.201]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id EFD7CB5D9F9 for ; Sat, 27 Jun 2015 19:13:54 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (localhost.nagaokaut.ac.jp [127.0.0.1]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id 37DAC97A82C for ; Sat, 27 Jun 2015 19:13:57 +0900 (JST) X-Virus-Scanned: amavisd-new at nagaokaut.ac.jp Authentication-Results: funfun.nagaokaut.ac.jp (amavisd-new); dkim=fail (1024-bit key) reason="fail (message has been altered)" header.d=sendgrid.me Received: from funfun.nagaokaut.ac.jp ([127.0.0.1]) by funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0ymDoksa9d7N for ; Sat, 27 Jun 2015 19:13:57 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id E775D97A82B for ; Sat, 27 Jun 2015 19:13:56 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id 7484495243A for ; Sat, 27 Jun 2015 19:13:53 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 5D8B712044C; Sat, 27 Jun 2015 19:13:52 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o10.shared.sendgrid.net (o10.shared.sendgrid.net [173.193.132.135]) by neon.ruby-lang.org (Postfix) with ESMTPS id 3D1FF120400 for ; Sat, 27 Jun 2015 19:13:48 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=eSwAhzzNX+wIbD7Iic0N+QY+ULc=; b=G2ppJ6o0CDkxqKmQQq dLnFi7NBi663yRmV6soQWJOxlHPU5zd3S3KhONyk2CZKHfDWDbv9wCEU8DUpsy4S nmSy5CVKaf5TIsE46jYAlJ0UAZPRrfVoD7GHWcVxH4EWlaJ8Gl6Zm589q31c/C93 reZO39BxHbajO1ZSgBx/xfeBQ= Received: by filter0476p1mdw1.sendgrid.net with SMTP id filter0476p1mdw1.1160.558E775610 2015-06-27 10:13:42.921707263 +0000 UTC Received: from ismtpd-002.iad1.sendgrid.net ([UNAVAILABLE]. [10.42.2.102]) by 10.42.243.103:2500 (trex/5.2.14); Sat, 27 Jun 2015 10:13:44 GMT Received: from herokuapp.com (ec2-54-159-95-116.compute-1.amazonaws.com [54.159.95.116]) by ismtpd-002 (SG) with ESMTP id 14e34822ad4.6c5b.42273d for ; Sat, 27 Jun 2015 10:13:42 +0000 (UTC) Date: Sat, 27 Jun 2015 10:13:39 +0000 From: eregontp@gmail.com To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Redmine-MailingListIntegration-Message-Ids: 44331 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 11260 X-Redmine-Issue-Author: Eregon X-Redmine-Issue-Assignee: Eregon X-Redmine-Sender: Eregon X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS6y9oRTUQd8VitjePa6mL0aAfWV9tQTMC8LoR /DUJEuTOU8e5Gv5z7d56bPlaHivhkPF/+FG1cXWWV2z5DCfoQwc7O11VfABktCxSdJMEO/miqdjODR nAKOtmYJcB+bYk7a8sPyfWGPZ3ip/rMOoPPF X-ML-Name: ruby-core X-Mail-Count: 69755 Subject: [ruby-core:69755] [Ruby trunk - Bug #11260] [Closed] [PATCH] Net::FTP keeps a TCPServer opened when sending the data port fails X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #11260 has been updated by Benoit Daloze. Status changed from Assigned to Closed Thanks, committed in r51046. ---------------------------------------- Bug #11260: [PATCH] Net::FTP keeps a TCPServer opened when sending the data port fails https://bugs.ruby-lang.org/issues/11260#change-53132 * Author: Benoit Daloze * Status: Closed * Priority: Normal * Assignee: Benoit Daloze * ruby -v: ruby 2.2.2p95 (2015-04-13 revision 50295) [x86_64-linux] * Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN ---------------------------------------- `Net::FTP` will keep the `TCPServer` created in `makeport` opened if `sendport` fails. The patch sends the port in its (only) caller instead, so the TCPServer is appropriately closed no matter the outcome. This was detected with RubySpec and a leak checker based on test/lib/leakchecker.rb. ---Files-------------------------------- 0001-lib-net-ftp.rb-makeport-close-the-TCPServer.patch (3.43 KB) -- https://bugs.ruby-lang.org/