From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id 8C2F41960041 for ; Sat, 27 Jun 2015 17:40:23 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [133.44.2.201]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id EAEBBB5D8A9 for ; Sat, 27 Jun 2015 18:05:02 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (localhost.nagaokaut.ac.jp [127.0.0.1]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id 0EFA297A826 for ; Sat, 27 Jun 2015 18:05:05 +0900 (JST) X-Virus-Scanned: amavisd-new at nagaokaut.ac.jp Authentication-Results: funfun.nagaokaut.ac.jp (amavisd-new); dkim=fail (1024-bit key) reason="fail (message has been altered)" header.d=sendgrid.me Received: from funfun.nagaokaut.ac.jp ([127.0.0.1]) by funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gNXILp8HS_L7 for ; Sat, 27 Jun 2015 18:05:04 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id 9091297A820 for ; Sat, 27 Jun 2015 18:05:04 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id 04F5895243A for ; Sat, 27 Jun 2015 18:05:01 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id B1971120456; Sat, 27 Jun 2015 18:05:00 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o10.shared.sendgrid.net (o10.shared.sendgrid.net [173.193.132.135]) by neon.ruby-lang.org (Postfix) with ESMTPS id 28ACA1203F8 for ; Sat, 27 Jun 2015 18:04:56 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=Q5DtWX9as4nu1T3PAmyVPvy+8Tg=; b=ybmRn5FrkbTZ75bo1M OUq4TMOWn+UVWEZ7LsgIMDAxvmpvUIQLLc79/OH/lT8fwjVhAMarRBigoB7kAR9A 6MQ0GHSfa8/VxoPBm7Gqn/e2/pA7w9IxNnvwU6VjzJqmoFBjO9wLw9qgMs01ampA XN7BGC/OIPr1nok5yTFYYtB64= Received: by filter0422p1mdw1.sendgrid.net with SMTP id filter0422p1mdw1.3666.558E6732A 2015-06-27 09:04:50.851219541 +0000 UTC Received: from herokuapp.com (ec2-54-196-142-3.compute-1.amazonaws.com [54.196.142.3]) by ismtpd-015 (SG) with ESMTP id 14e34431eb4.7b6b.60d159 for ; Sat, 27 Jun 2015 09:04:50 +0000 (UTC) Date: Sat, 27 Jun 2015 09:04:50 +0000 From: shugo@ruby-lang.org To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Redmine-MailingListIntegration-Message-Ids: 44329 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 11260 X-Redmine-Issue-Author: Eregon X-Redmine-Issue-Assignee: Eregon X-Redmine-Sender: shugo X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS4HYwWXH/yxY0R2nra8pEvLsJVClt6ELHNXYe lqOFiIsXtVoX9Wwa7Oz+hXKSOb/g7xo1Ot7p4wLWTV64hI235JWTRry+j4edHjKx5vt6XKgZHhyvGY St/6NXlrb+Q39K+/++gHIssfYp1KzIwBni8e X-ML-Name: ruby-core X-Mail-Count: 69753 Subject: [ruby-core:69753] [Ruby trunk - Bug #11260] [Assigned] [PATCH] Net::FTP keeps a TCPServer opened when sending the data port fails X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #11260 has been updated by Shugo Maeda. Status changed from Open to Assigned Assignee changed from Shugo Maeda to Benoit Daloze Benoit Daloze wrote: > @shugo, can I commit this? The patch looks fine. Please commit it. ---------------------------------------- Bug #11260: [PATCH] Net::FTP keeps a TCPServer opened when sending the data port fails https://bugs.ruby-lang.org/issues/11260#change-53130 * Author: Benoit Daloze * Status: Assigned * Priority: Normal * Assignee: Benoit Daloze * ruby -v: ruby 2.2.2p95 (2015-04-13 revision 50295) [x86_64-linux] * Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN ---------------------------------------- `Net::FTP` will keep the `TCPServer` created in `makeport` opened if `sendport` fails. The patch sends the port in its (only) caller instead, so the TCPServer is appropriately closed no matter the outcome. This was detected with RubySpec and a leak checker based on test/lib/leakchecker.rb. ---Files-------------------------------- 0001-lib-net-ftp.rb-makeport-close-the-TCPServer.patch (3.43 KB) -- https://bugs.ruby-lang.org/