From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id D349F196000C for ; Sat, 20 Jun 2015 06:52:13 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (smtp.nagaokaut.ac.jp [133.44.2.201]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id A5C33B5D8BA for ; Sat, 20 Jun 2015 07:15:17 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (localhost.nagaokaut.ac.jp [127.0.0.1]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id 5F7F597A82C for ; Sat, 20 Jun 2015 07:15:18 +0900 (JST) X-Virus-Scanned: amavisd-new at nagaokaut.ac.jp Authentication-Results: funfun.nagaokaut.ac.jp (amavisd-new); dkim=fail (1024-bit key) reason="fail (message has been altered)" header.d=sendgrid.me Received: from funfun.nagaokaut.ac.jp ([127.0.0.1]) by funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id t8K4xEsY2EgY for ; Sat, 20 Jun 2015 07:15:18 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id 23ABD97A82B for ; Sat, 20 Jun 2015 07:15:18 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id 4B7D695243A for ; Sat, 20 Jun 2015 07:15:17 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id BEB07120484; Sat, 20 Jun 2015 07:15:14 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o2.heroku.sendgrid.net (o2.heroku.sendgrid.net [67.228.50.55]) by neon.ruby-lang.org (Postfix) with ESMTPS id 3052A12046C for ; Sat, 20 Jun 2015 07:14:23 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=axS9fRWax//jK4JPpWxehItrSMA=; b=H8UzsADHrTKCHyJeW1 JRrPVskz5DVzSkkGwZ4iVoyU+r7TsZ9Tow0iqg95XfrogLJevo0vRxer0ZV0MpXP I+Ev7KEVfISs/g1/JOB3iFli+B5qzAgz3kAAHcDzd9d/xmnp3R5PAz0vh37PjmS7 X32la2wO9en8D0sFhgji1KQnU= Received: by filter0635p1mdw1.sendgrid.net with SMTP id filter0635p1mdw1.6553.5584943716 2015-06-19 22:14:15.820213466 +0000 UTC Received: from herokuapp.com (ec2-54-90-247-40.compute-1.amazonaws.com [54.90.247.40]) by ismtpd-047 (SG) with ESMTP id 14e0de2f9bb.1633.39c7c8 for ; Fri, 19 Jun 2015 22:14:15 +0000 (UTC) Date: Fri, 19 Jun 2015 22:14:15 +0000 From: 0x0dea+redmine@gmail.com To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Redmine-MailingListIntegration-Message-Ids: 44246 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 11286 X-Redmine-Issue-Author: 0x0dea X-Redmine-Issue-Assignee: matz X-Redmine-Sender: 0x0dea X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS4IyiZVxknxgNrFv0a3/x0No4oTuWbXyVH+mR qjLv0zmin1JArYBG8B/6V/wtkWegpGCxLJpQZj2S7d4xxqLNmc7nbijtiJhm/MtYrRgW4hkMlcMlLc 6HbyRON0hUpoWeiO9qfz/+mSyVztDPq8+qlx X-ML-Name: ruby-core X-Mail-Count: 69687 Subject: [ruby-core:69687] [Ruby trunk - Feature #11286] [PATCH] Add case equality arity to Enumerable's sequence predicates. X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #11286 has been updated by D.E. Akers. File case_equality_sequence_predicates-check_argc_before_deref.patch added Nobuyoshi Nakada wrote: > > ~~~diff > > + struct MEMO *memo = MEMO_NEW(Qtrue, *argv, 0); > > + rb_check_arity(argc, 0, 1); > > Why dereference `argv` before checking `argc`. I assumed `*argv` would resolve to `Qnil` in the case of no arguments, but this is indeed not the case. I have attached a modified patch which takes this into account. ---------------------------------------- Feature #11286: [PATCH] Add case equality arity to Enumerable's sequence predicates. https://bugs.ruby-lang.org/issues/11286#change-53062 * Author: D.E. Akers * Status: Open * Priority: Normal * Assignee: Yukihiro Matsumoto ---------------------------------------- ## Proposal It is proposed that `Enumerable`'s sequence predicates (`#all?`, `#any?`, `#none?`, and `#one?`) be augmented to return, in the case of a single argument, whether their query holds when each element is supplied to the argument's `#===` method. ## Rationale `Enumerable#grep` filters by case equality, allowing us to write very natural and expressive code: ```ruby strs.select { |str| /foo/ === str } strs.grep(/foo/) nums.select { |num| (5..10) === num } nums.grep(5..10) ``` In addition to taking advantage of the versatility of case equality, it lets us do away with the syntactic noise incurred by opening a block. `#grep` is a very nice method! Let's make `#all?` and friends more like `#grep`. ---Files-------------------------------- 0001-enum.c-add-case-equality-arity-to-sequence-predicates.patch (10 KB) case_equality_sequence_predicates-check_argc_before_deref.patch (10 KB) -- https://bugs.ruby-lang.org/