From: nagachika00@gmail.com
To: ruby-core@ruby-lang.org
Subject: [ruby-core:69526] [Ruby trunk - Bug #11185] [PATCH] openssl: use RB_GC_GUARD instead of volatile
Date: Thu, 11 Jun 2015 16:38:47 +0000 [thread overview]
Message-ID: <redmine.journal-52841.20150611163844.e1626c2d61a67615@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-11185.20150527005031@ruby-lang.org
Issue #11185 has been updated by Tomoyuki Chikanaga.
Backport changed from 2.0.0: REQUIRED, 2.1: DONE, 2.2: REQUIRED to 2.0.0: REQUIRED, 2.1: DONE, 2.2: DONE
Backported into `ruby_2_2` branch at r50837.
----------------------------------------
Bug #11185: [PATCH] openssl: use RB_GC_GUARD instead of volatile
https://bugs.ruby-lang.org/issues/11185#change-52841
* Author: Eric Wong
* Status: Closed
* Priority: Normal
* Assignee: Eric Wong
* ruby -v:
* Backport: 2.0.0: REQUIRED, 2.1: DONE, 2.2: DONE
----------------------------------------
From doc/extension.rdoc:
>
> Using the RB_GC_GUARD macro is preferable to using the "volatile"
> keyword in C. RB_GC_GUARD has the following advantages:
>
> 1) the intent of the macro use is clear
>
> 2) RB_GC_GUARD only affects its call site, "volatile" generates some
> extra code every time the variable is used, hurting optimization.
>
> 3) "volatile" implementations may be buggy/inconsistent in some
> compilers and architectures. RB_GC_GUARD is customizable for broken
> systems/compilers without those without negatively affecting other
> systems.
---Files--------------------------------
0001-openssl-use-RB_GC_GUARD-instead-of-volatile.patch (2.5 KB)
--
https://bugs.ruby-lang.org/
prev parent reply other threads:[~2015-06-11 16:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <redmine.issue-11185.20150527005031@ruby-lang.org>
2015-05-27 0:50 ` [ruby-core:69371] [Ruby trunk - Bug #11185] [Open] [PATCH] openssl: use RB_GC_GUARD instead of volatile normalperson
2015-06-09 7:29 ` [ruby-core:69498] [Ruby trunk - Bug #11185] " usa
2015-06-11 16:38 ` nagachika00 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-52841.20150611163844.e1626c2d61a67615@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).