From: hanmac@gmx.de
To: ruby-core@ruby-lang.org
Subject: [ruby-core:69428] [Ruby trunk - Bug #11201] pkg_config NoMethodError when finding other -config program
Date: Mon, 01 Jun 2015 12:44:55 +0000 [thread overview]
Message-ID: <redmine.journal-52700.20150601124454.feee06951b3c9a16@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-11201.20150601064810@ruby-lang.org
Issue #11201 has been updated by Hans Mackowiak.
Priority changed from Normal to Low
i try to modify your possible patch a bit,
now it can parse the libs from the libflags again.
makes it work with wx-config and freetype-config
~~~diff
diff --git a/lib/mkmf.rb b/lib/mkmf.rb
index 0f588a5..7e8b22d 100644
--- a/lib/mkmf.rb
+++ b/lib/mkmf.rb
@@ -1816,11 +1816,18 @@ SRC
cflags = get['cflags']
end
libs = get['libs-only-l']
- ldflags = (Shellwords.shellwords(ldflags) - Shellwords.shellwords(libs)).quote.join(" ")
- $CFLAGS += " " << cflags
- $CXXFLAGS += " " << cflags
- $LDFLAGS = [orig_ldflags, ldflags].join(' ')
+ if cflags
+ $CFLAGS += " " << cflags
+ $CXXFLAGS += " " << cflags
+ end
+ if libs
+ ldflags = (Shellwords.shellwords(ldflags) - Shellwords.shellwords(libs)).quote.join(" ")
+ else
+ libs, ldflags = Shellwords.shellwords(ldflags).partition {|s| s =~ /-l([^ ]+)/ }.map {|l| l.quote.join(" ") }
+ end
$libs += " " << libs
+
+ $LDFLAGS = [orig_ldflags, ldflags].join(' ')
Logging::message "package configuration for %s\n", pkg
Logging::message "cflags: %s\nldflags: %s\nlibs: %s\n\n",
cflags, ldflags, libs
~~~
sdl2-config and xml2-config makes problems with "cflags-only-I" and "libs-only-l" because they do not return error so $?.success? does think the data is ok
----------------------------------------
Bug #11201: pkg_config NoMethodError when finding other -config program
https://bugs.ruby-lang.org/issues/11201#change-52700
* Author: Hans Mackowiak
* Status: Feedback
* Priority: Low
* Assignee:
* ruby -v: ruby 2.3.0dev (2015-05-28 trunk 50658) [x86_64-linux]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
where it does work (existing package)
~~~ruby
pkg_config("gtk+-x11-2.0") # => ["-pthread", "", "-lgtk-x11-2.0 -lgdk-x11-2.0 -lpangocairo-1.0 -latk-1.0 -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lpangoft2-1.0 -lpango-1.0 -lgobject-2.0 -lglib-2.0 -lfontconfig -lfreetype"]
pkg_config("gtk+-x11-2.0", "version") # => "0.28"
~~~
where it does work (non-existing package)
~~~ruby
pkg_config("wx-bla", "version") # => nil
pkg_config("wx-bla") # => nil
~~~
where it maybe not work (other (pkg)-config program)
~~~ruby
pkg_config("wx", "version") # => "3.1.0"
pkg_config("wx") #either should try to return the same stuff as pkg_config("gtk+-x11-2.0") if possible, or if not return nil
~~~
~~~
NoMethodError: undefined method `scan' for nil:NilClass
from /usr/local/rvm/rubies/ruby-head/lib/ruby/2.3.0/shellwords.rb:73:in `shellsplit'
from /usr/local/rvm/rubies/ruby-head/lib/ruby/2.3.0/mkmf.rb:1819:in `pkg_config'
from (irb):11
from /usr/local/rvm/rubies/ruby-head/bin/irb:11:in `<main>'
~~~
--
https://bugs.ruby-lang.org/
next prev parent reply other threads:[~2015-06-01 12:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <redmine.issue-11201.20150601064810@ruby-lang.org>
2015-06-01 6:48 ` [ruby-core:69421] [Ruby trunk - Bug #11201] [Open] pkg_config NoMethodError when finding other -config program hanmac
2015-06-01 8:51 ` [ruby-core:69422] [Ruby trunk - Bug #11201] [Feedback] " nobu
2015-06-01 9:00 ` [ruby-core:69423] [Ruby trunk - Bug #11201] " hanmac
2015-06-01 9:46 ` [ruby-core:69424] " nobu
2015-06-01 12:44 ` hanmac [this message]
2015-06-30 4:12 ` [ruby-core:69802] " usa
2015-07-03 9:45 ` [ruby-core:69857] " usa
2015-07-03 20:14 ` [ruby-core:69867] " nagachika00
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-52700.20150601124454.feee06951b3c9a16@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).