From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id 6D3C817DE500 for ; Tue, 12 May 2015 09:10:09 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [133.44.2.201]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id 86E09B5D8F9 for ; Tue, 12 May 2015 09:25:16 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (localhost.nagaokaut.ac.jp [127.0.0.1]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id 8606397A82B for ; Tue, 12 May 2015 09:25:17 +0900 (JST) X-Virus-Scanned: amavisd-new at nagaokaut.ac.jp Authentication-Results: funfun.nagaokaut.ac.jp (amavisd-new); dkim=fail (1024-bit key) reason="fail (message has been altered)" header.d=sendgrid.me Received: from funfun.nagaokaut.ac.jp ([127.0.0.1]) by funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9R8n9-zpgms2 for ; Tue, 12 May 2015 09:25:17 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id 4A46497A832 for ; Tue, 12 May 2015 09:25:17 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id 288CC95243A for ; Tue, 12 May 2015 09:25:15 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id A001612045A; Tue, 12 May 2015 09:25:15 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o10.shared.sendgrid.net (o10.shared.sendgrid.net [173.193.132.135]) by neon.ruby-lang.org (Postfix) with ESMTPS id F20B012044A for ; Tue, 12 May 2015 09:25:11 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=hBiI+nkDJAb8nf9y+xJSXpsO5Kw=; b=m91QqjxBeSzyr95qr+ nB/cmIE3k+d62mghRPhFDBAu/MBU/6L3GyQOL/adJZexovEbErITlQEznWDdayew foJOjWpDAk1MpumwQWknd7a7N0LkBXJdTH4EgfClANn3ICNJ5+/GIFkc6azu9J+e vMb9F4TGyageOWW4BGNgeS7xk= Received: by filter0264p1mdw1.sendgrid.net with SMTP id filter0264p1mdw1.14655.555148605 2015-05-12 00:25:08.694820382 +0000 UTC Received: from herokuapp.com (ec2-54-147-185-57.compute-1.amazonaws.com [54.147.185.57]) by ismtpd-002 (SG) with ESMTP id 14d4582c91f.4d65.f825f for ; Tue, 12 May 2015 00:25:08 +0000 (UTC) Date: Tue, 12 May 2015 00:25:08 +0000 From: djberg96@gmail.com To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Redmine-MailingListIntegration-Message-Ids: 43549 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 11139 X-Redmine-Issue-Author: normalperson X-Redmine-Issue-Assignee: akr X-Redmine-Sender: djberg96 X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS6ZxvNtl41erBv9B9uubNxS1jOyRPS1dFo7Vh D1ki9/gGXc2oe2h/eZtLM8+i3nq3nC9CHcioRLxZ/uMf0JvUnqd7GT727w741uqqFdm/6n+sIqhI2T pE5HIQ6CDDbqMdMaehN2e8ZpH7ycdp8UM2xI X-ML-Name: ruby-core X-Mail-Count: 69133 Subject: [ruby-core:69133] [Ruby trunk - Feature #11139] [PATCH] socket: accept_nonblock supports "nonblock: false" kwarg X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #11139 has been updated by Daniel Berger. How about just :block ? a.accept(block: false) a.accept_nonblock(block: true) ---------------------------------------- Feature #11139: [PATCH] socket: accept_nonblock supports "nonblock: false" kwarg https://bugs.ruby-lang.org/issues/11139#change-52382 * Author: Eric Wong * Status: Open * Priority: Normal * Assignee: Akira Tanaka ---------------------------------------- [PATCH 2/2] socket: accept_nonblock supports "nonblock: false" kwarg An application wanting to do non-blocking accept may want to create a blocking accepted socket, allow it with a kwarg while preserving default behavior. If this patch is accepted, I'd also like to support the opposite for blocking accept calls: a = s.accept(nonblock: true) # blocking accept syscall a.nonblock? # => true s.nonblock? # => false This requires the simple patch in [Feature #11138] I'm unsure if ":nonblock" is a good keyword to use, since it is somewhat confusing ---Files-------------------------------- 0002-socket-accept_nonblock-supports-nonblock-false-kwarg.patch (2.94 KB) -- https://bugs.ruby-lang.org/