From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id B8B0F17DE4BC for ; Sun, 1 Mar 2015 06:45:50 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (smtp.nagaokaut.ac.jp [133.44.2.201]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id 4A481B5D825 for ; Sun, 1 Mar 2015 06:50:16 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (localhost.nagaokaut.ac.jp [127.0.0.1]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id E423597A82B for ; Sun, 1 Mar 2015 06:50:16 +0900 (JST) X-Virus-Scanned: amavisd-new at nagaokaut.ac.jp Authentication-Results: funfun.nagaokaut.ac.jp (amavisd-new); dkim=fail (1024-bit key) reason="fail (message has been altered)" header.d=sendgrid.me Received: from funfun.nagaokaut.ac.jp ([127.0.0.1]) by funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kt6FckXjehyy for ; Sun, 1 Mar 2015 06:50:16 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id A7BE097A820 for ; Sun, 1 Mar 2015 06:50:16 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id B1CFE95241A for ; Sun, 1 Mar 2015 06:50:15 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 4DC46120440; Sun, 1 Mar 2015 06:50:11 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o10.shared.sendgrid.net (o10.shared.sendgrid.net [173.193.132.135]) by neon.ruby-lang.org (Postfix) with ESMTPS id 67E72120421 for ; Sun, 1 Mar 2015 06:49:58 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=5Gnrp9vybcFxvtWoDUBCEQwCQJ0=; b=kThIzaq5hqbk0r8OPT 3gauo4pjYQ+6m8pt5POFSe6mMIOz8ac3l9G0natolOQmk3PNoh3wKHiTPuFxKVaV K6dwNjSapgNKnqrnX+ciFqP3H+SWh4cQNC7OYPRFze00o0U3sqDUjqGCwXo5yvkY TKdhbTudizC5BMq17C5IrWMNU= Received: by filter0248p1mdw1.sendgrid.net with SMTP id filter0248p1mdw1.1728.54F237FF9 2015-02-28 21:49:52.183041334 +0000 UTC Received: from herokuapp.com (ec2-54-89-247-114.compute-1.amazonaws.com [54.89.247.114]) by ismtpd-009 (SG) with ESMTP id 14bd22ac05a.3018.15b610 Sat, 28 Feb 2015 21:49:52 +0000 (UTC) Date: Sat, 28 Feb 2015 21:49:51 +0000 From: ruby@tmm1.net To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Redmine-MailingListIntegration-Message-Ids: 42789 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 10902 X-Redmine-Issue-Author: tmm1 X-Redmine-Sender: tmm1 X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: OOF Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS59pRCbFEKeaDyWHRK7ZglTDeWqAfX4rRL3mN gWg5JPdzewiv2b7UFun2sYOl+om2kqs9vnVskPV5UzOX7fgQew4vdRhw01TjENsobWO4mXJfsRMLtw 2DrzWo7sNMgRgGZWRpssxqMFmAzxiiUnHKE9 X-ML-Name: ruby-core X-Mail-Count: 68358 Subject: [ruby-core:68358] [Ruby trunk - Bug #10902] require("enumerator") scans LOAD_PATH 2x on every invocation X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #10902 has been updated by Aman Gupta. Having a hard time coming up with a clean patch here. The following works but it's pretty hacky. ~~~ diff diff --git a/load.c b/load.c index fa225fa..68d15e7 100644 --- a/load.c +++ b/load.c @@ -952,6 +952,9 @@ rb_require_safe(VALUE fname, int safe) } volatile saved; char *volatile ftptr = 0; + if (strcmp(RSTRING_PTR(fname), "enumerator") == 0) + return Qfalse; + if (RUBY_DTRACE_REQUIRE_ENTRY_ENABLED()) { RUBY_DTRACE_REQUIRE_ENTRY(StringValuePtr(fname), rb_sourcefile(), ~~~ ---------------------------------------- Bug #10902: require("enumerator") scans LOAD_PATH 2x on every invocation https://bugs.ruby-lang.org/issues/10902#change-51702 * Author: Aman Gupta * Status: Open * Priority: Normal * Assignee: * ruby -v: ruby 2.1.5 * Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN ---------------------------------------- On every invocation of `require "enumerator"` (for example during boot when many gems require it), the VM will scan the load path twice: once for enumerator.rb and again for enumerator.so. Of course, no file is found because enumerator is now shipped within the VM by default. ~~~ $ ruby -e' p $LOADED_FEATURES[0] ' "enumerator.so" $ ruby -e' p $LOAD_PATH.size ' 8 $ strace -e trace=open ruby -e' 1.times{ require "enumerator" } ' 2>&1 | grep enumerator.rb | wc -l 8 $ strace -e trace=open ruby -e' 1.times{ require "enumerator" } ' 2>&1 | grep enumerator.so | wc -l 8 $ strace -e trace=open ruby -e' 10.times{ require "enumerator" } ' 2>&1 | grep enumerator.so | wc -l 80 $ strace -e trace=open ruby -e' 100.times{ require "enumerator" } ' 2>&1 | grep enumerator.so | wc -l 800 ~~~ In enumerator.c, we call `rb_provide("enumerator.so")` which adds it to $LOADED_FEATURES. This means `require "enumerator.so"` can be optimized, but most libraries do not include the .so extension when requiring enumerator. -- https://bugs.ruby-lang.org/