From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id 580FB17DE367 for ; Wed, 25 Feb 2015 07:35:31 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [133.44.2.201]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id A92F5B5D913 for ; Wed, 25 Feb 2015 07:39:21 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (localhost.nagaokaut.ac.jp [127.0.0.1]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id 6A26197A832 for ; Wed, 25 Feb 2015 07:39:22 +0900 (JST) X-Virus-Scanned: amavisd-new at nagaokaut.ac.jp Authentication-Results: funfun.nagaokaut.ac.jp (amavisd-new); dkim=fail (1024-bit key) reason="fail (message has been altered)" header.d=sendgrid.me Received: from funfun.nagaokaut.ac.jp ([127.0.0.1]) by funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7iKAbYJ1Pnjx for ; Wed, 25 Feb 2015 07:39:22 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id 4789B97A82C for ; Wed, 25 Feb 2015 07:39:22 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id 62F06952408 for ; Wed, 25 Feb 2015 07:39:21 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id BED0412043F; Wed, 25 Feb 2015 07:39:19 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o10.shared.sendgrid.net (o10.shared.sendgrid.net [173.193.132.135]) by neon.ruby-lang.org (Postfix) with ESMTPS id A29341203F8 for ; Wed, 25 Feb 2015 07:39:16 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=OSN/sKsBgTcNf+yNQixBCI9Dxt8=; b=iuhQQLSMbnVSf+DHMH grmkBOq66VmUFcV0ibbC7NxKEY8WoI5nRnwc1h/6hugrquNUFnbEJY0WuSG0nVA1 AA4OshduPwc0zXTe8Z9uuIxAPN83cYP3i8FFI1nbxCz0TDYrjko3hKONVh/Np9IG Vx2tx5+ZQyItGlPlKxeywCND4= Received: by filter0159p1mdw1.sendgrid.net with SMTP id filter0159p1mdw1.2807.54ECFD8F5 2015-02-24 22:39:12.273300151 +0000 UTC Received: from herokuapp.com (ec2-54-145-119-140.compute-1.amazonaws.com [54.145.119.140]) by ismtpd-014 (SG) with ESMTP id 14bbdbe7b3d.23a3.1f04b Tue, 24 Feb 2015 22:39:12 +0000 (UTC) Date: Tue, 24 Feb 2015 22:39:11 +0000 From: ruby@tmm1.net To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Redmine-MailingListIntegration-Message-Ids: 42719 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 10902 X-Redmine-Issue-Author: tmm1 X-Redmine-Sender: tmm1 X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: OOF Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS4qH6iY2rYuYKK9PEMOyIa/jTeARO+cDUNf+h XDn4i7kUY7jTv+1OrJMeG9c59ksmdiItQ/FqQLH3Dbqt78f8a49VqiPrJ+6QRQRGagqlaXZX71Cqo4 XRkkvbYaJ+XlHYg= X-ML-Name: ruby-core X-Mail-Count: 68291 Subject: [ruby-core:68291] [Ruby trunk - Bug #10902] require("enumerator") scans LOAD_PATH 2x on every invocation X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #10902 has been updated by Aman Gupta. This gets much worse as $LOAD_PATH grows. For example in our app $LOAD_PATH.size is 351, causing 702 failed open() syscalls per require. ---------------------------------------- Bug #10902: require("enumerator") scans LOAD_PATH 2x on every invocation https://bugs.ruby-lang.org/issues/10902#change-51644 * Author: Aman Gupta * Status: Open * Priority: Normal * Assignee: * ruby -v: ruby 2.1.5 * Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN ---------------------------------------- On every invocation of `require "enumerator"` (for example during boot when many gems require it), the VM will scan the load path twice: once for enumerator.rb and again for enumerator.so. Of course, no file is found because enumerator is now shipped within the VM by default. ~~~ $ ruby -e' p $LOADED_FEATURES[0] ' "enumerator.so" $ ruby -e' p $LOAD_PATH.size ' 8 $ strace -e trace=open ruby -e' 1.times{ require "enumerator" } ' 2>&1 | grep enumerator.rb | wc -l 8 $ strace -e trace=open ruby -e' 1.times{ require "enumerator" } ' 2>&1 | grep enumerator.so | wc -l 8 $ strace -e trace=open ruby -e' 10.times{ require "enumerator" } ' 2>&1 | grep enumerator.so | wc -l 80 $ strace -e trace=open ruby -e' 100.times{ require "enumerator" } ' 2>&1 | grep enumerator.so | wc -l 800 ~~~ In enumerator.c, we call `rb_provide("enumerator.so")` which adds it to $LOADED_FEATURES. This means `require "enumerator.so"` can be optimized, but most libraries do not include the .so extension when requiring enumerator. -- https://bugs.ruby-lang.org/