From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id AE87017DDC80 for ; Wed, 4 Feb 2015 17:16:11 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (smtp.nagaokaut.ac.jp [133.44.2.201]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id A058EB5D8D7 for ; Wed, 4 Feb 2015 17:16:59 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (localhost.nagaokaut.ac.jp [127.0.0.1]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id 8A8AA97A836 for ; Wed, 4 Feb 2015 17:17:01 +0900 (JST) X-Virus-Scanned: amavisd-new at nagaokaut.ac.jp Authentication-Results: funfun.nagaokaut.ac.jp (amavisd-new); dkim=fail (1024-bit key) reason="fail (message has been altered)" header.d=sendgrid.me Received: from funfun.nagaokaut.ac.jp ([127.0.0.1]) by funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SU9LPdOxgI8z for ; Wed, 4 Feb 2015 17:17:01 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id 4F4EC97A827 for ; Wed, 4 Feb 2015 17:17:01 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id 2287095241E for ; Wed, 4 Feb 2015 17:16:58 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id E83E9120456; Wed, 4 Feb 2015 17:16:57 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o2.heroku.sendgrid.net (o2.heroku.sendgrid.net [67.228.50.55]) by neon.ruby-lang.org (Postfix) with ESMTPS id 3427A120410 for ; Wed, 4 Feb 2015 17:16:53 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=uSEJTU8/5ZbiCdopBaRXfEX/zyo=; b=k1ee6gcU7sWKOOKDWG 4Yr/+B0hGbrlXVBzTiWU+QBy9u43xzhyFYMT6XkSiva6exkJc3Wg/ri7+cSpbkgd MGTjZkfVwhPQ9Y5jQsJYqBxdwoj6GLTjiGquxQwyF2JV0aR8hV0tD7q/Lp7OfNAp JJuyzN7zmZBHEIw/o/D3fY3i8= Received: by filter0203p1mdw1.sendgrid.net with SMTP id filter0203p1mdw1.7702.54D1D5716 2015-02-04 08:16:49.647979068 +0000 UTC Received: from herokuapp.com (ec2-54-159-239-43.compute-1.amazonaws.com [54.159.239.43]) by ismtpd-020 (SG) with ESMTP id 14b53a9c356.564c.19e82 for ; Wed, 04 Feb 2015 08:16:49 +0000 (UTC) Date: Wed, 04 Feb 2015 08:16:49 +0000 From: shugo@ruby-lang.org To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Redmine-MailingListIntegration-Message-Ids: 42428 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 10765 X-Redmine-Issue-Author: hanachin X-Redmine-Issue-Assignee: shugo X-Redmine-Sender: shugo X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: OOF Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS4+iz6+LlgV552ZEtPHRBzjvPyq5tG6Dh1Mg1 3T+pMAKM2rWvcatogxTxZFv/pAdxingjGvDM+D8YePa98hf2kwwDQmK1U+JPiWyfwdBfg+xkDUdTk/ j+Te2FafO2NtvbI= X-ML-Name: ruby-core X-Mail-Count: 68002 Subject: [ruby-core:68002] [ruby-trunk - Bug #10765] [Closed] Module#remove_method remove refined method entry. X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #10765 has been updated by Shugo Maeda. Status changed from Assigned to Closed Fixed in r49493. ---------------------------------------- Bug #10765: Module#remove_method remove refined method entry. https://bugs.ruby-lang.org/issues/10765#change-51393 * Author: Seiei Higa * Status: Closed * Priority: Normal * Assignee: Shugo Maeda * ruby -v: ruby 2.3.0dev (2015-01-21 trunk 49326) [x86_64-darwin14] * Backport: 2.0.0: REQUIRED, 2.1: REQUIRED, 2.2: REQUIRED ---------------------------------------- `Module#remove_method` should raise a `NameError` if method is not defined in refined class, such as [`undef`](https://bugs.ruby-lang.org/issues/8966). But if method is defined in refined class, `Module#remove_method` should keep refined method and remove original method. I confirmed by following examples in ruby-trunk, 2.2.0, 2.1.5, 2.0.0-p598 ``` ruby class C def foo "C#foo" end end module RefinementBug refine C do def foo "RefinementBug#foo" end end end using RefinementBug class C remove_method :foo end puts C.new.foo # expected: # RefinementBug#foo # # actual: # bug.rb:21:in `
': undefined method `foo' for # (NoMethodError) ``` ``` ruby class C end module RefinementBug refine C do def foo end end end using RefinementBug class C remove_method :foo end # expected: # bug2.rb:14:in `remove_method': method `foo' not defined in C (NameError) # from bug2.rb:14:in `' # from bug2.rb:13:in `
' # # actual: # # => nothing raised. ``` ---Files-------------------------------- bug2.rb (327 Bytes) bug.rb (342 Bytes) 0001-vm_method.c-fix-remove-refined-method.patch (2.68 KB) -- https://bugs.ruby-lang.org/