[ruby-core:67919] [ruby-trunk - Misc #10809] [Open] [PATCH 2/2] Add tests for math.c related to [Feature 10785], [Feature 10800]

[ruby-core:67919] [ruby-trunk - Misc #10809] [Open] [PATCH 2/2] Add tests for math.c related to [Feature 10785], [Feature 10800]

[mail]

Issue #10809 has been reported by gogo tanaka.

----------------------------------------
Misc #10809: [PATCH 2/2] Add tests for math.c related to [Feature 10785], [Feature 10800]
https://bugs.ruby-lang.org/issues/10809

* Author: gogo tanaka
* Status: Open
* Priority: Normal
* Assignee: Nobuyoshi Nakada
----------------------------------------
Hi! Here are two patches.


## reorder_test_cbrt_and_add_a_assertion.patch:
Move Test#test_cbrt to more proper place and add a assertion for Math.cbrt(1.0/0)

## add_test_for_math_c_about_overriding_Integer_to_f.patch:

Add tests for [Feature 10785](https://bugs.ruby-lang.org/issues/10785) and  [Feature 10800](https://bugs.ruby-lang.org/issues/10800)

These two features are merged by Nobuyoshi Nakada san, so I assigned him but please feel free to reassigne.

thanks.

---Files--------------------------------
reorder_test_cbrt_and_add_a_assertion.patch (1.19 KB)
add_test_for_math_c_about_overriding_Integer_to_f.patch (1.36 KB)


-- 
https://bugs.ruby-lang.org/

[ruby-core:67921] [ruby-trunk - Misc #10809] [PATCH 2/2] Add tests for math.c related to [Feature 10785], [Feature 10800]

[nobu]

Issue #10809 has been updated by Nobuyoshi Nakada.


> ~~~diff
> +    assert_equal(1.0/0, Math.cbrt(1.0/0))
> ~~~

Isn't it better to use `assert_infinity`?

> ~~~diff
> +      def to_f
> +        _to_f
> +      end
> ~~~

Why not revert to the original methods?


----------------------------------------
Misc #10809: [PATCH 2/2] Add tests for math.c related to [Feature 10785], [Feature 10800]
https://bugs.ruby-lang.org/issues/10809#change-51315

* Author: kazuki tanaka
* Status: Open
* Priority: Normal
* Assignee: Nobuyoshi Nakada
----------------------------------------
Hi! Here are two patches.


## reorder_test_cbrt_and_add_a_assertion.patch:
Move Test#test_cbrt to more proper place and add a assertion for Math.cbrt(1.0/0)

## add_test_for_math_c_about_overriding_Integer_to_f.patch:

Add tests for [Feature 10785](https://bugs.ruby-lang.org/issues/10785) and  [Feature 10800](https://bugs.ruby-lang.org/issues/10800)

These two features are merged by Nobuyoshi Nakada san, so I assigned him but please feel free to reassigne.

thanks.

---Files--------------------------------
reorder_test_cbrt_and_add_a_assertion.patch (1.19 KB)
add_test_for_math_c_about_overriding_Integer_to_f.patch (1.36 KB)


-- 
https://bugs.ruby-lang.org/

[ruby-core:67922] unsubscribe

[David Smith]

[-- Attachment #1: Type: text/plain, Size: 1474 bytes --]



-- 
David Smith
djs070@gmail.com
0408 692 261

On 1 February 2015 at 2:14:46 pm, nobu@ruby-lang.org (nobu@ruby-lang.org) wrote:

Issue #10809 has been updated by Nobuyoshi Nakada.  


> ~~~diff  
> + assert_equal(1.0/0, Math.cbrt(1.0/0))  
> ~~~  

Isn't it better to use `assert_infinity`?  

> ~~~diff  
> + def to_f  
> + _to_f  
> + end  
> ~~~  

Why not revert to the original methods?  


----------------------------------------  
Misc #10809: [PATCH 2/2] Add tests for math.c related to [Feature 10785], [Feature 10800]  
https://bugs.ruby-lang.org/issues/10809#change-51315  

* Author: kazuki tanaka  
* Status: Open  
* Priority: Normal  
* Assignee: Nobuyoshi Nakada  
----------------------------------------  
Hi! Here are two patches.  


## reorder_test_cbrt_and_add_a_assertion.patch:  
Move Test#test_cbrt to more proper place and add a assertion for Math.cbrt(1.0/0)  

## add_test_for_math_c_about_overriding_Integer_to_f.patch:  

Add tests for [Feature 10785](https://bugs.ruby-lang.org/issues/10785) and [Feature 10800](https://bugs.ruby-lang.org/issues/10800)  

These two features are merged by Nobuyoshi Nakada san, so I assigned him but please feel free to reassigne.  

thanks.  

---Files--------------------------------  
reorder_test_cbrt_and_add_a_assertion.patch (1.19 KB)  
add_test_for_math_c_about_overriding_Integer_to_f.patch (1.36 KB)  


--  
https://bugs.ruby-lang.org/  

[-- Attachment #2: Type: text/html, Size: 2395 bytes --]

[ruby-core:67926] [ruby-trunk - Misc #10809] [PATCH 2/2] Add tests for math.c related to [Feature 10785], [Feature 10800]

[mail]

Issue #10809 has been updated by kazuki tanaka.

File use_assert_infinity.patch added

> Isn't it better to use assert_infinity?

It's much better! I attached patch \bto follow what you said(not only `Math.cbrt` also other cases)

> Why not revert to the original methods?

I intended to revert to the original methods through this way.

The reason I revert is I don't wanna other cases is affected by this.

thanks.

----------------------------------------
Misc #10809: [PATCH 2/2] Add tests for math.c related to [Feature 10785], [Feature 10800]
https://bugs.ruby-lang.org/issues/10809#change-51319

* Author: kazuki tanaka
* Status: Open
* Priority: Normal
* Assignee: Nobuyoshi Nakada
----------------------------------------
Hi! Here are two patches.


## reorder_test_cbrt_and_add_a_assertion.patch:
Move Test#test_cbrt to more proper place and add a assertion for Math.cbrt(1.0/0)

## add_test_for_math_c_about_overriding_Integer_to_f.patch:

Add tests for [Feature 10785](https://bugs.ruby-lang.org/issues/10785) and  [Feature 10800](https://bugs.ruby-lang.org/issues/10800)

These two features are merged by Nobuyoshi Nakada san, so I assigned him but please feel free to reassigne.

thanks.

---Files--------------------------------
reorder_test_cbrt_and_add_a_assertion.patch (1.19 KB)
add_test_for_math_c_about_overriding_Integer_to_f.patch (1.36 KB)
use_assert_infinity.patch (2.53 KB)


-- 
https://bugs.ruby-lang.org/

[ruby-core:67927] [ruby-trunk - Misc #10809] [PATCH 2/2] Add tests for math.c related to [Feature 10785], [Feature 10800]

[mail]

Issue #10809 has been updated by kazuki tanaka.

File revert_to_original_methods.patch added

> Isn't it better to use assert_infinity?

It's much better! I attached patch \bto follow what you said(not only `Math.cbrt` also other cases)

> Why not revert to the original methods?

I intended to revert to the original methods through this way.

The reason I revert is I don't wanna other cases is affected by this.

thanks.

----------------------------------------
Misc #10809: [PATCH 2/2] Add tests for math.c related to [Feature 10785], [Feature 10800]
https://bugs.ruby-lang.org/issues/10809#change-51320

* Author: kazuki tanaka
* Status: Open
* Priority: Normal
* Assignee: Nobuyoshi Nakada
----------------------------------------
Hi! Here are two patches.


## reorder_test_cbrt_and_add_a_assertion.patch:
Move Test#test_cbrt to more proper place and add a assertion for Math.cbrt(1.0/0)

## add_test_for_math_c_about_overriding_Integer_to_f.patch:

Add tests for [Feature 10785](https://bugs.ruby-lang.org/issues/10785) and  [Feature 10800](https://bugs.ruby-lang.org/issues/10800)

These two features are merged by Nobuyoshi Nakada san, so I assigned him but please feel free to reassigne.

thanks.

---Files--------------------------------
reorder_test_cbrt_and_add_a_assertion.patch (1.19 KB)
add_test_for_math_c_about_overriding_Integer_to_f.patch (1.36 KB)
use_assert_infinity.patch (2.53 KB)
revert_to_original_methods.patch (1.1 KB)


-- 
https://bugs.ruby-lang.org/

[ruby-core:67928] [ruby-trunk - Misc #10809] [PATCH 2/2] Add tests for math.c related to [Feature 10785], [Feature 10800]

[nobu]

Issue #10809 has been updated by Nobuyoshi Nakada.


`class_eval` with a block form would be preferable to a string form in may cases.

Are you going to commit these patches by yourself?
If so, then ask matz, and follow the instruction [CommitterHowto](https://bugs.ruby-lang.org/projects/ruby/wiki/CommitterHowto)

----------------------------------------
Misc #10809: [PATCH 2/2] Add tests for math.c related to [Feature 10785], [Feature 10800]
https://bugs.ruby-lang.org/issues/10809#change-51321

* Author: kazuki tanaka
* Status: Open
* Priority: Normal
* Assignee: Nobuyoshi Nakada
----------------------------------------
Hi! Here are two patches.


## reorder_test_cbrt_and_add_a_assertion.patch:
Move Test#test_cbrt to more proper place and add a assertion for Math.cbrt(1.0/0)

## add_test_for_math_c_about_overriding_Integer_to_f.patch:

Add tests for [Feature 10785](https://bugs.ruby-lang.org/issues/10785) and  [Feature 10800](https://bugs.ruby-lang.org/issues/10800)

These two features are merged by Nobuyoshi Nakada san, so I assigned him but please feel free to reassigne.

thanks.

---Files--------------------------------
reorder_test_cbrt_and_add_a_assertion.patch (1.19 KB)
add_test_for_math_c_about_overriding_Integer_to_f.patch (1.36 KB)
use_assert_infinity.patch (2.53 KB)
revert_to_original_methods.patch (1.1 KB)


-- 
https://bugs.ruby-lang.org/

[ruby-core:67932] [ruby-trunk - Misc #10809] [PATCH 2/2] Add tests for math.c related to [Feature 10785], [Feature 10800]

[mail]

Issue #10809 has been updated by kazuki tanaka.


It's my super great pleasure to be able to do that, I'm glad to and go to follow what you said.

But now I'm afraid of committing myself and I realize there'er much things I should know.

So it seems to take time.

Anyway, I wanna to do so. thanks.




----------------------------------------
Misc #10809: [PATCH 2/2] Add tests for math.c related to [Feature 10785], [Feature 10800]
https://bugs.ruby-lang.org/issues/10809#change-51324

* Author: kazuki tanaka
* Status: Open
* Priority: Normal
* Assignee: Nobuyoshi Nakada
----------------------------------------
Hi! Here are two patches.


## reorder_test_cbrt_and_add_a_assertion.patch:
Move Test#test_cbrt to more proper place and add a assertion for Math.cbrt(1.0/0)

## add_test_for_math_c_about_overriding_Integer_to_f.patch:

Add tests for [Feature 10785](https://bugs.ruby-lang.org/issues/10785) and  [Feature 10800](https://bugs.ruby-lang.org/issues/10800)

These two features are merged by Nobuyoshi Nakada san, so I assigned him but please feel free to reassigne.

thanks.

---Files--------------------------------
reorder_test_cbrt_and_add_a_assertion.patch (1.19 KB)
add_test_for_math_c_about_overriding_Integer_to_f.patch (1.36 KB)
use_assert_infinity.patch (2.53 KB)
revert_to_original_methods.patch (1.1 KB)


-- 
https://bugs.ruby-lang.org/

[ruby-core:67942] [ruby-trunk - Misc #10809] [PATCH 2/2] Add tests for math.c related to [Feature 10785], [Feature 10800]

[matz]

Issue #10809 has been updated by Yukihiro Matsumoto.


Commit bit approved.  Proceed to usual previledge grant process.

Matz.


----------------------------------------
Misc #10809: [PATCH 2/2] Add tests for math.c related to [Feature 10785], [Feature 10800]
https://bugs.ruby-lang.org/issues/10809#change-51331

* Author: kazuki tanaka
* Status: Open
* Priority: Normal
* Assignee: Nobuyoshi Nakada
----------------------------------------
Hi! Here are two patches.


## reorder_test_cbrt_and_add_a_assertion.patch:
Move Test#test_cbrt to more proper place and add a assertion for Math.cbrt(1.0/0)

## add_test_for_math_c_about_overriding_Integer_to_f.patch:

Add tests for [Feature 10785](https://bugs.ruby-lang.org/issues/10785) and  [Feature 10800](https://bugs.ruby-lang.org/issues/10800)

These two features are merged by Nobuyoshi Nakada san, so I assigned him but please feel free to reassigne.

thanks.

---Files--------------------------------
reorder_test_cbrt_and_add_a_assertion.patch (1.19 KB)
add_test_for_math_c_about_overriding_Integer_to_f.patch (1.36 KB)
use_assert_infinity.patch (2.53 KB)
revert_to_original_methods.patch (1.1 KB)


-- 
https://bugs.ruby-lang.org/

[ruby-core:68218] [Ruby trunk - Misc #10809] [PATCH 2/2] Add tests for math.c related to [Feature 10785], [Feature 10800]

[mail]

Issue #10809 has been updated by kazuki tanaka.

File add_test_about_overriding_Integer_to_f_20150222.patch added

I'll commit these 3 patches.

### reorder_test_cbrt_and_add_a_assertion.patch:
Move Test#test_cbrt to more proper place and add a assertion for Math.cbrt(1.0/0)

### use_assert_infinity.patch:
Use `assert_infinity ` instead of `assert_equal(1.0/0, ...)`

### add_test_about_overriding_Integer_to_f_20150222.patch:
Add tests for `Feature 10785` and `Feature 10800`

----------------------------------------
Misc #10809: [PATCH 2/2] Add tests for math.c related to [Feature 10785], [Feature 10800]
https://bugs.ruby-lang.org/issues/10809#change-51580

* Author: kazuki tanaka
* Status: Open
* Priority: Normal
* Assignee: Nobuyoshi Nakada
----------------------------------------
Hi! Here are two patches.


## reorder_test_cbrt_and_add_a_assertion.patch:
Move Test#test_cbrt to more proper place and add a assertion for Math.cbrt(1.0/0)

## add_test_for_math_c_about_overriding_Integer_to_f.patch:

Add tests for [Feature 10785](https://bugs.ruby-lang.org/issues/10785) and  [Feature 10800](https://bugs.ruby-lang.org/issues/10800)

These two features are merged by Nobuyoshi Nakada san, so I assigned him but please feel free to reassigne.

thanks.

---Files--------------------------------
reorder_test_cbrt_and_add_a_assertion.patch (1.19 KB)
add_test_for_math_c_about_overriding_Integer_to_f.patch (1.36 KB)
use_assert_infinity.patch (2.53 KB)
revert_to_original_methods.patch (1.1 KB)
add_test_about_overriding_Integer_to_f_20150222.patch (1.31 KB)


-- 
https://bugs.ruby-lang.org/

[ruby-core:68361] [Ruby trunk - Misc #10809] [Closed] [PATCH 2/2] Add tests for math.c related to [Feature 10785], [Feature 10800]

[mail]

Issue #10809 has been updated by gogo tanaka.

Status changed from Open to Closed

----------------------------------------
Misc #10809: [PATCH 2/2] Add tests for math.c related to [Feature 10785], [Feature 10800]
https://bugs.ruby-lang.org/issues/10809#change-51708

* Author: gogo tanaka
* Status: Closed
* Priority: Normal
* Assignee: Nobuyoshi Nakada
----------------------------------------
Hi! Here are two patches.


## reorder_test_cbrt_and_add_a_assertion.patch:
Move Test#test_cbrt to more proper place and add a assertion for Math.cbrt(1.0/0)

## add_test_for_math_c_about_overriding_Integer_to_f.patch:

Add tests for [Feature 10785](https://bugs.ruby-lang.org/issues/10785) and  [Feature 10800](https://bugs.ruby-lang.org/issues/10800)

These two features are merged by Nobuyoshi Nakada san, so I assigned him but please feel free to reassigne.

thanks.

---Files--------------------------------
reorder_test_cbrt_and_add_a_assertion.patch (1.19 KB)
add_test_for_math_c_about_overriding_Integer_to_f.patch (1.36 KB)
use_assert_infinity.patch (2.53 KB)
revert_to_original_methods.patch (1.1 KB)
add_test_about_overriding_Integer_to_f_20150222.patch (1.31 KB)


-- 
https://bugs.ruby-lang.org/