ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
* [ruby-core:65058] [ruby-trunk - Bug #10245] [Open] TestTimeTZ#test_gen_Europe_Lisbon_111 fails with recent tzdata
       [not found] <redmine.issue-10245.20140916054806@ruby-lang.org>
@ 2014-09-16  5:48 ` v.ondruch
  2014-09-16  5:52 ` [ruby-core:65059] [ruby-trunk - Bug #10245] " v.ondruch
                   ` (7 subsequent siblings)
  8 siblings, 0 replies; 9+ messages in thread
From: v.ondruch @ 2014-09-16  5:48 UTC (permalink / raw
  To: ruby-core

Issue #10245 has been reported by Vit Ondruch.

----------------------------------------
Bug #10245: TestTimeTZ#test_gen_Europe_Lisbon_111 fails with recent tzdata
https://bugs.ruby-lang.org/issues/10245

* Author: Vit Ondruch
* Status: Open
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 
* ruby -v: ruby 2.2.0dev (2014-09-15 trunk 47594) [x86_64-linux]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN
----------------------------------------
In Fedora, tzdata were recently updated to tzdata-2014g-1.fc22 [1]. Since that update, one test case fails:

~~~
$ make test-all TESTS=test/ruby/test_time_tz.rb
...
snip
...

[ 79/123] TestTimeTZ#test_gen_Europe_Lisbon_111 = 0.00 s             
  1) Failure:
TestTimeTZ#test_gen_Europe_Lisbon_111 [/builddir/build/BUILD/ruby-2.2.0-r47594/test/ruby/test_time_tz.rb:250]:
TZ=Europe/Lisbon Time.utc(1912, 1, 1, 0, 36, 31).localtime.
<"1911-12-31 23:59:59 -0036"> expected but was
<"1911-12-31 23:59:46 -0036">.
~~~

This is what Red Hat's tzdata maintainer says about that change [2]:

> tl;dr: Ruby will have to fix its test suite.
>
> I expect that this comes from Ruby-internal test suite that expects Europe/Lisbon on some offset, and is surprised that it's actually a couple seconds off.  But that far back, time didn't use to be split to zones like today, and every location kept its own local time.  I think that most stamps in zoneinfo were calculated from GMT coordinates of the city (which itself is a somewhat fuzzy notion), and are corrected based on historical sources only retroactively, when someone gets to it, or when someone complains.  That's what happened here--Paul Eggert got to Lisbon.
> 
> It seems like Europe/Brussels might be a good choice for this sort of test, because it's local mean time has been based on an official document since 1997.

Could you please make the test case compatible with recent tzdata? Thanks.

[1] https://koji.fedoraproject.org/koji/buildinfo?buildID=576705
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1141775



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [ruby-core:65059] [ruby-trunk - Bug #10245] TestTimeTZ#test_gen_Europe_Lisbon_111 fails with recent tzdata
       [not found] <redmine.issue-10245.20140916054806@ruby-lang.org>
  2014-09-16  5:48 ` [ruby-core:65058] [ruby-trunk - Bug #10245] [Open] TestTimeTZ#test_gen_Europe_Lisbon_111 fails with recent tzdata v.ondruch
@ 2014-09-16  5:52 ` v.ondruch
  2014-09-22  3:12 ` [ruby-core:65199] [ruby-trunk - Bug #10245] [Closed] " akr
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 9+ messages in thread
From: v.ondruch @ 2014-09-16  5:52 UTC (permalink / raw
  To: ruby-core

Issue #10245 has been updated by Vit Ondruch.


BTW I have not tested it, but I'd expect that this is issue for all currently supported Ruby releases.

----------------------------------------
Bug #10245: TestTimeTZ#test_gen_Europe_Lisbon_111 fails with recent tzdata
https://bugs.ruby-lang.org/issues/10245#change-48926

* Author: Vit Ondruch
* Status: Open
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 
* ruby -v: ruby 2.2.0dev (2014-09-15 trunk 47594) [x86_64-linux]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN
----------------------------------------
In Fedora, tzdata were recently updated to tzdata-2014g-1.fc22 [1]. Since that update, one test case fails:

~~~
$ make test-all TESTS=test/ruby/test_time_tz.rb
...
snip
...

[ 79/123] TestTimeTZ#test_gen_Europe_Lisbon_111 = 0.00 s             
  1) Failure:
TestTimeTZ#test_gen_Europe_Lisbon_111 [/builddir/build/BUILD/ruby-2.2.0-r47594/test/ruby/test_time_tz.rb:250]:
TZ=Europe/Lisbon Time.utc(1912, 1, 1, 0, 36, 31).localtime.
<"1911-12-31 23:59:59 -0036"> expected but was
<"1911-12-31 23:59:46 -0036">.
~~~

This is what Red Hat's tzdata maintainer says about that change [2]:

> tl;dr: Ruby will have to fix its test suite.
>
> I expect that this comes from Ruby-internal test suite that expects Europe/Lisbon on some offset, and is surprised that it's actually a couple seconds off.  But that far back, time didn't use to be split to zones like today, and every location kept its own local time.  I think that most stamps in zoneinfo were calculated from GMT coordinates of the city (which itself is a somewhat fuzzy notion), and are corrected based on historical sources only retroactively, when someone gets to it, or when someone complains.  That's what happened here--Paul Eggert got to Lisbon.
> 
> It seems like Europe/Brussels might be a good choice for this sort of test, because it's local mean time has been based on an official document since 1997.

Could you please make the test case compatible with recent tzdata? Thanks.

[1] https://koji.fedoraproject.org/koji/buildinfo?buildID=576705
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1141775



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [ruby-core:65199] [ruby-trunk - Bug #10245] [Closed] TestTimeTZ#test_gen_Europe_Lisbon_111 fails with recent tzdata
       [not found] <redmine.issue-10245.20140916054806@ruby-lang.org>
  2014-09-16  5:48 ` [ruby-core:65058] [ruby-trunk - Bug #10245] [Open] TestTimeTZ#test_gen_Europe_Lisbon_111 fails with recent tzdata v.ondruch
  2014-09-16  5:52 ` [ruby-core:65059] [ruby-trunk - Bug #10245] " v.ondruch
@ 2014-09-22  3:12 ` akr
  2014-09-22  3:14 ` [ruby-core:65201] [ruby-trunk - Bug #10245] " akr
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 9+ messages in thread
From: akr @ 2014-09-22  3:12 UTC (permalink / raw
  To: ruby-core

Issue #10245 has been updated by Akira Tanaka.

Status changed from Open to Closed
% Done changed from 0 to 100

Applied in changeset r47680.

----------
* test/ruby/test_time_tz.rb: Fix test error with tzdata-2014g.
  [ruby-core:65058] [Bug #10245] Reported by Vit Ondruch.

----------------------------------------
Bug #10245: TestTimeTZ#test_gen_Europe_Lisbon_111 fails with recent tzdata
https://bugs.ruby-lang.org/issues/10245#change-49038

* Author: Vit Ondruch
* Status: Closed
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 
* ruby -v: ruby 2.2.0dev (2014-09-15 trunk 47594) [x86_64-linux]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN
----------------------------------------
In Fedora, tzdata were recently updated to tzdata-2014g-1.fc22 [1]. Since that update, one test case fails:

~~~
$ make test-all TESTS=test/ruby/test_time_tz.rb
...
snip
...

[ 79/123] TestTimeTZ#test_gen_Europe_Lisbon_111 = 0.00 s             
  1) Failure:
TestTimeTZ#test_gen_Europe_Lisbon_111 [/builddir/build/BUILD/ruby-2.2.0-r47594/test/ruby/test_time_tz.rb:250]:
TZ=Europe/Lisbon Time.utc(1912, 1, 1, 0, 36, 31).localtime.
<"1911-12-31 23:59:59 -0036"> expected but was
<"1911-12-31 23:59:46 -0036">.
~~~

This is what Red Hat's tzdata maintainer says about that change [2]:

> tl;dr: Ruby will have to fix its test suite.
>
> I expect that this comes from Ruby-internal test suite that expects Europe/Lisbon on some offset, and is surprised that it's actually a couple seconds off.  But that far back, time didn't use to be split to zones like today, and every location kept its own local time.  I think that most stamps in zoneinfo were calculated from GMT coordinates of the city (which itself is a somewhat fuzzy notion), and are corrected based on historical sources only retroactively, when someone gets to it, or when someone complains.  That's what happened here--Paul Eggert got to Lisbon.
> 
> It seems like Europe/Brussels might be a good choice for this sort of test, because it's local mean time has been based on an official document since 1997.

Could you please make the test case compatible with recent tzdata? Thanks.

[1] https://koji.fedoraproject.org/koji/buildinfo?buildID=576705
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1141775



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [ruby-core:65201] [ruby-trunk - Bug #10245] TestTimeTZ#test_gen_Europe_Lisbon_111 fails with recent tzdata
       [not found] <redmine.issue-10245.20140916054806@ruby-lang.org>
                   ` (2 preceding siblings ...)
  2014-09-22  3:12 ` [ruby-core:65199] [ruby-trunk - Bug #10245] [Closed] " akr
@ 2014-09-22  3:14 ` akr
  2014-09-23 16:02 ` [ruby-core:65244] " nagachika00
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 9+ messages in thread
From: akr @ 2014-09-22  3:14 UTC (permalink / raw
  To: ruby-core

Issue #10245 has been updated by Akira Tanaka.


I committed a fix r47680.

It still test Europe/Lisbon because I'd like to test
an situation that gmtoff is not a multiples of 60 seconds.

----------------------------------------
Bug #10245: TestTimeTZ#test_gen_Europe_Lisbon_111 fails with recent tzdata
https://bugs.ruby-lang.org/issues/10245#change-49039

* Author: Vit Ondruch
* Status: Closed
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 
* ruby -v: ruby 2.2.0dev (2014-09-15 trunk 47594) [x86_64-linux]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN
----------------------------------------
In Fedora, tzdata were recently updated to tzdata-2014g-1.fc22 [1]. Since that update, one test case fails:

~~~
$ make test-all TESTS=test/ruby/test_time_tz.rb
...
snip
...

[ 79/123] TestTimeTZ#test_gen_Europe_Lisbon_111 = 0.00 s             
  1) Failure:
TestTimeTZ#test_gen_Europe_Lisbon_111 [/builddir/build/BUILD/ruby-2.2.0-r47594/test/ruby/test_time_tz.rb:250]:
TZ=Europe/Lisbon Time.utc(1912, 1, 1, 0, 36, 31).localtime.
<"1911-12-31 23:59:59 -0036"> expected but was
<"1911-12-31 23:59:46 -0036">.
~~~

This is what Red Hat's tzdata maintainer says about that change [2]:

> tl;dr: Ruby will have to fix its test suite.
>
> I expect that this comes from Ruby-internal test suite that expects Europe/Lisbon on some offset, and is surprised that it's actually a couple seconds off.  But that far back, time didn't use to be split to zones like today, and every location kept its own local time.  I think that most stamps in zoneinfo were calculated from GMT coordinates of the city (which itself is a somewhat fuzzy notion), and are corrected based on historical sources only retroactively, when someone gets to it, or when someone complains.  That's what happened here--Paul Eggert got to Lisbon.
> 
> It seems like Europe/Brussels might be a good choice for this sort of test, because it's local mean time has been based on an official document since 1997.

Could you please make the test case compatible with recent tzdata? Thanks.

[1] https://koji.fedoraproject.org/koji/buildinfo?buildID=576705
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1141775



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [ruby-core:65244] [ruby-trunk - Bug #10245] TestTimeTZ#test_gen_Europe_Lisbon_111 fails with recent tzdata
       [not found] <redmine.issue-10245.20140916054806@ruby-lang.org>
                   ` (3 preceding siblings ...)
  2014-09-22  3:14 ` [ruby-core:65201] [ruby-trunk - Bug #10245] " akr
@ 2014-09-23 16:02 ` nagachika00
  2014-09-23 17:08 ` [ruby-core:65245] " nagachika00
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 9+ messages in thread
From: nagachika00 @ 2014-09-23 16:02 UTC (permalink / raw
  To: ruby-core

Issue #10245 has been updated by Tomoyuki Chikanaga.

Backport changed from 2.0.0: UNKNOWN, 2.1: UNKNOWN to 2.0.0: REQUIRED, 2.1: REQUIRED

----------------------------------------
Bug #10245: TestTimeTZ#test_gen_Europe_Lisbon_111 fails with recent tzdata
https://bugs.ruby-lang.org/issues/10245#change-49073

* Author: Vit Ondruch
* Status: Closed
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 
* ruby -v: ruby 2.2.0dev (2014-09-15 trunk 47594) [x86_64-linux]
* Backport: 2.0.0: REQUIRED, 2.1: REQUIRED
----------------------------------------
In Fedora, tzdata were recently updated to tzdata-2014g-1.fc22 [1]. Since that update, one test case fails:

~~~
$ make test-all TESTS=test/ruby/test_time_tz.rb
...
snip
...

[ 79/123] TestTimeTZ#test_gen_Europe_Lisbon_111 = 0.00 s             
  1) Failure:
TestTimeTZ#test_gen_Europe_Lisbon_111 [/builddir/build/BUILD/ruby-2.2.0-r47594/test/ruby/test_time_tz.rb:250]:
TZ=Europe/Lisbon Time.utc(1912, 1, 1, 0, 36, 31).localtime.
<"1911-12-31 23:59:59 -0036"> expected but was
<"1911-12-31 23:59:46 -0036">.
~~~

This is what Red Hat's tzdata maintainer says about that change [2]:

> tl;dr: Ruby will have to fix its test suite.
>
> I expect that this comes from Ruby-internal test suite that expects Europe/Lisbon on some offset, and is surprised that it's actually a couple seconds off.  But that far back, time didn't use to be split to zones like today, and every location kept its own local time.  I think that most stamps in zoneinfo were calculated from GMT coordinates of the city (which itself is a somewhat fuzzy notion), and are corrected based on historical sources only retroactively, when someone gets to it, or when someone complains.  That's what happened here--Paul Eggert got to Lisbon.
> 
> It seems like Europe/Brussels might be a good choice for this sort of test, because it's local mean time has been based on an official document since 1997.

Could you please make the test case compatible with recent tzdata? Thanks.

[1] https://koji.fedoraproject.org/koji/buildinfo?buildID=576705
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1141775



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [ruby-core:65245] [ruby-trunk - Bug #10245] TestTimeTZ#test_gen_Europe_Lisbon_111 fails with recent tzdata
       [not found] <redmine.issue-10245.20140916054806@ruby-lang.org>
                   ` (4 preceding siblings ...)
  2014-09-23 16:02 ` [ruby-core:65244] " nagachika00
@ 2014-09-23 17:08 ` nagachika00
  2014-10-14  7:02 ` [ruby-core:65696] [ruby-trunk - Bug #10245] [Open] " v.ondruch
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 9+ messages in thread
From: nagachika00 @ 2014-09-23 17:08 UTC (permalink / raw
  To: ruby-core

Issue #10245 has been updated by Tomoyuki Chikanaga.

Backport changed from 2.0.0: REQUIRED, 2.1: REQUIRED to 2.0.0: REQUIRED, 2.1: DONE

r47111, r47212, r47451, r47452 and r47680 were backported into `ruby_2_1` branch at r47700.

----------------------------------------
Bug #10245: TestTimeTZ#test_gen_Europe_Lisbon_111 fails with recent tzdata
https://bugs.ruby-lang.org/issues/10245#change-49075

* Author: Vit Ondruch
* Status: Closed
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 
* ruby -v: ruby 2.2.0dev (2014-09-15 trunk 47594) [x86_64-linux]
* Backport: 2.0.0: REQUIRED, 2.1: DONE
----------------------------------------
In Fedora, tzdata were recently updated to tzdata-2014g-1.fc22 [1]. Since that update, one test case fails:

~~~
$ make test-all TESTS=test/ruby/test_time_tz.rb
...
snip
...

[ 79/123] TestTimeTZ#test_gen_Europe_Lisbon_111 = 0.00 s             
  1) Failure:
TestTimeTZ#test_gen_Europe_Lisbon_111 [/builddir/build/BUILD/ruby-2.2.0-r47594/test/ruby/test_time_tz.rb:250]:
TZ=Europe/Lisbon Time.utc(1912, 1, 1, 0, 36, 31).localtime.
<"1911-12-31 23:59:59 -0036"> expected but was
<"1911-12-31 23:59:46 -0036">.
~~~

This is what Red Hat's tzdata maintainer says about that change [2]:

> tl;dr: Ruby will have to fix its test suite.
>
> I expect that this comes from Ruby-internal test suite that expects Europe/Lisbon on some offset, and is surprised that it's actually a couple seconds off.  But that far back, time didn't use to be split to zones like today, and every location kept its own local time.  I think that most stamps in zoneinfo were calculated from GMT coordinates of the city (which itself is a somewhat fuzzy notion), and are corrected based on historical sources only retroactively, when someone gets to it, or when someone complains.  That's what happened here--Paul Eggert got to Lisbon.
> 
> It seems like Europe/Brussels might be a good choice for this sort of test, because it's local mean time has been based on an official document since 1997.

Could you please make the test case compatible with recent tzdata? Thanks.

[1] https://koji.fedoraproject.org/koji/buildinfo?buildID=576705
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1141775



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [ruby-core:65696] [ruby-trunk - Bug #10245] [Open] TestTimeTZ#test_gen_Europe_Lisbon_111 fails with recent tzdata
       [not found] <redmine.issue-10245.20140916054806@ruby-lang.org>
                   ` (5 preceding siblings ...)
  2014-09-23 17:08 ` [ruby-core:65245] " nagachika00
@ 2014-10-14  7:02 ` v.ondruch
  2014-10-14  7:24 ` [ruby-core:65697] [ruby-trunk - Bug #10245] [Closed] " v.ondruch
  2014-10-15  7:25 ` [ruby-core:65722] [ruby-trunk - Bug #10245] " usa
  8 siblings, 0 replies; 9+ messages in thread
From: v.ondruch @ 2014-10-14  7:02 UTC (permalink / raw
  To: ruby-core

Issue #10245 has been updated by Vit Ondruch.

Status changed from Closed to Open
Assignee set to Akira Tanaka

Sorry but it does not work for me. However, the error is now different:

~~~
  1) Failure:
TestTimeTZ#test_gen_lisbon_111 [/builddir/build/BUILD/ruby-2.2.0-r47902/test/ruby/test_time_tz.rb:396]:
Expected [] to include [true, true, true, true, true].
~~~

----------------------------------------
Bug #10245: TestTimeTZ#test_gen_Europe_Lisbon_111 fails with recent tzdata
https://bugs.ruby-lang.org/issues/10245#change-49425

* Author: Vit Ondruch
* Status: Open
* Priority: Normal
* Assignee: Akira Tanaka
* Category: 
* Target version: 
* ruby -v: ruby 2.2.0dev (2014-09-15 trunk 47594) [x86_64-linux]
* Backport: 2.0.0: REQUIRED, 2.1: DONE
----------------------------------------
In Fedora, tzdata were recently updated to tzdata-2014g-1.fc22 [1]. Since that update, one test case fails:

~~~
$ make test-all TESTS=test/ruby/test_time_tz.rb
...
snip
...

[ 79/123] TestTimeTZ#test_gen_Europe_Lisbon_111 = 0.00 s             
  1) Failure:
TestTimeTZ#test_gen_Europe_Lisbon_111 [/builddir/build/BUILD/ruby-2.2.0-r47594/test/ruby/test_time_tz.rb:250]:
TZ=Europe/Lisbon Time.utc(1912, 1, 1, 0, 36, 31).localtime.
<"1911-12-31 23:59:59 -0036"> expected but was
<"1911-12-31 23:59:46 -0036">.
~~~

This is what Red Hat's tzdata maintainer says about that change [2]:

> tl;dr: Ruby will have to fix its test suite.
>
> I expect that this comes from Ruby-internal test suite that expects Europe/Lisbon on some offset, and is surprised that it's actually a couple seconds off.  But that far back, time didn't use to be split to zones like today, and every location kept its own local time.  I think that most stamps in zoneinfo were calculated from GMT coordinates of the city (which itself is a somewhat fuzzy notion), and are corrected based on historical sources only retroactively, when someone gets to it, or when someone complains.  That's what happened here--Paul Eggert got to Lisbon.
> 
> It seems like Europe/Brussels might be a good choice for this sort of test, because it's local mean time has been based on an official document since 1997.

Could you please make the test case compatible with recent tzdata? Thanks.

[1] https://koji.fedoraproject.org/koji/buildinfo?buildID=576705
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1141775



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [ruby-core:65697] [ruby-trunk - Bug #10245] [Closed] TestTimeTZ#test_gen_Europe_Lisbon_111 fails with recent tzdata
       [not found] <redmine.issue-10245.20140916054806@ruby-lang.org>
                   ` (6 preceding siblings ...)
  2014-10-14  7:02 ` [ruby-core:65696] [ruby-trunk - Bug #10245] [Open] " v.ondruch
@ 2014-10-14  7:24 ` v.ondruch
  2014-10-15  7:25 ` [ruby-core:65722] [ruby-trunk - Bug #10245] " usa
  8 siblings, 0 replies; 9+ messages in thread
From: v.ondruch @ 2014-10-14  7:24 UTC (permalink / raw
  To: ruby-core

Issue #10245 has been updated by Vit Ondruch.

Status changed from Open to Closed

Ups, sorry. That was my fault. I forgot to remove one piece of workaround I applied before. Sorry for the noise.

----------------------------------------
Bug #10245: TestTimeTZ#test_gen_Europe_Lisbon_111 fails with recent tzdata
https://bugs.ruby-lang.org/issues/10245#change-49426

* Author: Vit Ondruch
* Status: Closed
* Priority: Normal
* Assignee: Akira Tanaka
* Category: 
* Target version: 
* ruby -v: ruby 2.2.0dev (2014-09-15 trunk 47594) [x86_64-linux]
* Backport: 2.0.0: REQUIRED, 2.1: DONE
----------------------------------------
In Fedora, tzdata were recently updated to tzdata-2014g-1.fc22 [1]. Since that update, one test case fails:

~~~
$ make test-all TESTS=test/ruby/test_time_tz.rb
...
snip
...

[ 79/123] TestTimeTZ#test_gen_Europe_Lisbon_111 = 0.00 s             
  1) Failure:
TestTimeTZ#test_gen_Europe_Lisbon_111 [/builddir/build/BUILD/ruby-2.2.0-r47594/test/ruby/test_time_tz.rb:250]:
TZ=Europe/Lisbon Time.utc(1912, 1, 1, 0, 36, 31).localtime.
<"1911-12-31 23:59:59 -0036"> expected but was
<"1911-12-31 23:59:46 -0036">.
~~~

This is what Red Hat's tzdata maintainer says about that change [2]:

> tl;dr: Ruby will have to fix its test suite.
>
> I expect that this comes from Ruby-internal test suite that expects Europe/Lisbon on some offset, and is surprised that it's actually a couple seconds off.  But that far back, time didn't use to be split to zones like today, and every location kept its own local time.  I think that most stamps in zoneinfo were calculated from GMT coordinates of the city (which itself is a somewhat fuzzy notion), and are corrected based on historical sources only retroactively, when someone gets to it, or when someone complains.  That's what happened here--Paul Eggert got to Lisbon.
> 
> It seems like Europe/Brussels might be a good choice for this sort of test, because it's local mean time has been based on an official document since 1997.

Could you please make the test case compatible with recent tzdata? Thanks.

[1] https://koji.fedoraproject.org/koji/buildinfo?buildID=576705
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1141775



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [ruby-core:65722] [ruby-trunk - Bug #10245] TestTimeTZ#test_gen_Europe_Lisbon_111 fails with recent tzdata
       [not found] <redmine.issue-10245.20140916054806@ruby-lang.org>
                   ` (7 preceding siblings ...)
  2014-10-14  7:24 ` [ruby-core:65697] [ruby-trunk - Bug #10245] [Closed] " v.ondruch
@ 2014-10-15  7:25 ` usa
  8 siblings, 0 replies; 9+ messages in thread
From: usa @ 2014-10-15  7:25 UTC (permalink / raw
  To: ruby-core

Issue #10245 has been updated by Usaku NAKAMURA.

Backport changed from 2.0.0: REQUIRED, 2.1: DONE to 2.0.0: DONE, 2.1: DONE

Backported into `ruby_2_0_0` at r47937.

----------------------------------------
Bug #10245: TestTimeTZ#test_gen_Europe_Lisbon_111 fails with recent tzdata
https://bugs.ruby-lang.org/issues/10245#change-49454

* Author: Vit Ondruch
* Status: Closed
* Priority: Normal
* Assignee: Akira Tanaka
* Category: 
* Target version: 
* ruby -v: ruby 2.2.0dev (2014-09-15 trunk 47594) [x86_64-linux]
* Backport: 2.0.0: DONE, 2.1: DONE
----------------------------------------
In Fedora, tzdata were recently updated to tzdata-2014g-1.fc22 [1]. Since that update, one test case fails:

~~~
$ make test-all TESTS=test/ruby/test_time_tz.rb
...
snip
...

[ 79/123] TestTimeTZ#test_gen_Europe_Lisbon_111 = 0.00 s             
  1) Failure:
TestTimeTZ#test_gen_Europe_Lisbon_111 [/builddir/build/BUILD/ruby-2.2.0-r47594/test/ruby/test_time_tz.rb:250]:
TZ=Europe/Lisbon Time.utc(1912, 1, 1, 0, 36, 31).localtime.
<"1911-12-31 23:59:59 -0036"> expected but was
<"1911-12-31 23:59:46 -0036">.
~~~

This is what Red Hat's tzdata maintainer says about that change [2]:

> tl;dr: Ruby will have to fix its test suite.
>
> I expect that this comes from Ruby-internal test suite that expects Europe/Lisbon on some offset, and is surprised that it's actually a couple seconds off.  But that far back, time didn't use to be split to zones like today, and every location kept its own local time.  I think that most stamps in zoneinfo were calculated from GMT coordinates of the city (which itself is a somewhat fuzzy notion), and are corrected based on historical sources only retroactively, when someone gets to it, or when someone complains.  That's what happened here--Paul Eggert got to Lisbon.
> 
> It seems like Europe/Brussels might be a good choice for this sort of test, because it's local mean time has been based on an official document since 1997.

Could you please make the test case compatible with recent tzdata? Thanks.

[1] https://koji.fedoraproject.org/koji/buildinfo?buildID=576705
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1141775



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2014-10-15  7:41 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <redmine.issue-10245.20140916054806@ruby-lang.org>
2014-09-16  5:48 ` [ruby-core:65058] [ruby-trunk - Bug #10245] [Open] TestTimeTZ#test_gen_Europe_Lisbon_111 fails with recent tzdata v.ondruch
2014-09-16  5:52 ` [ruby-core:65059] [ruby-trunk - Bug #10245] " v.ondruch
2014-09-22  3:12 ` [ruby-core:65199] [ruby-trunk - Bug #10245] [Closed] " akr
2014-09-22  3:14 ` [ruby-core:65201] [ruby-trunk - Bug #10245] " akr
2014-09-23 16:02 ` [ruby-core:65244] " nagachika00
2014-09-23 17:08 ` [ruby-core:65245] " nagachika00
2014-10-14  7:02 ` [ruby-core:65696] [ruby-trunk - Bug #10245] [Open] " v.ondruch
2014-10-14  7:24 ` [ruby-core:65697] [ruby-trunk - Bug #10245] [Closed] " v.ondruch
2014-10-15  7:25 ` [ruby-core:65722] [ruby-trunk - Bug #10245] " usa

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).