From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id EA37817D06B7 for ; Wed, 30 Jul 2014 01:54:14 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (smtp.nagaokaut.ac.jp [133.44.2.201]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id C2154B5D86B for ; Wed, 30 Jul 2014 01:32:01 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (localhost.nagaokaut.ac.jp [127.0.0.1]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id 01FC697A832 for ; Wed, 30 Jul 2014 01:32:03 +0900 (JST) X-Virus-Scanned: amavisd-new at nagaokaut.ac.jp Authentication-Results: funfun.nagaokaut.ac.jp (amavisd-new); dkim=fail (1024-bit key) reason="fail (message has been altered)" header.d=sendgrid.me Received: from funfun.nagaokaut.ac.jp ([127.0.0.1]) by funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iXhYwdbl29f9 for ; Wed, 30 Jul 2014 01:32:02 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id 4C7C797A820 for ; Wed, 30 Jul 2014 01:32:02 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id 4D55595243A for ; Wed, 30 Jul 2014 01:31:58 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id DDC5012043B; Wed, 30 Jul 2014 01:31:45 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o2.heroku.sendgrid.net (o2.heroku.sendgrid.net [67.228.50.55]) by neon.ruby-lang.org (Postfix) with ESMTPS id B79F8120411 for ; Wed, 30 Jul 2014 01:31:42 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=f6XAKORfixl7LYlK9Q0tPnLu5CE=; b=r322ydehutJdKU4tfN kj2Spuv0hVKabb3nzGAjY0Pr5xAUkEozwVx2voGpjvYIewHFTT1sNej07XtvYW5A yGm3HfwplGGVETub+PRuo4UN1eVykQREd/uwbxxp7XfRriHOJhri/5Zw00b16RQe MwKOLYBn/zulC9cSQ7CswJPf8= Received: by mf167.sendgrid.net with SMTP id mf167.35851.53D7CC61E 2014-07-29 16:31:29.339212274 +0000 UTC Received: from herokuapp.com (ec2-54-81-35-120.compute-1.amazonaws.com [54.81.35.120]) by ismtpd-018.iad1.sendgrid.net (SG) with ESMTP id 14782f62130.5182.489821 Tue, 29 Jul 2014 16:31:14 +0000 (GMT) Date: Tue, 29 Jul 2014 16:31:13 +0000 From: nobu@ruby-lang.org To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Redmine-MailingListIntegration-Message-Ids: 38277 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 10098 X-Redmine-Issue-Author: arrtchiu X-Redmine-Sender: nobu X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: OOF Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS7wQKcWGC8Rf0KZU0I2+psICOxhzeocElLOdpFE4gpOLOqKDi+LOG3XAvxvoDYc6Khu4ZY2NJGd1fRWjDChxVymEd9eNAkGYnOB6zWneClVYTbdLlJ4nLtfN3kzFW7Lxos= X-SendGrid-Contentd-ID: {"test_id":"1406651490"} X-ML-Name: ruby-core X-Mail-Count: 64120 Subject: [ruby-core:64120] [ruby-trunk - Feature #10098] [PATCH] Timing-safe string comparison for OpenSSL::HMAC X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #10098 has been updated by Nobuyoshi Nakada. `rb_tsafe_eql()` doesn't need to be `VALUE`, `int` is OK. Tests for timing-safeness are desirable, but it would be fragile by noise. ---------------------------------------- Feature #10098: [PATCH] Timing-safe string comparison for OpenSSL::HMAC https://bugs.ruby-lang.org/issues/10098#change-48129 * Author: Matt U * Status: Open * Priority: Normal * Assignee: * Category: ext/openssl * Target version: next minor ---------------------------------------- I could be totally wrong, but it seems the standard library doesn't provide a reliable way of comparing hashes in constant-time. * The docs for `OpenSSL::HMAC` encourage the use of `Digest#to_s` (see: http://ruby-doc.org/stdlib-2.1.0/libdoc/openssl/rdoc/OpenSSL/HMAC.html#method-c-new ) * Ruby's string comparison uses memcmp, which isn't timing safe (see: http://rxr.whitequark.org/mri/source/string.c#2382 ) With this patch I propose to add an additional method, `OpenSSL::HMAC#verify`, which takes a binary string with a digest and compares it against the computed hash. ---Files-------------------------------- hmac-timing.patch (2.5 KB) hmac-timing.patch (2.48 KB) tsafe_eql.patch (2.48 KB) tsafe_inline.patch (3.51 KB) -- https://bugs.ruby-lang.org/