From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id 3B69C17D9944 for ; Tue, 29 Jul 2014 10:47:52 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [133.44.2.201]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id AA7F8B5D8D1 for ; Tue, 29 Jul 2014 10:25:39 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (localhost.nagaokaut.ac.jp [127.0.0.1]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id D5C7E97A826 for ; Tue, 29 Jul 2014 10:25:40 +0900 (JST) X-Virus-Scanned: amavisd-new at nagaokaut.ac.jp Authentication-Results: funfun.nagaokaut.ac.jp (amavisd-new); dkim=fail (1024-bit key) reason="fail (message has been altered)" header.d=sendgrid.me Received: from funfun.nagaokaut.ac.jp ([127.0.0.1]) by funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aJSyeU4voE_S for ; Tue, 29 Jul 2014 10:25:40 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id 857C197A820 for ; Tue, 29 Jul 2014 10:25:40 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id 1AB13952446 for ; Tue, 29 Jul 2014 10:25:38 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 2B38912044C; Tue, 29 Jul 2014 10:25:31 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o10.shared.sendgrid.net (o10.shared.sendgrid.net [173.193.132.135]) by neon.ruby-lang.org (Postfix) with ESMTPS id 2266612041F for ; Tue, 29 Jul 2014 10:25:27 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=3eVR99Fn5U99AmDTNw2P12Rg7Ew=; b=xi/Z1KIIiXFAFySaCr lZXn1PqipIUMhI6+tbT4iH5dMhMxEBJb2bxSamuX0rQGT4ucK0UGaiqUJ9h6AjPC e5WCPW6CW5fM+DO0v7oZFL+725kR4sxJKq7LRmL+c+mEfb4ekpQRfw523HiMt9nM V/fGVJudrSB5ygNUiEV5XXVeQ= Received: by mf148.sendgrid.net with SMTP id mf148.32716.53D6F8031C 2014-07-29 01:25:23.373883853 +0000 UTC Received: from herokuapp.com (ec2-54-90-18-226.compute-1.amazonaws.com [54.90.18.226]) by ismtpd-029.iad1.sendgrid.net (SG) with ESMTP id 1477fb889ab.2231.456ce4 Tue, 29 Jul 2014 01:25:06 +0000 (GMT) Date: Tue, 29 Jul 2014 01:25:05 +0000 From: nobu@ruby-lang.org To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Redmine-MailingListIntegration-Message-Ids: 38264 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 10098 X-Redmine-Issue-Author: arrtchiu X-Redmine-Sender: nobu X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: OOF Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS4fr8rLR6tirH9NyR64/KON76E0GpE0RcaOoiACZfCYw45/XGe+DY++eCQ/cc7Qv8On+2+3AdW5psFKa8VDJiRoOYBRX2O6KGwmw1zhvYtJU/L9Oa263MFzLquczfqyG2g= X-SendGrid-Contentd-ID: {"test_id":"1406597123"} X-ML-Name: ruby-core X-Mail-Count: 64106 Subject: [ruby-core:64106] [ruby-trunk - Feature #10098] [PATCH] Timing-safe string comparison for OpenSSL::HMAC X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #10098 has been updated by Nobuyoshi Nakada. * Indent style mismatch * Should try to convert the argument with `StringValue()` * Why HMAC only? Other digests don't need it? * Probably we should provide timing-safe binary compare function? ---------------------------------------- Feature #10098: [PATCH] Timing-safe string comparison for OpenSSL::HMAC https://bugs.ruby-lang.org/issues/10098#change-48117 * Author: Matt U * Status: Open * Priority: Normal * Assignee: * Category: ext/openssl * Target version: next minor ---------------------------------------- I could be totally wrong, but it seems the standard library doesn't provide a reliable way of comparing hashes in constant-time. * The docs for `OpenSSL::HMAC` encourage the use of `Digest#to_s` (see: http://ruby-doc.org/stdlib-2.1.0/libdoc/openssl/rdoc/OpenSSL/HMAC.html#method-c-new ) * Ruby's string comparison uses memcmp, which isn't timing safe (see: http://rxr.whitequark.org/mri/source/string.c#2382 ) With this patch I propose to add an additional method, `OpenSSL::HMAC#verify`, which takes a binary string with a digest and compares it against the computed hash. ---Files-------------------------------- hmac-timing.patch (2.5 KB) hmac-timing.patch (2.48 KB) -- https://bugs.ruby-lang.org/