* [ruby-core:61754] [ruby-trunk - Bug #9688] [Open] Ruby's child process inherits parent's sockets (mswin)
[not found] <redmine.issue-9688.20140329151623@ruby-lang.org>
@ 2014-03-29 15:16 ` artonx
2014-03-30 14:38 ` [ruby-core:61764] [ruby-trunk - Bug #9688] " usa
` (4 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: artonx @ 2014-03-29 15:16 UTC (permalink / raw
To: ruby-core
Issue #9688 has been reported by Akio Tajima.
----------------------------------------
Bug #9688: Ruby's child process inherits parent's sockets (mswin)
https://bugs.ruby-lang.org/issues/9688
* Author: Akio Tajima
* Status: Open
* Priority: Normal
* Assignee: Usaku NAKAMURA
* Category: platform/windows
* Target version: current: 2.2.0
* ruby -v: ruby 2.1.1p76 (2014-02-24 revision 45161) [i386-mswin32_100]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN
----------------------------------------
When Ruby application creates child process, sockets are inherited from the parent process.
This causes severe troubles.
In my situation, I have some web services using WEBrick and Sinatra. They invoke child process as a batch file using kernel.system method. And in the batch file I launch some long running applications by 'start'.
If these type of long running applications stay in running state, I never restart the services because the children grab server sockets while running. What is worse that Windows never report EADDRINUSE so I have no clue to judge its condition. Indeed 'netstat /b' reports the port is occupied by System not the child app.
Below is the reproduction script.
~~~
require 'socket'
require 'timeout'
exit unless RUBY_PLATFORM =~ /mswin/
BAT = "#{ENV['TMP']}#{File::SEPARATOR}test_inheritsock.bat"
File.open(BAT, 'w') do |fout|
fout.puts 'start ruby -e "sleep(10)"'
end
port = nil
TCPServer.open(0) do |gs|
port = gs.addr[1]
system(BAT)
end
File.delete BAT
gs = TCPServer.open(port)
running = true
client = false
begin
timeout(20) do
while running
Thread.start do
s = gs.accept
s.gets
s.close
running = false
end
unless client
client = true
Thread.start do
TCPSocket.open('localhost', port) do |sock|
sock.puts('')
end
end
else
sleep(1)
end
end
end
puts 'no problem'
rescue Timeout::Error
puts 'failed'
end
gs.close
~~~
The second opend TCPServer can not receive a connection request.
Unak already made no inheritance patch (https://gist.github.com/unak/9825743) and I tested it with Windowds7(x86) and Windows8.1(x64) and in both environments the above script runs completely.
So I wonder if the patch is applied to the trunk.
Thanks in advance.
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [ruby-core:61764] [ruby-trunk - Bug #9688] Ruby's child process inherits parent's sockets (mswin)
[not found] <redmine.issue-9688.20140329151623@ruby-lang.org>
2014-03-29 15:16 ` [ruby-core:61754] [ruby-trunk - Bug #9688] [Open] Ruby's child process inherits parent's sockets (mswin) artonx
@ 2014-03-30 14:38 ` usa
2014-03-30 14:43 ` [ruby-core:61765] [ruby-trunk - Bug #9688] [Closed] " usa
` (3 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: usa @ 2014-03-30 14:38 UTC (permalink / raw
To: ruby-core
Issue #9688 has been updated by Usaku NAKAMURA.
Thank you for testing my patch!
----------------------------------------
Bug #9688: Ruby's child process inherits parent's sockets (mswin)
https://bugs.ruby-lang.org/issues/9688#change-45998
* Author: Akio Tajima
* Status: Open
* Priority: Normal
* Assignee: Usaku NAKAMURA
* Category: platform/windows
* Target version: current: 2.2.0
* ruby -v: ruby 2.1.1p76 (2014-02-24 revision 45161) [i386-mswin32_100]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN
----------------------------------------
When Ruby application creates child process, sockets are inherited from the parent process.
This causes severe troubles.
In my situation, I have some web services using WEBrick and Sinatra. They invoke child process as a batch file using kernel.system method. And in the batch file I launch some long running applications by 'start'.
If these type of long running applications stay in running state, I never restart the services because the children grab server sockets while running. What is worse that Windows never report EADDRINUSE so I have no clue to judge its condition. Indeed 'netstat /b' reports the port is occupied by System not the child app.
Below is the reproduction script.
~~~
require 'socket'
require 'timeout'
exit unless RUBY_PLATFORM =~ /mswin/
BAT = "#{ENV['TMP']}#{File::SEPARATOR}test_inheritsock.bat"
File.open(BAT, 'w') do |fout|
fout.puts 'start ruby -e "sleep(10)"'
end
port = nil
TCPServer.open(0) do |gs|
port = gs.addr[1]
system(BAT)
end
File.delete BAT
gs = TCPServer.open(port)
running = true
client = false
begin
timeout(20) do
while running
Thread.start do
s = gs.accept
s.gets
s.close
running = false
end
unless client
client = true
Thread.start do
TCPSocket.open('localhost', port) do |sock|
sock.puts('')
end
end
else
sleep(1)
end
end
end
puts 'no problem'
rescue Timeout::Error
puts 'failed'
end
gs.close
~~~
The second opend TCPServer can not receive a connection request.
Unak already made no inheritance patch (https://gist.github.com/unak/9825743) and I tested it with Windowds7(x86) and Windows8.1(x64) and in both environments the above script runs completely.
So I wonder if the patch is applied to the trunk.
Thanks in advance.
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [ruby-core:61765] [ruby-trunk - Bug #9688] [Closed] Ruby's child process inherits parent's sockets (mswin)
[not found] <redmine.issue-9688.20140329151623@ruby-lang.org>
2014-03-29 15:16 ` [ruby-core:61754] [ruby-trunk - Bug #9688] [Open] Ruby's child process inherits parent's sockets (mswin) artonx
2014-03-30 14:38 ` [ruby-core:61764] [ruby-trunk - Bug #9688] " usa
@ 2014-03-30 14:43 ` usa
2014-03-30 14:43 ` [ruby-core:61766] [ruby-trunk - Bug #9688] " usa
` (2 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: usa @ 2014-03-30 14:43 UTC (permalink / raw
To: ruby-core
Issue #9688 has been updated by Usaku NAKAMURA.
Status changed from Open to Closed
% Done changed from 0 to 100
Applied in changeset r45471.
----------
* win32/win32.c (rb_w32_accept, open_ifs_socket, socketpair_internal):
reset inherit flag of socket to avoid unintentional inheritance of
socket. note that the return value of SetHandleInformation() is not
verified intentionally because old Windows may return an error.
[Bug #9688] [ruby-core:61754]
----------------------------------------
Bug #9688: Ruby's child process inherits parent's sockets (mswin)
https://bugs.ruby-lang.org/issues/9688#change-45999
* Author: Akio Tajima
* Status: Closed
* Priority: Normal
* Assignee: Usaku NAKAMURA
* Category: platform/windows
* Target version: current: 2.2.0
* ruby -v: ruby 2.1.1p76 (2014-02-24 revision 45161) [i386-mswin32_100]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN
----------------------------------------
When Ruby application creates child process, sockets are inherited from the parent process.
This causes severe troubles.
In my situation, I have some web services using WEBrick and Sinatra. They invoke child process as a batch file using kernel.system method. And in the batch file I launch some long running applications by 'start'.
If these type of long running applications stay in running state, I never restart the services because the children grab server sockets while running. What is worse that Windows never report EADDRINUSE so I have no clue to judge its condition. Indeed 'netstat /b' reports the port is occupied by System not the child app.
Below is the reproduction script.
~~~
require 'socket'
require 'timeout'
exit unless RUBY_PLATFORM =~ /mswin/
BAT = "#{ENV['TMP']}#{File::SEPARATOR}test_inheritsock.bat"
File.open(BAT, 'w') do |fout|
fout.puts 'start ruby -e "sleep(10)"'
end
port = nil
TCPServer.open(0) do |gs|
port = gs.addr[1]
system(BAT)
end
File.delete BAT
gs = TCPServer.open(port)
running = true
client = false
begin
timeout(20) do
while running
Thread.start do
s = gs.accept
s.gets
s.close
running = false
end
unless client
client = true
Thread.start do
TCPSocket.open('localhost', port) do |sock|
sock.puts('')
end
end
else
sleep(1)
end
end
end
puts 'no problem'
rescue Timeout::Error
puts 'failed'
end
gs.close
~~~
The second opend TCPServer can not receive a connection request.
Unak already made no inheritance patch (https://gist.github.com/unak/9825743) and I tested it with Windowds7(x86) and Windows8.1(x64) and in both environments the above script runs completely.
So I wonder if the patch is applied to the trunk.
Thanks in advance.
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [ruby-core:61766] [ruby-trunk - Bug #9688] Ruby's child process inherits parent's sockets (mswin)
[not found] <redmine.issue-9688.20140329151623@ruby-lang.org>
` (2 preceding siblings ...)
2014-03-30 14:43 ` [ruby-core:61765] [ruby-trunk - Bug #9688] [Closed] " usa
@ 2014-03-30 14:43 ` usa
2014-04-30 7:38 ` [ruby-core:62247] " usa
2014-06-01 17:21 ` [ruby-core:62890] " nagachika00
5 siblings, 0 replies; 6+ messages in thread
From: usa @ 2014-03-30 14:43 UTC (permalink / raw
To: ruby-core
Issue #9688 has been updated by Usaku NAKAMURA.
Backport changed from 2.0.0: UNKNOWN, 2.1: UNKNOWN to 2.0.0: REQUIRED, 2.1: REQUIRED
----------------------------------------
Bug #9688: Ruby's child process inherits parent's sockets (mswin)
https://bugs.ruby-lang.org/issues/9688#change-46000
* Author: Akio Tajima
* Status: Closed
* Priority: Normal
* Assignee: Usaku NAKAMURA
* Category: platform/windows
* Target version: current: 2.2.0
* ruby -v: ruby 2.1.1p76 (2014-02-24 revision 45161) [i386-mswin32_100]
* Backport: 2.0.0: REQUIRED, 2.1: REQUIRED
----------------------------------------
When Ruby application creates child process, sockets are inherited from the parent process.
This causes severe troubles.
In my situation, I have some web services using WEBrick and Sinatra. They invoke child process as a batch file using kernel.system method. And in the batch file I launch some long running applications by 'start'.
If these type of long running applications stay in running state, I never restart the services because the children grab server sockets while running. What is worse that Windows never report EADDRINUSE so I have no clue to judge its condition. Indeed 'netstat /b' reports the port is occupied by System not the child app.
Below is the reproduction script.
~~~
require 'socket'
require 'timeout'
exit unless RUBY_PLATFORM =~ /mswin/
BAT = "#{ENV['TMP']}#{File::SEPARATOR}test_inheritsock.bat"
File.open(BAT, 'w') do |fout|
fout.puts 'start ruby -e "sleep(10)"'
end
port = nil
TCPServer.open(0) do |gs|
port = gs.addr[1]
system(BAT)
end
File.delete BAT
gs = TCPServer.open(port)
running = true
client = false
begin
timeout(20) do
while running
Thread.start do
s = gs.accept
s.gets
s.close
running = false
end
unless client
client = true
Thread.start do
TCPSocket.open('localhost', port) do |sock|
sock.puts('')
end
end
else
sleep(1)
end
end
end
puts 'no problem'
rescue Timeout::Error
puts 'failed'
end
gs.close
~~~
The second opend TCPServer can not receive a connection request.
Unak already made no inheritance patch (https://gist.github.com/unak/9825743) and I tested it with Windowds7(x86) and Windows8.1(x64) and in both environments the above script runs completely.
So I wonder if the patch is applied to the trunk.
Thanks in advance.
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [ruby-core:62247] [ruby-trunk - Bug #9688] Ruby's child process inherits parent's sockets (mswin)
[not found] <redmine.issue-9688.20140329151623@ruby-lang.org>
` (3 preceding siblings ...)
2014-03-30 14:43 ` [ruby-core:61766] [ruby-trunk - Bug #9688] " usa
@ 2014-04-30 7:38 ` usa
2014-06-01 17:21 ` [ruby-core:62890] " nagachika00
5 siblings, 0 replies; 6+ messages in thread
From: usa @ 2014-04-30 7:38 UTC (permalink / raw
To: ruby-core
Issue #9688 has been updated by Usaku NAKAMURA.
Backport changed from 2.0.0: REQUIRED, 2.1: REQUIRED to 2.0.0: DONE, 2.1: REQUIRED
backported into ruby_2_0_0 at r45753.
----------------------------------------
Bug #9688: Ruby's child process inherits parent's sockets (mswin)
https://bugs.ruby-lang.org/issues/9688#change-46399
* Author: Akio Tajima
* Status: Closed
* Priority: Normal
* Assignee: Usaku NAKAMURA
* Category: platform/windows
* Target version: current: 2.2.0
* ruby -v: ruby 2.1.1p76 (2014-02-24 revision 45161) [i386-mswin32_100]
* Backport: 2.0.0: DONE, 2.1: REQUIRED
----------------------------------------
When Ruby application creates child process, sockets are inherited from the parent process.
This causes severe troubles.
In my situation, I have some web services using WEBrick and Sinatra. They invoke child process as a batch file using kernel.system method. And in the batch file I launch some long running applications by 'start'.
If these type of long running applications stay in running state, I never restart the services because the children grab server sockets while running. What is worse that Windows never report EADDRINUSE so I have no clue to judge its condition. Indeed 'netstat /b' reports the port is occupied by System not the child app.
Below is the reproduction script.
~~~
require 'socket'
require 'timeout'
exit unless RUBY_PLATFORM =~ /mswin/
BAT = "#{ENV['TMP']}#{File::SEPARATOR}test_inheritsock.bat"
File.open(BAT, 'w') do |fout|
fout.puts 'start ruby -e "sleep(10)"'
end
port = nil
TCPServer.open(0) do |gs|
port = gs.addr[1]
system(BAT)
end
File.delete BAT
gs = TCPServer.open(port)
running = true
client = false
begin
timeout(20) do
while running
Thread.start do
s = gs.accept
s.gets
s.close
running = false
end
unless client
client = true
Thread.start do
TCPSocket.open('localhost', port) do |sock|
sock.puts('')
end
end
else
sleep(1)
end
end
end
puts 'no problem'
rescue Timeout::Error
puts 'failed'
end
gs.close
~~~
The second opend TCPServer can not receive a connection request.
Unak already made no inheritance patch (https://gist.github.com/unak/9825743) and I tested it with Windowds7(x86) and Windows8.1(x64) and in both environments the above script runs completely.
So I wonder if the patch is applied to the trunk.
Thanks in advance.
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [ruby-core:62890] [ruby-trunk - Bug #9688] Ruby's child process inherits parent's sockets (mswin)
[not found] <redmine.issue-9688.20140329151623@ruby-lang.org>
` (4 preceding siblings ...)
2014-04-30 7:38 ` [ruby-core:62247] " usa
@ 2014-06-01 17:21 ` nagachika00
5 siblings, 0 replies; 6+ messages in thread
From: nagachika00 @ 2014-06-01 17:21 UTC (permalink / raw
To: ruby-core
Issue #9688 has been updated by Tomoyuki Chikanaga.
Backport changed from 2.0.0: DONE, 2.1: REQUIRED to 2.0.0: DONE, 2.1: DONE
Backported into `ruby_2_1` branch at r46305.
----------------------------------------
Bug #9688: Ruby's child process inherits parent's sockets (mswin)
https://bugs.ruby-lang.org/issues/9688#change-46999
* Author: Akio Tajima
* Status: Closed
* Priority: Normal
* Assignee: Usaku NAKAMURA
* Category: platform/windows
* Target version: current: 2.2.0
* ruby -v: ruby 2.1.1p76 (2014-02-24 revision 45161) [i386-mswin32_100]
* Backport: 2.0.0: DONE, 2.1: DONE
----------------------------------------
When Ruby application creates child process, sockets are inherited from the parent process.
This causes severe troubles.
In my situation, I have some web services using WEBrick and Sinatra. They invoke child process as a batch file using kernel.system method. And in the batch file I launch some long running applications by 'start'.
If these type of long running applications stay in running state, I never restart the services because the children grab server sockets while running. What is worse that Windows never report EADDRINUSE so I have no clue to judge its condition. Indeed 'netstat /b' reports the port is occupied by System not the child app.
Below is the reproduction script.
~~~
require 'socket'
require 'timeout'
exit unless RUBY_PLATFORM =~ /mswin/
BAT = "#{ENV['TMP']}#{File::SEPARATOR}test_inheritsock.bat"
File.open(BAT, 'w') do |fout|
fout.puts 'start ruby -e "sleep(10)"'
end
port = nil
TCPServer.open(0) do |gs|
port = gs.addr[1]
system(BAT)
end
File.delete BAT
gs = TCPServer.open(port)
running = true
client = false
begin
timeout(20) do
while running
Thread.start do
s = gs.accept
s.gets
s.close
running = false
end
unless client
client = true
Thread.start do
TCPSocket.open('localhost', port) do |sock|
sock.puts('')
end
end
else
sleep(1)
end
end
end
puts 'no problem'
rescue Timeout::Error
puts 'failed'
end
gs.close
~~~
The second opend TCPServer can not receive a connection request.
Unak already made no inheritance patch (https://gist.github.com/unak/9825743) and I tested it with Windowds7(x86) and Windows8.1(x64) and in both environments the above script runs completely.
So I wonder if the patch is applied to the trunk.
Thanks in advance.
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-06-02 1:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <redmine.issue-9688.20140329151623@ruby-lang.org>
2014-03-29 15:16 ` [ruby-core:61754] [ruby-trunk - Bug #9688] [Open] Ruby's child process inherits parent's sockets (mswin) artonx
2014-03-30 14:38 ` [ruby-core:61764] [ruby-trunk - Bug #9688] " usa
2014-03-30 14:43 ` [ruby-core:61765] [ruby-trunk - Bug #9688] [Closed] " usa
2014-03-30 14:43 ` [ruby-core:61766] [ruby-trunk - Bug #9688] " usa
2014-04-30 7:38 ` [ruby-core:62247] " usa
2014-06-01 17:21 ` [ruby-core:62890] " nagachika00
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).