[ruby-core:61584] [ruby-trunk - Bug #9652] [Open] Marshal doesn't dump/load Time#zone correctly with too many time object

[ruby-core:61584] [ruby-trunk - Bug #9652] [Open] Marshal doesn't dump/load Time#zone correctly with too many time object

[cantin2010]

Issue #9652 has been reported by Cantin Xu.

----------------------------------------
Bug #9652: Marshal doesn't dump/load Time#zone correctly with too many time object
https://bugs.ruby-lang.org/issues/9652

* Author: Cantin Xu
* Status: Open
* Priority: Normal
* Assignee: 
* Category: core
* Target version: current: 2.2.0
* ruby -v: ruby 2.1.1p76 (2014-02-24 revision 45161) [x86_64-darwin13.0]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN
----------------------------------------
Hi, there

I wrote a script to test Marshal dump/load with many time object ( see attachment ).

basic idea is:
1) A is container of time,  it contains 100,000 time instance (all Time.now).
2) dump/load A by using Marshal, expected behavior is all the time zone must same as Time.now.zone

but I get different things or unreadable code in some Time instance by calling time.zone.
mostly it's "UTF-8'.

env:  Mac 10.9.2, ruby: ruby 2.1.1-p76

PS: it's fine while A contain 10,000 time instance

---Files--------------------------------
timezone_test.rb (409 Bytes)


-- 
https://bugs.ruby-lang.org/

[ruby-core:61585] Re: [ruby-trunk - Bug #9652] [Open] Marshal doesn't dump/load Time#zone correctly with too many time object

[Eric Wong]

I cannot reproduce the problem here, however it could be the
lack of reference for GC.

Can you add this rb_ivar_set call?

--- a/time.c
+++ b/time.c
@@ -4828,6 +4828,7 @@ end_submicro: ;
     }
     if (!NIL_P(zone)) {
 	tobj->vtm.zone = RSTRING_PTR(zone);
+	rb_ivar_set(str, id_zone, zone);
     }
 
     return time;


Also at: git://80x24.org/ruby.git time-load-zone
http://bogomips.org/ruby.git/patch?id=9418df96145

[ruby-core:61586] [ruby-trunk - Bug #9652] Marshal doesn't dump/load Time#zone correctly with too many time object

[normalperson]

Issue #9652 has been updated by Eric Wong.


 I cannot reproduce the problem here, however it could be the
 lack of reference for GC.
 
 Can you add this rb_ivar_set call?
 
 --- a/time.c
 +++ b/time.c
 @@ -4828,6 +4828,7 @@ end_submicro: ;
      }
      if (!NIL_P(zone)) {
  	tobj->vtm.zone = RSTRING_PTR(zone);
 +	rb_ivar_set(str, id_zone, zone);
      }
  
      return time;
 
 
 Also at: git://80x24.org/ruby.git time-load-zone
 http://bogomips.org/ruby.git/patch?id=9418df96145

----------------------------------------
Bug #9652: Marshal doesn't dump/load Time#zone correctly with too many time object
https://bugs.ruby-lang.org/issues/9652#change-45866

* Author: Cantin Xu
* Status: Open
* Priority: Normal
* Assignee: 
* Category: core
* Target version: current: 2.2.0
* ruby -v: ruby 2.1.1p76 (2014-02-24 revision 45161) [x86_64-darwin13.0]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN
----------------------------------------
Hi, there

I wrote a script to test Marshal dump/load with many time object ( see attachment ).

basic idea is:
1) A is container of time,  it contains 100,000 time instance (all Time.now).
2) dump/load A by using Marshal, expected behavior is all the time zone must same as Time.now.zone

but I get different things or unreadable code in some Time instance by calling time.zone.
mostly it's "UTF-8'.

env:  Mac 10.9.2, ruby: ruby 2.1.1-p76

PS: it's fine while A contain 10,000 time instance

---Files--------------------------------
timezone_test.rb (409 Bytes)


-- 
https://bugs.ruby-lang.org/

[ruby-core:61587] [ruby-trunk - Bug #9652] Marshal doesn't dump/load Time#zone correctly with too many time object

[nobu]

Issue #9652 has been updated by Nobuyoshi Nakada.


Seems better to call `rb_str_new_frozen()` before setting `vtm.zone`.

----------------------------------------
Bug #9652: Marshal doesn't dump/load Time#zone correctly with too many time object
https://bugs.ruby-lang.org/issues/9652#change-45867

* Author: Cantin Xu
* Status: Open
* Priority: Normal
* Assignee: 
* Category: core
* Target version: current: 2.2.0
* ruby -v: ruby 2.1.1p76 (2014-02-24 revision 45161) [x86_64-darwin13.0]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN
----------------------------------------
Hi, there

I wrote a script to test Marshal dump/load with many time object ( see attachment ).

basic idea is:
1) A is container of time,  it contains 100,000 time instance (all Time.now).
2) dump/load A by using Marshal, expected behavior is all the time zone must same as Time.now.zone

but I get different things or unreadable code in some Time instance by calling time.zone.
mostly it's "UTF-8'.

env:  Mac 10.9.2, ruby: ruby 2.1.1-p76

PS: it's fine while A contain 10,000 time instance

---Files--------------------------------
timezone_test.rb (409 Bytes)


-- 
https://bugs.ruby-lang.org/

[ruby-core:61588] Re: [ruby-trunk - Bug #9652] Marshal doesn't dump/load Time#zone correctly with too many time object

[Eric Wong]

nobu@ruby-lang.org wrote:
> Seems better to call `rb_str_new_frozen()` before setting `vtm.zone`.

OK.  Though rb_fstring() might be better because time objects
with identical zones are common.

[ruby-core:61589] [ruby-trunk - Bug #9652] Marshal doesn't dump/load Time#zone correctly with too many time object

[normalperson]

Issue #9652 has been updated by Eric Wong.


 nobu@ruby-lang.org wrote:
 > Seems better to call `rb_str_new_frozen()` before setting `vtm.zone`.
 
 OK.  Though rb_fstring() might be better because time objects
 with identical zones are common.

----------------------------------------
Bug #9652: Marshal doesn't dump/load Time#zone correctly with too many time object
https://bugs.ruby-lang.org/issues/9652#change-45868

* Author: Cantin Xu
* Status: Open
* Priority: Normal
* Assignee: 
* Category: core
* Target version: current: 2.2.0
* ruby -v: ruby 2.1.1p76 (2014-02-24 revision 45161) [x86_64-darwin13.0]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN
----------------------------------------
Hi, there

I wrote a script to test Marshal dump/load with many time object ( see attachment ).

basic idea is:
1) A is container of time,  it contains 100,000 time instance (all Time.now).
2) dump/load A by using Marshal, expected behavior is all the time zone must same as Time.now.zone

but I get different things or unreadable code in some Time instance by calling time.zone.
mostly it's "UTF-8'.

env:  Mac 10.9.2, ruby: ruby 2.1.1-p76

PS: it's fine while A contain 10,000 time instance

---Files--------------------------------
timezone_test.rb (409 Bytes)


-- 
https://bugs.ruby-lang.org/

[ruby-core:61590] Re: [ruby-trunk - Bug #9652] Marshal doesn't dump/load Time#zone correctly with too many time object

[Eric Wong]

normalperson@yhbt.net wrote:
>  nobu@ruby-lang.org wrote:
>  > Seems better to call `rb_str_new_frozen()` before setting `vtm.zone`.
>  
>  OK.  Though rb_fstring() might be better because time objects
>  with identical zones are common.

Or not, don't want potential untrusted sources populating the
fstring table; either.  Will commit w/ str_new_frozen + test case.

[ruby-core:61591] [ruby-trunk - Bug #9652] Marshal doesn't dump/load Time#zone correctly with too many time object

[normalperson]

Issue #9652 has been updated by Eric Wong.


 normalperson@yhbt.net wrote:
 >  nobu@ruby-lang.org wrote:
 >  > Seems better to call `rb_str_new_frozen()` before setting `vtm.zone`.
 >  
 >  OK.  Though rb_fstring() might be better because time objects
 >  with identical zones are common.
 
 Or not, don't want potential untrusted sources populating the
 fstring table; either.  Will commit w/ str_new_frozen + test case.

----------------------------------------
Bug #9652: Marshal doesn't dump/load Time#zone correctly with too many time object
https://bugs.ruby-lang.org/issues/9652#change-45869

* Author: Cantin Xu
* Status: Open
* Priority: Normal
* Assignee: 
* Category: core
* Target version: current: 2.2.0
* ruby -v: ruby 2.1.1p76 (2014-02-24 revision 45161) [x86_64-darwin13.0]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN
----------------------------------------
Hi, there

I wrote a script to test Marshal dump/load with many time object ( see attachment ).

basic idea is:
1) A is container of time,  it contains 100,000 time instance (all Time.now).
2) dump/load A by using Marshal, expected behavior is all the time zone must same as Time.now.zone

but I get different things or unreadable code in some Time instance by calling time.zone.
mostly it's "UTF-8'.

env:  Mac 10.9.2, ruby: ruby 2.1.1-p76

PS: it's fine while A contain 10,000 time instance

---Files--------------------------------
timezone_test.rb (409 Bytes)


-- 
https://bugs.ruby-lang.org/

[ruby-core:61592] Re: [ruby-trunk - Bug #9652] Marshal doesn't dump/load Time#zone correctly with too many time object

[Eric Wong]

Thanks all, committed as r45364
Sorry my original patch set the ivar on the wrong object :x
But fortunately I was able to reproduce the GC error and test
for it.

[ruby-core:61594] [ruby-trunk - Bug #9652] Marshal doesn't dump/load Time#zone correctly with too many time object

[normalperson]

Issue #9652 has been updated by Eric Wong.


 Thanks all, committed as r45364
 Sorry my original patch set the ivar on the wrong object :x
 But fortunately I was able to reproduce the GC error and test
 for it.

----------------------------------------
Bug #9652: Marshal doesn't dump/load Time#zone correctly with too many time object
https://bugs.ruby-lang.org/issues/9652#change-45871

* Author: Cantin Xu
* Status: Closed
* Priority: Normal
* Assignee: 
* Category: core
* Target version: current: 2.2.0
* ruby -v: ruby 2.1.1p76 (2014-02-24 revision 45161) [x86_64-darwin13.0]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN
----------------------------------------
Hi, there

I wrote a script to test Marshal dump/load with many time object ( see attachment ).

basic idea is:
1) A is container of time,  it contains 100,000 time instance (all Time.now).
2) dump/load A by using Marshal, expected behavior is all the time zone must same as Time.now.zone

but I get different things or unreadable code in some Time instance by calling time.zone.
mostly it's "UTF-8'.

env:  Mac 10.9.2, ruby: ruby 2.1.1-p76

PS: it's fine while A contain 10,000 time instance

---Files--------------------------------
timezone_test.rb (409 Bytes)


-- 
https://bugs.ruby-lang.org/

[ruby-core:61596] [ruby-trunk - Bug #9652] Marshal doesn't dump/load Time#zone correctly with too many time object

[nagachika00]

Issue #9652 has been updated by Tomoyuki Chikanaga.

Backport changed from 2.0.0: UNKNOWN, 2.1: UNKNOWN to 2.0.0: REQUIRED, 2.1: REQUIRED

----------------------------------------
Bug #9652: Marshal doesn't dump/load Time#zone correctly with too many time object
https://bugs.ruby-lang.org/issues/9652#change-45873

* Author: Cantin Xu
* Status: Closed
* Priority: Normal
* Assignee: 
* Category: core
* Target version: current: 2.2.0
* ruby -v: ruby 2.1.1p76 (2014-02-24 revision 45161) [x86_64-darwin13.0]
* Backport: 2.0.0: REQUIRED, 2.1: REQUIRED
----------------------------------------
Hi, there

I wrote a script to test Marshal dump/load with many time object ( see attachment ).

basic idea is:
1) A is container of time,  it contains 100,000 time instance (all Time.now).
2) dump/load A by using Marshal, expected behavior is all the time zone must same as Time.now.zone

but I get different things or unreadable code in some Time instance by calling time.zone.
mostly it's "UTF-8'.

env:  Mac 10.9.2, ruby: ruby 2.1.1-p76

PS: it's fine while A contain 10,000 time instance

---Files--------------------------------
timezone_test.rb (409 Bytes)


-- 
https://bugs.ruby-lang.org/

[ruby-core:61671] [ruby-trunk - Bug #9652] Marshal doesn't dump/load Time#zone correctly with too many time object

[usa]

Issue #9652 has been updated by Usaku NAKAMURA.


r45364 introduced a test failure on Windows, and r45395 didn't fix it.
After all, there is no portabl time zone name, I guess.
Doesn't someone think of a better test?

----------------------------------------
Bug #9652: Marshal doesn't dump/load Time#zone correctly with too many time object
https://bugs.ruby-lang.org/issues/9652#change-45925

* Author: Cantin Xu
* Status: Closed
* Priority: Normal
* Assignee: 
* Category: core
* Target version: current: 2.2.0
* ruby -v: ruby 2.1.1p76 (2014-02-24 revision 45161) [x86_64-darwin13.0]
* Backport: 2.0.0: REQUIRED, 2.1: REQUIRED
----------------------------------------
Hi, there

I wrote a script to test Marshal dump/load with many time object ( see attachment ).

basic idea is:
1) A is container of time,  it contains 100,000 time instance (all Time.now).
2) dump/load A by using Marshal, expected behavior is all the time zone must same as Time.now.zone

but I get different things or unreadable code in some Time instance by calling time.zone.
mostly it's "UTF-8'.

env:  Mac 10.9.2, ruby: ruby 2.1.1-p76

PS: it's fine while A contain 10,000 time instance

---Files--------------------------------
timezone_test.rb (409 Bytes)


-- 
https://bugs.ruby-lang.org/

[ruby-core:61679] Re: [ruby-trunk - Bug #9652] Marshal doesn't dump/load Time#zone correctly with too many time object

[Eric Wong]

usa@garbagecollect.jp wrote:
> r45364 introduced a test failure on Windows, and r45395 didn't fix it.
> After all, there is no portabl time zone name, I guess.
> Doesn't someone think of a better test?

Sorry about the portability problems. r45403 works for me on a GNU system.
If all else fails, maybe only enable TZ setting tests on a few platforms
like test/ruby/test_time_tz.rb does.

[ruby-core:61680] [ruby-trunk - Bug #9652] Marshal doesn't dump/load Time#zone correctly with too many time object

[normalperson]

Issue #9652 has been updated by Eric Wong.


 usa@garbagecollect.jp wrote:
 > r45364 introduced a test failure on Windows, and r45395 didn't fix it.
 > After all, there is no portabl time zone name, I guess.
 > Doesn't someone think of a better test?
 
 Sorry about the portability problems. r45403 works for me on a GNU system.
 If all else fails, maybe only enable TZ setting tests on a few platforms
 like test/ruby/test_time_tz.rb does.

----------------------------------------
Bug #9652: Marshal doesn't dump/load Time#zone correctly with too many time object
https://bugs.ruby-lang.org/issues/9652#change-45932

* Author: Cantin Xu
* Status: Closed
* Priority: Normal
* Assignee: 
* Category: core
* Target version: current: 2.2.0
* ruby -v: ruby 2.1.1p76 (2014-02-24 revision 45161) [x86_64-darwin13.0]
* Backport: 2.0.0: REQUIRED, 2.1: REQUIRED
----------------------------------------
Hi, there

I wrote a script to test Marshal dump/load with many time object ( see attachment ).

basic idea is:
1) A is container of time,  it contains 100,000 time instance (all Time.now).
2) dump/load A by using Marshal, expected behavior is all the time zone must same as Time.now.zone

but I get different things or unreadable code in some Time instance by calling time.zone.
mostly it's "UTF-8'.

env:  Mac 10.9.2, ruby: ruby 2.1.1-p76

PS: it's fine while A contain 10,000 time instance

---Files--------------------------------
timezone_test.rb (409 Bytes)


-- 
https://bugs.ruby-lang.org/

[ruby-core:61694] [ruby-trunk - Bug #9652] Marshal doesn't dump/load Time#zone correctly with too many time object

[usa]

Issue #9652 has been updated by Usaku NAKAMURA.


Eric Wong wrote:
>  Sorry about the portability problems.

Of course you don't have to take it seriously.
It's the reason why platform maintainers exist.

I'm worried that I don't understand the intention of the test correctly.
If there are any problems, please correct.


----------------------------------------
Bug #9652: Marshal doesn't dump/load Time#zone correctly with too many time object
https://bugs.ruby-lang.org/issues/9652#change-45944

* Author: Cantin Xu
* Status: Closed
* Priority: Normal
* Assignee: 
* Category: core
* Target version: current: 2.2.0
* ruby -v: ruby 2.1.1p76 (2014-02-24 revision 45161) [x86_64-darwin13.0]
* Backport: 2.0.0: REQUIRED, 2.1: REQUIRED
----------------------------------------
Hi, there

I wrote a script to test Marshal dump/load with many time object ( see attachment ).

basic idea is:
1) A is container of time,  it contains 100,000 time instance (all Time.now).
2) dump/load A by using Marshal, expected behavior is all the time zone must same as Time.now.zone

but I get different things or unreadable code in some Time instance by calling time.zone.
mostly it's "UTF-8'.

env:  Mac 10.9.2, ruby: ruby 2.1.1-p76

PS: it's fine while A contain 10,000 time instance

---Files--------------------------------
timezone_test.rb (409 Bytes)


-- 
https://bugs.ruby-lang.org/

[ruby-core:62246] [ruby-trunk - Bug #9652] Marshal doesn't dump/load Time#zone correctly with too many time object

[usa]

Issue #9652 has been updated by Usaku NAKAMURA.

Backport changed from 2.0.0: REQUIRED, 2.1: REQUIRED to 2.0.0: DONE, 2.1: REQUIRED

backported r45364, r45395, r45396, r45403 and r45406 into ruby_2_0_0 at r45752.

----------------------------------------
Bug #9652: Marshal doesn't dump/load Time#zone correctly with too many time object
https://bugs.ruby-lang.org/issues/9652#change-46398

* Author: Cantin Xu
* Status: Closed
* Priority: Normal
* Assignee: 
* Category: core
* Target version: current: 2.2.0
* ruby -v: ruby 2.1.1p76 (2014-02-24 revision 45161) [x86_64-darwin13.0]
* Backport: 2.0.0: DONE, 2.1: REQUIRED
----------------------------------------
Hi, there

I wrote a script to test Marshal dump/load with many time object ( see attachment ).

basic idea is:
1) A is container of time,  it contains 100,000 time instance (all Time.now).
2) dump/load A by using Marshal, expected behavior is all the time zone must same as Time.now.zone

but I get different things or unreadable code in some Time instance by calling time.zone.
mostly it's "UTF-8'.

env:  Mac 10.9.2, ruby: ruby 2.1.1-p76

PS: it's fine while A contain 10,000 time instance

---Files--------------------------------
timezone_test.rb (409 Bytes)


-- 
https://bugs.ruby-lang.org/

[ruby-core:62891] [ruby-trunk - Bug #9652] Marshal doesn't dump/load Time#zone correctly with too many time object

[nagachika00]

Issue #9652 has been updated by Tomoyuki Chikanaga.

Backport changed from 2.0.0: DONE, 2.1: REQUIRED to 2.0.0: DONE, 2.1: DONE

r45364, r45395, r45396, r45403 and r45406 were backported into `ruby_2_1` branch at r46304.

----------------------------------------
Bug #9652: Marshal doesn't dump/load Time#zone correctly with too many time object
https://bugs.ruby-lang.org/issues/9652#change-46998

* Author: Cantin Xu
* Status: Closed
* Priority: Normal
* Assignee: 
* Category: core
* Target version: current: 2.2.0
* ruby -v: ruby 2.1.1p76 (2014-02-24 revision 45161) [x86_64-darwin13.0]
* Backport: 2.0.0: DONE, 2.1: DONE
----------------------------------------
Hi, there

I wrote a script to test Marshal dump/load with many time object ( see attachment ).

basic idea is:
1) A is container of time,  it contains 100,000 time instance (all Time.now).
2) dump/load A by using Marshal, expected behavior is all the time zone must same as Time.now.zone

but I get different things or unreadable code in some Time instance by calling time.zone.
mostly it's "UTF-8'.

env:  Mac 10.9.2, ruby: ruby 2.1.1-p76

PS: it's fine while A contain 10,000 time instance

---Files--------------------------------
timezone_test.rb (409 Bytes)


-- 
https://bugs.ruby-lang.org/

[ruby-core:62918] [ruby-trunk - Bug #9652] Marshal doesn't dump/load Time#zone correctly with too many time object

[cantin2010]

Issue #9652 has been updated by Cantin Xu.


Tomoyuki Chikanaga wrote:
> r45364, r45395, r45396, r45403 and r45406 were backported into `ruby_2_1` branch at r46304.

I can reproduce it in `ruby 2.1.2p95 (2014-05-08 revision 45877) [x86_64-darwin13.0]`

Changing the timezone_test.rb, modify line 19 from
 `100000.times do` 
to
 `5000000.times do`

anything wrong?

----------------------------------------
Bug #9652: Marshal doesn't dump/load Time#zone correctly with too many time object
https://bugs.ruby-lang.org/issues/9652#change-47024

* Author: Cantin Xu
* Status: Closed
* Priority: Normal
* Assignee: 
* Category: core
* Target version: current: 2.2.0
* ruby -v: ruby 2.1.1p76 (2014-02-24 revision 45161) [x86_64-darwin13.0]
* Backport: 2.0.0: DONE, 2.1: DONE
----------------------------------------
Hi, there

I wrote a script to test Marshal dump/load with many time object ( see attachment ).

basic idea is:
1) A is container of time,  it contains 100,000 time instance (all Time.now).
2) dump/load A by using Marshal, expected behavior is all the time zone must same as Time.now.zone

but I get different things or unreadable code in some Time instance by calling time.zone.
mostly it's "UTF-8'.

env:  Mac 10.9.2, ruby: ruby 2.1.1-p76

PS: it's fine while A contain 10,000 time instance

---Files--------------------------------
timezone_test.rb (409 Bytes)


-- 
https://bugs.ruby-lang.org/

[ruby-core:62919] Re: [ruby-trunk - Bug #9652] Marshal doesn't dump/load Time#zone correctly with too many time object

[Nobuyoshi Nakada]

(2014/06/03 15:47), cantin2010@gmail.com wrote:
> Tomoyuki Chikanaga wrote:
>> r45364, r45395, r45396, r45403 and r45406 were backported into `ruby_2_1` branch at r46304.
> 
> I can reproduce it in `ruby 2.1.2p95 (2014-05-08 revision 45877) [x86_64-darwin13.0]`
> 
> Changing the timezone_test.rb, modify line 19 from
>  `100000.times do` 
> to
>  `5000000.times do`
> 
> anything wrong?

45877 < 46304.

-- 
Nobu Nakada