From: "charliesome (Charlie Somerville)" <charliesome@ruby-lang.org>
To: ruby-core@ruby-lang.org
Subject: [ruby-core:58951] [ruby-trunk - Bug #9226] Getting method `inspect' called on unexpected T_NODE object (0x000000025ddea8 flags=0x109089c klass=0x0) (NotImplementedError) from Hash#inspect
Date: Sun, 8 Dec 2013 09:10:01 +0900 [thread overview]
Message-ID: <redmine.journal-43499.20131208091001@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-9226.20131208011712@ruby-lang.org
Issue #9226 has been updated by charliesome (Charlie Somerville).
Instead of shading the hash, we could probably do something like this:
diff --git hash.c hash.c
index a52e02f..e7a505e 100644
--- hash.c
+++ hash.c
@@ -1414,22 +1414,9 @@ rb_hash_replace(VALUE hash, VALUE hash2)
table2 = RHASH(hash2)->ntbl;
- if (RHASH_EMPTY_P(hash2)) {
- rb_hash_clear(hash);
- if (table2) hash_tbl(hash)->type = table2->type;
- return hash;
- }
-
- if (RHASH_ITER_LEV(hash) > 0) {
- rb_hash_clear(hash);
- hash_tbl(hash)->type = table2->type;
- rb_hash_foreach(hash2, replace_i, hash);
- }
- else {
- st_table *old_table = RHASH(hash)->ntbl;
- if (old_table) st_free_table(old_table);
- RHASH(hash)->ntbl = st_copy(table2);
- }
+ rb_hash_clear(hash);
+ hash_tbl(hash)->type = table2->type;
+ rb_hash_foreach(hash2, replace_i, hash);
return hash;
}
----------------------------------------
Bug #9226: Getting method `inspect' called on unexpected T_NODE object (0x000000025ddea8 flags=0x109089c klass=0x0) (NotImplementedError) from Hash#inspect
https://bugs.ruby-lang.org/issues/9226#change-43499
Author: myronmarston (Myron Marston)
Status: Open
Priority: Normal
Assignee:
Category:
Target version: current: 2.1.0
ruby -v: 2.1.0.preview2
Backport: 1.9.3: UNKNOWN, 2.0.0: UNKNOWN
We're trying to get a green RSpec build against ruby 2.1.0.preview2, and we're getting this very odd failure on travis:
https://travis-ci.org/rspec/rspec-core/jobs/15066502#L122
The line where it's failing is here:
https://github.com/rspec/rspec-core/blob/2e77a83d92eb1e661398f00359fc784da019401a/lib/rspec/core/filter_manager.rb#L75
It's calling `inspect` on a Hash and blowing up with that confusing error. The hash that's causing this failure (if that helps) is here:
https://github.com/rspec/rspec-core/blob/2e77a83d92eb1e661398f00359fc784da019401a/spec/spec_helper.rb#L149-L158
It's the `{ :ruby => lambda { } }` hash being passed to `filter_run_excluding`.
--
http://bugs.ruby-lang.org/
next prev parent reply other threads:[~2013-12-08 0:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-07 16:17 [ruby-core:58948] [ruby-trunk - Bug #9226][Open] Getting method `inspect' called on unexpected T_NODE object (0x000000025ddea8 flags=0x109089c klass=0x0) (NotImplementedError) from Hash#inspect myronmarston (Myron Marston)
2013-12-07 23:29 ` [ruby-core:58950] [ruby-trunk - Bug #9226] " tmm1 (Aman Gupta)
2013-12-08 0:10 ` charliesome (Charlie Somerville) [this message]
2013-12-08 0:11 ` [ruby-core:58952] " tmm1 (Aman Gupta)
2013-12-08 2:51 ` [ruby-core:58958] " ko1 (Koichi Sasada)
2013-12-08 3:06 ` [ruby-core:58959] " tmm1 (Aman Gupta)
2013-12-08 6:27 ` [ruby-core:58960] [ruby-trunk - Bug #9226][Open] " ko1 (Koichi Sasada)
2013-12-08 8:32 ` [ruby-core:58964] [ruby-trunk - Bug #9226] " myronmarston (Myron Marston)
2013-12-08 8:32 ` [ruby-core:58965] " myronmarston (Myron Marston)
2013-12-10 4:13 ` [ruby-core:59016] " tmm1 (Aman Gupta)
2013-12-10 5:48 ` [ruby-core:59018] " tmm1 (Aman Gupta)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-43499.20131208091001@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).