[ruby-core:54387] [ruby-trunk - Bug #8283][Open] Dir.glob doesn't recurse hidden directories

[ruby-core:54387] [ruby-trunk - Bug #8283][Open] Dir.glob doesn't recurse hidden directories

[gpakosz (Gregory Pakosz)]

Issue #8283 has been reported by gpakosz (Gregory Pakosz).

----------------------------------------
Bug #8283: Dir.glob doesn't recurse hidden directories
https://bugs.ruby-lang.org/issues/8283

Author: gpakosz (Gregory Pakosz)
Status: Open
Priority: Normal
Assignee: 
Category: core
Target version: 
ruby -v: ruby 2.0.0p0 (2013-02-24 revision 39474) [x86_64-darwin11.4.2]


Hello,

I noticed Dir.glob('**') doesn't recurse hidden directories.

I believe regression has been introduced by r36903.

Here is the following directory / file structure:
$ find .
.
./foo
./foo/.bar
./foo/.bar/baz.txt
./foo/bar

And here is the behavior of ruby 2.0.0p0 (2013-02-24 revision 39474) [x86_64-darwin11.4.2]:
$ ruby -e "puts Dir.glob('**/*')"
foo
foo/bar


-- 
http://bugs.ruby-lang.org/

[ruby-core:54388] [ruby-trunk - Bug #8283][Rejected] Dir.glob doesn't recurse hidden directories

[nobu (Nobuyoshi Nakada)]

Issue #8283 has been updated by nobu (Nobuyoshi Nakada).

Status changed from Open to Rejected

$ /usr/bin/ruby -v -e 'puts Dir.glob("**/*")'
ruby 1.8.7 (2012-02-08 patchlevel 358) [universal-darwin11.0]
foo
foo/bar

----------------------------------------
Bug #8283: Dir.glob doesn't recurse hidden directories
https://bugs.ruby-lang.org/issues/8283#change-38653

Author: gpakosz (Gregory Pakosz)
Status: Rejected
Priority: Normal
Assignee: 
Category: core
Target version: 
ruby -v: ruby 2.0.0p0 (2013-02-24 revision 39474) [x86_64-darwin11.4.2]


Hello,

I noticed Dir.glob('**') doesn't recurse hidden directories.

I believe regression has been introduced by r36903.

Here is the following directory / file structure:
$ find .
.
./foo
./foo/.bar
./foo/.bar/baz.txt
./foo/bar

And here is the behavior of ruby 2.0.0p0 (2013-02-24 revision 39474) [x86_64-darwin11.4.2]:
$ ruby -e "puts Dir.glob('**/*')"
foo
foo/bar


-- 
http://bugs.ruby-lang.org/

[ruby-core:54401] [ruby-trunk - Bug #8283] Dir.glob doesn't recurse hidden directories

[gpakosz (Gregory Pakosz)]

Issue #8283 has been updated by gpakosz (Gregory Pakosz).


well actually behavior changed between ruby 1.9.3-p392 and ruby 2.0.0-p0

I have a script that does:

local_repositories = []
Dir['_all/**/.git/config'].each do |f|
  config = IniFile.load(f)
  url = config['remote "origin"']['url']
  local_repositories << (url.end_with?('.git') ? url : "#{url}.git")
end


and that broke when upgrading to ruby 2.0.0-p0
with ruby 2.0.0-p0, Dir.glob doesn't enter .git directories at all
I had to change the expression to Dir['_all/*/.git/config']

so there is indeed a behavior change between ruby 1.9.3-p392 and ruby 2.0.0-p0, other people confirmed on their boxes on #ruby freenode

can you please reconsider the rejection?
thank you
----------------------------------------
Bug #8283: Dir.glob doesn't recurse hidden directories
https://bugs.ruby-lang.org/issues/8283#change-38663

Author: gpakosz (Gregory Pakosz)
Status: Rejected
Priority: Normal
Assignee: 
Category: core
Target version: 
ruby -v: ruby 2.0.0p0 (2013-02-24 revision 39474) [x86_64-darwin11.4.2]


Hello,

I noticed Dir.glob('**') doesn't recurse hidden directories.

I believe regression has been introduced by r36903.

Here is the following directory / file structure:
$ find .
.
./foo
./foo/.bar
./foo/.bar/baz.txt
./foo/bar

And here is the behavior of ruby 2.0.0p0 (2013-02-24 revision 39474) [x86_64-darwin11.4.2]:
$ ruby -e "puts Dir.glob('**/*')"
foo
foo/bar


-- 
http://bugs.ruby-lang.org/

[ruby-core:54425] [ruby-trunk - Bug #8283][Assigned] Dir.glob doesn't recurse hidden directories

[nobu (Nobuyoshi Nakada)]

Issue #8283 has been updated by nobu (Nobuyoshi Nakada).

Status changed from Rejected to Assigned
Assignee set to nobu (Nobuyoshi Nakada)

OK, that example makes sense.
----------------------------------------
Bug #8283: Dir.glob doesn't recurse hidden directories
https://bugs.ruby-lang.org/issues/8283#change-38690

Author: gpakosz (Gregory Pakosz)
Status: Assigned
Priority: Normal
Assignee: nobu (Nobuyoshi Nakada)
Category: core
Target version: 
ruby -v: ruby 2.0.0p0 (2013-02-24 revision 39474) [x86_64-darwin11.4.2]
Backport: 


Hello,

I noticed Dir.glob('**') doesn't recurse hidden directories.

I believe regression has been introduced by r36903.

Here is the following directory / file structure:
$ find .
.
./foo
./foo/.bar
./foo/.bar/baz.txt
./foo/bar

And here is the behavior of ruby 2.0.0p0 (2013-02-24 revision 39474) [x86_64-darwin11.4.2]:
$ ruby -e "puts Dir.glob('**/*')"
foo
foo/bar


-- 
http://bugs.ruby-lang.org/

[ruby-core:54428] [Backport 200 - Backport #8283] Dir.glob doesn't recurse hidden directories

[Hanmac (Hans Mackowiak)]

Issue #8283 has been updated by Hanmac (Hans Mackowiak).


moment ... i thought thats FNM_DOTMATCH for so glob("**") does not include the .git dir, but glob("**",File::FNM_DOTMATCH) does ... i thought this was a feature and not a bug
----------------------------------------
Backport #8283: Dir.glob doesn't recurse hidden directories
https://bugs.ruby-lang.org/issues/8283#change-38698

Author: gpakosz (Gregory Pakosz)
Status: Assigned
Priority: Normal
Assignee: nagachika (Tomoyuki Chikanaga)
Category: 
Target version: 


Hello,

I noticed Dir.glob('**') doesn't recurse hidden directories.

I believe regression has been introduced by r36903.

Here is the following directory / file structure:
$ find .
.
./foo
./foo/.bar
./foo/.bar/baz.txt
./foo/bar

And here is the behavior of ruby 2.0.0p0 (2013-02-24 revision 39474) [x86_64-darwin11.4.2]:
$ ruby -e "puts Dir.glob('**/*')"
foo
foo/bar


-- 
http://bugs.ruby-lang.org/

[ruby-core:54480] [Backport 200 - Backport #8283] Dir.glob doesn't recurse hidden directories

[nagachika (Tomoyuki Chikanaga)]

Issue #8283 has been updated by nagachika (Tomoyuki Chikanaga).


Hello, Hans.

After r40345, the result of Dir.glob("**") don't change, but Dir.glob("**/.git/config") matches "./.git/config" or so, and it is consistent with shell's behavior.
I think r40345 is appropriate bugfix.
----------------------------------------
Backport #8283: Dir.glob doesn't recurse hidden directories
https://bugs.ruby-lang.org/issues/8283#change-38785

Author: gpakosz (Gregory Pakosz)
Status: Assigned
Priority: Normal
Assignee: nagachika (Tomoyuki Chikanaga)
Category: 
Target version: 


Hello,

I noticed Dir.glob('**') doesn't recurse hidden directories.

I believe regression has been introduced by r36903.

Here is the following directory / file structure:
$ find .
.
./foo
./foo/.bar
./foo/.bar/baz.txt
./foo/bar

And here is the behavior of ruby 2.0.0p0 (2013-02-24 revision 39474) [x86_64-darwin11.4.2]:
$ ruby -e "puts Dir.glob('**/*')"
foo
foo/bar


-- 
http://bugs.ruby-lang.org/