From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id B95E417C7C93 for ; Thu, 17 May 2012 01:05:04 +0900 (JST) Received: from funfun.nagaokaut.ac.jp (funfun.nagaokaut.ac.jp [133.44.2.201]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id A0FF2EA6C6D for ; Thu, 17 May 2012 01:03:36 +0900 (JST) Received: from localhost (localhost.nagaokaut.ac.jp [127.0.0.1]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id C5CF58FC22 for ; Thu, 17 May 2012 01:03:38 +0900 (JST) X-Virus-Scanned: amavisd-new at funfun.nagaokaut.ac.jp Received: from funfun.nagaokaut.ac.jp ([127.0.0.1]) by localhost (funfun.nagaokaut.ac.jp [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AfrugSo9+jlx for ; Thu, 17 May 2012 01:03:38 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by funfun.nagaokaut.ac.jp (Postfix) with ESMTP id A4FBA8FC21 for ; Thu, 17 May 2012 01:03:38 +0900 (JST) Received: from carbon.ruby-lang.org (carbon.ruby-lang.org [221.186.184.68]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id 5D74D95243A for ; Thu, 17 May 2012 01:03:34 +0900 (JST) Received: from beryllium.ruby-lang.org (beryllium.ruby-lang.org [127.0.0.1]) by carbon.ruby-lang.org (Postfix) with ESMTP id 213C93C2294CA; Thu, 17 May 2012 01:03:33 +0900 (JST) Received: from fluorine.ruby-lang.org (www.rubyist.net [210.251.121.216]) by carbon.ruby-lang.org (Postfix) with ESMTP id D4F913C21EB86 for ; Thu, 17 May 2012 01:03:26 +0900 (JST) Received: from ruby-lang.org (localhost [127.0.0.1]) by fluorine.ruby-lang.org (Postfix) with ESMTP id BBD2D3ED47 for ; Thu, 17 May 2012 01:03:26 +0900 (JST) Delivered-To: ruby-core@ruby-lang.org Date: Thu, 17 May 2012 01:03:26 +0900 Posted: Thu, 17 May 2012 01:03:26 +0900 From: "mame (Yusuke Endoh)" Reply-To: ruby-core@ruby-lang.org Subject: [ruby-core:45094] [ruby-trunk - Bug #6436][Assigned] Byte counting incorrect in BufferedIO (net/protocol.rb) To: ruby-core@ruby-lang.org Message-Id: References: X-ML-Name: ruby-core X-Mail-Count: 45094 X-MLServer: fml [fml 4.0.3 release (20011202/4.0.3)]; post only (only members can post) X-ML-Info: If you have a question, send e-mail with the body "help" (without quotes) to the address ruby-core-ctl@ruby-lang.org; help= X-Mailer: Redmine X-Spam-Checker-Version: SpamAssassin 3.1.7-deb3 (2006-10-05) on carbon.ruby-lang.org X-Spam-Level: X-Spam-Status: No, score=0.6 required=7.0 tests=BAYES_50,CONTENT_TYPE_PRESENT, FAKEDWORD_ATMARK,FORGED_RCVD_HELO,X_MAILER_PRESENT autolearn=disabled version=3.1.7-deb3 X-Redmine-Issue-Author: jcast X-Redmine-Issue-Assignee: nobu X-Auto-Response-Suppress: OOF X-Redmine-Issue-Id: 6436 X-Redmine-Mailinglistintegration-Message-Ids: 15215 X-Redmine-Project: ruby-trunk Auto-Submitted: auto-generated X-Redmine-Site: Ruby Issue Tracking System X-Redmine-Host: bugs.ruby-lang.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Precedence: bulk List-Id: ruby-core.ruby-lang.org List-Software: fml [fml 4.0.3 release (20011202/4.0.3)] List-Post: List-Owner: List-Help: List-Unsubscribe: Issue #6436 has been updated by mame (Yusuke Endoh). Status changed from Open to Assigned Assignee set to nobu (Nobuyoshi Nakada) Thanks Jeremie, Could you add a test to test/net/http/test_buffered_io.rb ? Nobu, can you review the patch? -- Yusuke Endoh ---------------------------------------- Bug #6436: Byte counting incorrect in BufferedIO (net/protocol.rb) https://bugs.ruby-lang.org/issues/6436#change-26667 Author: jcast (Jeremie Castagna) Status: Assigned Priority: Normal Assignee: nobu (Nobuyoshi Nakada) Category: Target version: ruby -v: 1.9 BufferedIO's @rbuf counts bytes with String#size, but should use String#bytesize. This creates potential incorrect reading of a HTTP body when changing the encoding of each chuck passed by HTTP#read_body: http.read_body do |chunk| chunk.force_encoding "UTF-8" end -- http://bugs.ruby-lang.org/