ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
* [ruby-core:39973] [Ruby 1.9 - Bug #5412][Open] Array documentation
@ 2011-10-05 22:21 Andrea Singh
  2011-10-06  0:32 ` [ruby-core:39975] [Ruby 1.9 - Bug #5412] " Eric Hodel
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Andrea Singh @ 2011-10-05 22:21 UTC (permalink / raw
  To: ruby-core


Issue #5412 has been reported by Andrea Singh.

----------------------------------------
Bug #5412: Array documentation
http://redmine.ruby-lang.org/issues/5412

Author: Andrea Singh
Status: Open
Priority: Normal
Assignee: Eric Hodel
Category: DOC
Target version: 
ruby -v: trunk


As a contribution to the Mendicant University drive to enhance MRI documentation, I've tackled documentation of the Array class. I've amplified the general description of the Array class and highlighted some of the more commonly used instance methods. I've also edited some of the method-level code samples.


-- 
http://redmine.ruby-lang.org

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [ruby-core:39975] [Ruby 1.9 - Bug #5412] Array documentation
  2011-10-05 22:21 [ruby-core:39973] [Ruby 1.9 - Bug #5412][Open] Array documentation Andrea Singh
@ 2011-10-06  0:32 ` Eric Hodel
  2011-10-07  2:37 ` [ruby-core:40013] " Andrea Singh
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Eric Hodel @ 2011-10-06  0:32 UTC (permalink / raw
  To: ruby-core


Issue #5412 has been updated by Eric Hodel.


It seems you have reindented the file by mistake, removing all the tabs.  Please resubmit without changing the indentation.

See http://redmine.ruby-lang.org/projects/ruby/wiki/DeveloperHowto#coding-style for help configuring your editor.
----------------------------------------
Bug #5412: Array documentation
http://redmine.ruby-lang.org/issues/5412

Author: Andrea Singh
Status: Open
Priority: Normal
Assignee: Eric Hodel
Category: DOC
Target version: 
ruby -v: trunk


As a contribution to the Mendicant University drive to enhance MRI documentation, I've tackled documentation of the Array class. I've amplified the general description of the Array class and highlighted some of the more commonly used instance methods. I've also edited some of the method-level code samples.


-- 
http://redmine.ruby-lang.org

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [ruby-core:40013] [Ruby 1.9 - Bug #5412] Array documentation
  2011-10-05 22:21 [ruby-core:39973] [Ruby 1.9 - Bug #5412][Open] Array documentation Andrea Singh
  2011-10-06  0:32 ` [ruby-core:39975] [Ruby 1.9 - Bug #5412] " Eric Hodel
@ 2011-10-07  2:37 ` Andrea Singh
  2011-10-07 18:54 ` [ruby-core:40032] " Eric Hodel
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Andrea Singh @ 2011-10-07  2:37 UTC (permalink / raw
  To: ruby-core


Issue #5412 has been updated by Andrea Singh.

File 0001-documentation-for-array.patch added

Sorry about that. I didn't notice that Textmate was deleting the tabs when I pasted the documentation text. 

Anyway, I'm resubmitting the patch now.
----------------------------------------
Bug #5412: Array documentation
http://redmine.ruby-lang.org/issues/5412

Author: Andrea Singh
Status: Open
Priority: Normal
Assignee: Eric Hodel
Category: DOC
Target version: 
ruby -v: trunk


As a contribution to the Mendicant University drive to enhance MRI documentation, I've tackled documentation of the Array class. I've amplified the general description of the Array class and highlighted some of the more commonly used instance methods. I've also edited some of the method-level code samples.


-- 
http://redmine.ruby-lang.org

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [ruby-core:40032] [Ruby 1.9 - Bug #5412] Array documentation
  2011-10-05 22:21 [ruby-core:39973] [Ruby 1.9 - Bug #5412][Open] Array documentation Andrea Singh
  2011-10-06  0:32 ` [ruby-core:39975] [Ruby 1.9 - Bug #5412] " Eric Hodel
  2011-10-07  2:37 ` [ruby-core:40013] " Andrea Singh
@ 2011-10-07 18:54 ` Eric Hodel
  2011-10-09 17:06 ` [ruby-core:40078] " Andrea Singh
  2011-10-10 22:58 ` [ruby-core:40093] " Eric Hodel
  4 siblings, 0 replies; 6+ messages in thread
From: Eric Hodel @ 2011-10-07 18:54 UTC (permalink / raw
  To: ruby-core


Issue #5412 has been updated by Eric Hodel.


Overall this patch is good, but needs some small adjustments.

The new additions to the top-level documentation should include a * even for blank lines.

When you're referring to other methods they should not be surrounded by "+" or "<code>" so RDoc will link them.  For example, use #compact instead of +compact+.

I think there is too much duplication with the documentation of the individual methods for Creating Arrays and Accessing Elements sections.  Could you trim this down to avoid the duplication?
----------------------------------------
Bug #5412: Array documentation
http://redmine.ruby-lang.org/issues/5412

Author: Andrea Singh
Status: Open
Priority: Normal
Assignee: Eric Hodel
Category: DOC
Target version: 
ruby -v: trunk


As a contribution to the Mendicant University drive to enhance MRI documentation, I've tackled documentation of the Array class. I've amplified the general description of the Array class and highlighted some of the more commonly used instance methods. I've also edited some of the method-level code samples.


-- 
http://redmine.ruby-lang.org

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [ruby-core:40078] [Ruby 1.9 - Bug #5412] Array documentation
  2011-10-05 22:21 [ruby-core:39973] [Ruby 1.9 - Bug #5412][Open] Array documentation Andrea Singh
                   ` (2 preceding siblings ...)
  2011-10-07 18:54 ` [ruby-core:40032] " Eric Hodel
@ 2011-10-09 17:06 ` Andrea Singh
  2011-10-10 22:58 ` [ruby-core:40093] " Eric Hodel
  4 siblings, 0 replies; 6+ messages in thread
From: Andrea Singh @ 2011-10-09 17:06 UTC (permalink / raw
  To: ruby-core


Issue #5412 has been updated by Andrea Singh.

File 0001-Adjustments-to-Array-documentation.patch added

Hi Eric,

I made the adjustments you requested. I added the * for blank lines and linked the references to other methods where possible. In some instances, like for Array#<< or Array#[] adding the hash mark didn't create the link. Not sure if there's a workaround for that.

I also tried to trim down the two sections you mentioned (Creating Arrays and Accessing Array Elements). Let me know if you think this will work or whether you need me to edit it even further.

Thanks,

Andrea
----------------------------------------
Bug #5412: Array documentation
http://redmine.ruby-lang.org/issues/5412

Author: Andrea Singh
Status: Open
Priority: Normal
Assignee: Eric Hodel
Category: DOC
Target version: 
ruby -v: trunk


As a contribution to the Mendicant University drive to enhance MRI documentation, I've tackled documentation of the Array class. I've amplified the general description of the Array class and highlighted some of the more commonly used instance methods. I've also edited some of the method-level code samples.


-- 
http://redmine.ruby-lang.org

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [ruby-core:40093] [Ruby 1.9 - Bug #5412] Array documentation
  2011-10-05 22:21 [ruby-core:39973] [Ruby 1.9 - Bug #5412][Open] Array documentation Andrea Singh
                   ` (3 preceding siblings ...)
  2011-10-09 17:06 ` [ruby-core:40078] " Andrea Singh
@ 2011-10-10 22:58 ` Eric Hodel
  4 siblings, 0 replies; 6+ messages in thread
From: Eric Hodel @ 2011-10-10 22:58 UTC (permalink / raw
  To: ruby-core


Issue #5412 has been updated by Eric Hodel.


I made a few minor changes to your patch:

I aligned the various example result (#=>) markers for better readability

I changed edited some wording for flow and removed some fancy words (like heterogenous) because they were explained in simpler english which is easier for non-english-speakers to understand.
----------------------------------------
Bug #5412: Array documentation
http://redmine.ruby-lang.org/issues/5412

Author: Andrea Singh
Status: Closed
Priority: Normal
Assignee: Eric Hodel
Category: DOC
Target version: 
ruby -v: trunk


As a contribution to the Mendicant University drive to enhance MRI documentation, I've tackled documentation of the Array class. I've amplified the general description of the Array class and highlighted some of the more commonly used instance methods. I've also edited some of the method-level code samples.


-- 
http://redmine.ruby-lang.org

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2011-10-10 23:02 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-05 22:21 [ruby-core:39973] [Ruby 1.9 - Bug #5412][Open] Array documentation Andrea Singh
2011-10-06  0:32 ` [ruby-core:39975] [Ruby 1.9 - Bug #5412] " Eric Hodel
2011-10-07  2:37 ` [ruby-core:40013] " Andrea Singh
2011-10-07 18:54 ` [ruby-core:40032] " Eric Hodel
2011-10-09 17:06 ` [ruby-core:40078] " Andrea Singh
2011-10-10 22:58 ` [ruby-core:40093] " Eric Hodel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).