* [ruby-core:39972] [Ruby 1.9 - Bug #5411][Open] Some enum.c doc tweaks
@ 2011-10-05 22:07 b t
2011-10-06 1:01 ` [ruby-core:39976] [Ruby 1.9 - Bug #5411] " Eric Hodel
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: b t @ 2011-10-05 22:07 UTC (permalink / raw
To: ruby-core
Issue #5411 has been reported by b t.
----------------------------------------
Bug #5411: Some enum.c doc tweaks
http://redmine.ruby-lang.org/issues/5411
Author: b t
Status: Open
Priority: Normal
Assignee: Eric Hodel
Category: DOC
Target version: 1.9.x
ruby -v: --
I tried to fix some of the method descriptions and made. Please check group_by if this is any better than the original version. I had trouble finding a concise description.
Thanks for reviewing.
--
http://redmine.ruby-lang.org
^ permalink raw reply [flat|nested] 5+ messages in thread
* [ruby-core:39976] [Ruby 1.9 - Bug #5411] Some enum.c doc tweaks
2011-10-05 22:07 [ruby-core:39972] [Ruby 1.9 - Bug #5411][Open] Some enum.c doc tweaks b t
@ 2011-10-06 1:01 ` Eric Hodel
2011-10-06 12:26 ` [ruby-core:39985] " b t
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Eric Hodel @ 2011-10-06 1:01 UTC (permalink / raw
To: ruby-core
Issue #5411 has been updated by Eric Hodel.
I improved group_by in r33417 based on your work.
----------------------------------------
Bug #5411: Some enum.c doc tweaks
http://redmine.ruby-lang.org/issues/5411
Author: b t
Status: Closed
Priority: Normal
Assignee: Eric Hodel
Category: DOC
Target version: 1.9.x
ruby -v: --
I tried to fix some of the method descriptions and made. Please check group_by if this is any better than the original version. I had trouble finding a concise description.
Thanks for reviewing.
--
http://redmine.ruby-lang.org
^ permalink raw reply [flat|nested] 5+ messages in thread
* [ruby-core:39985] [Ruby 1.9 - Bug #5411] Some enum.c doc tweaks
2011-10-05 22:07 [ruby-core:39972] [Ruby 1.9 - Bug #5411][Open] Some enum.c doc tweaks b t
2011-10-06 1:01 ` [ruby-core:39976] [Ruby 1.9 - Bug #5411] " Eric Hodel
@ 2011-10-06 12:26 ` b t
2011-10-07 23:56 ` [ruby-core:40040] " Eric Hodel
2012-02-25 8:38 ` [ruby-core:42911] [ruby-trunk " Bernd Homuth
3 siblings, 0 replies; 5+ messages in thread
From: b t @ 2011-10-06 12:26 UTC (permalink / raw
To: ruby-core
Issue #5411 has been updated by b t.
File 0001-change-Enumerable-group_by-description.patch added
I find the new group_by more confusing now and changed it to this:
* Groups the collection by result of the block. Returns a hash where the
* keys are the evaluated result from the block and the values are
* arrays of elements in the collection that correspond to the key.
*
* If no block is given an enumerator is returned.
*
* (1..6).group_by { |i| i%3 } #=> {0=>[3, 6], 1=>[1, 4], 2=>[2, 5]}
Do you agree. I mean it's still not perfect but that double value sentence didn't make sense to me.
BTW, how do I properly sign my stuff? Redmine/svn patches don't support the usual git signatures. If possible I'd like to sign my stuff with my github nick burningTyger
Thank you for reviewing
----------------------------------------
Bug #5411: Some enum.c doc tweaks
http://redmine.ruby-lang.org/issues/5411
Author: b t
Status: Closed
Priority: Normal
Assignee: Eric Hodel
Category: DOC
Target version: 1.9.x
ruby -v: --
I tried to fix some of the method descriptions and made. Please check group_by if this is any better than the original version. I had trouble finding a concise description.
Thanks for reviewing.
--
http://redmine.ruby-lang.org
^ permalink raw reply [flat|nested] 5+ messages in thread
* [ruby-core:40040] [Ruby 1.9 - Bug #5411] Some enum.c doc tweaks
2011-10-05 22:07 [ruby-core:39972] [Ruby 1.9 - Bug #5411][Open] Some enum.c doc tweaks b t
2011-10-06 1:01 ` [ruby-core:39976] [Ruby 1.9 - Bug #5411] " Eric Hodel
2011-10-06 12:26 ` [ruby-core:39985] " b t
@ 2011-10-07 23:56 ` Eric Hodel
2012-02-25 8:38 ` [ruby-core:42911] [ruby-trunk " Bernd Homuth
3 siblings, 0 replies; 5+ messages in thread
From: Eric Hodel @ 2011-10-07 23:56 UTC (permalink / raw
To: ruby-core
Issue #5411 has been updated by Eric Hodel.
Yours is better, I applied it!
----------------------------------------
Bug #5411: Some enum.c doc tweaks
http://redmine.ruby-lang.org/issues/5411
Author: b t
Status: Closed
Priority: Normal
Assignee: Eric Hodel
Category: DOC
Target version: 1.9.x
ruby -v: --
I tried to fix some of the method descriptions and made. Please check group_by if this is any better than the original version. I had trouble finding a concise description.
Thanks for reviewing.
--
http://redmine.ruby-lang.org
^ permalink raw reply [flat|nested] 5+ messages in thread
* [ruby-core:42911] [ruby-trunk - Bug #5411] Some enum.c doc tweaks
2011-10-05 22:07 [ruby-core:39972] [Ruby 1.9 - Bug #5411][Open] Some enum.c doc tweaks b t
` (2 preceding siblings ...)
2011-10-07 23:56 ` [ruby-core:40040] " Eric Hodel
@ 2012-02-25 8:38 ` Bernd Homuth
3 siblings, 0 replies; 5+ messages in thread
From: Bernd Homuth @ 2012-02-25 8:38 UTC (permalink / raw
To: ruby-core
Issue #5411 has been updated by Bernd Homuth.
Bernd Homuth wrote:
> I find the new group_by more confusing now and changed it to this:
>
>
> * Groups the collection by result of the block. Returns a hash where the
> * keys are the evaluated result from the block and the values are
> * arrays of elements in the collection that correspond to the key.
> *
> * If no block is given an enumerator is returned.
> *
> * (1..6).group_by { |i| i%3 } #=> {0=>[3, 6], 1=>[1, 4], 2=>[2, 5]}
>
> Do you agree. I mean it's still not perfect but that double value sentence didn't make sense to me.
>
> Thank you for reviewing
----------------------------------------
Bug #5411: Some enum.c doc tweaks
https://bugs.ruby-lang.org/issues/5411
Author: Bernd Homuth
Status: Closed
Priority: Normal
Assignee: Eric Hodel
Category: DOC
Target version: 2.0.0
ruby -v: --
I tried to fix some of the method descriptions and made. Please check group_by if this is any better than the original version. I had trouble finding a concise description.
Thanks for reviewing.
--
http://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-02-25 8:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-05 22:07 [ruby-core:39972] [Ruby 1.9 - Bug #5411][Open] Some enum.c doc tweaks b t
2011-10-06 1:01 ` [ruby-core:39976] [Ruby 1.9 - Bug #5411] " Eric Hodel
2011-10-06 12:26 ` [ruby-core:39985] " b t
2011-10-07 23:56 ` [ruby-core:40040] " Eric Hodel
2012-02-25 8:38 ` [ruby-core:42911] [ruby-trunk " Bernd Homuth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).