ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
* [ruby-core:37575] [Ruby 1.9 - Bug #4937][Open] trunk@32244 MinGW build failure - thread_win32.c
@ 2011-06-27 14:58 Jon Forums
  2011-06-28  0:49 ` [ruby-core:37594] [Ruby 1.9 - Bug #4937] " Luis Lavena
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Jon Forums @ 2011-06-27 14:58 UTC (permalink / raw
  To: ruby-core


Issue #4937 has been reported by Jon Forums.

----------------------------------------
Bug #4937: trunk@32244 MinGW build failure - thread_win32.c  
http://redmine.ruby-lang.org/issues/4937

Author: Jon Forums
Status: Open
Priority: Normal
Assignee: 
Category: 
Target version: 
ruby -v: ruby 1.9.3dev (2011-06-27 trunk 32242) [i386-mingw32]


The signature of `native_stop_timer_thread` at

    https://github.com/ruby/ruby/blob/trunk/thread_win32.c#L748

conflicts with it's usage by `rb_thread_stop_timer_thread` at

    https://github.com/ruby/ruby/blob/trunk/thread.c#L2989

resulting in the following build error when using the RubyInstaller build recipes and gcc.exe (tdm-1) 4.5.2:

<pre>
compiling ../../../../Users/Jon/Documents/RubyDev/ruby-git/thread.c
../../../../Users/Jon/Documents/RubyDev/ruby-git/thread.c: In function 'rb_thread_stop_timer_thread':
../../../../Users/Jon/Documents/RubyDev/ruby-git/thread.c:2989:5: error: too many arguments to function 'native_stop_timer_thread'
../../../../Users/Jon/Documents/RubyDev/ruby-git/thread_win32.c:748:1: note: declared here
</pre> 


-- 
http://redmine.ruby-lang.org

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [ruby-core:37594] [Ruby 1.9 - Bug #4937] trunk@32244 MinGW build failure - thread_win32.c
  2011-06-27 14:58 [ruby-core:37575] [Ruby 1.9 - Bug #4937][Open] trunk@32244 MinGW build failure - thread_win32.c Jon Forums
@ 2011-06-28  0:49 ` Luis Lavena
  2011-06-28  0:51 ` [ruby-core:37595] " Hiroshi Nakamura
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Luis Lavena @ 2011-06-28  0:49 UTC (permalink / raw
  To: ruby-core


Issue #4937 has been updated by Luis Lavena.

Category set to build
Assignee set to Koichi Sasada

This was introduced in r32244 by Koichi Sasada. Assigning it to him.

Sasada-san, seems the signature change in thread_win32.c is missing, the following patch solves the compilation but I'm unsure the extend of the needed changes:


diff --git a/thread_win32.c b/thread_win32.c
index 5c20650..68fb346 100644
--- a/thread_win32.c
+++ b/thread_win32.c
@@ -745,7 +745,7 @@ rb_thread_create_timer_thread(void)
 }

 static int
-native_stop_timer_thread(void)
+native_stop_timer_thread(int close_anyway)
 {
     int stopped = --system_working <= 0;
     if (stopped) {


----------------------------------------
Bug #4937: trunk@32244 MinGW build failure - thread_win32.c  
http://redmine.ruby-lang.org/issues/4937

Author: Jon Forums
Status: Open
Priority: Normal
Assignee: Koichi Sasada
Category: build
Target version: 
ruby -v: ruby 1.9.3dev (2011-06-27 trunk 32242) [i386-mingw32]


The signature of `native_stop_timer_thread` at

    https://github.com/ruby/ruby/blob/trunk/thread_win32.c#L748

conflicts with it's usage by `rb_thread_stop_timer_thread` at

    https://github.com/ruby/ruby/blob/trunk/thread.c#L2989

resulting in the following build error when using the RubyInstaller build recipes and gcc.exe (tdm-1) 4.5.2:

<pre>
compiling ../../../../Users/Jon/Documents/RubyDev/ruby-git/thread.c
../../../../Users/Jon/Documents/RubyDev/ruby-git/thread.c: In function 'rb_thread_stop_timer_thread':
../../../../Users/Jon/Documents/RubyDev/ruby-git/thread.c:2989:5: error: too many arguments to function 'native_stop_timer_thread'
../../../../Users/Jon/Documents/RubyDev/ruby-git/thread_win32.c:748:1: note: declared here
</pre> 


-- 
http://redmine.ruby-lang.org

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [ruby-core:37595] [Ruby 1.9 - Bug #4937] trunk@32244 MinGW build failure - thread_win32.c
  2011-06-27 14:58 [ruby-core:37575] [Ruby 1.9 - Bug #4937][Open] trunk@32244 MinGW build failure - thread_win32.c Jon Forums
  2011-06-28  0:49 ` [ruby-core:37594] [Ruby 1.9 - Bug #4937] " Luis Lavena
@ 2011-06-28  0:51 ` Hiroshi Nakamura
  2011-06-28 15:23 ` [ruby-core:37636] " Jon Forums
  2011-06-29  4:08 ` [ruby-core:37653] [Ruby 1.9 - Bug #4937][Closed] " Usaku NAKAMURA
  3 siblings, 0 replies; 5+ messages in thread
From: Hiroshi Nakamura @ 2011-06-28  0:51 UTC (permalink / raw
  To: ruby-core


Issue #4937 has been updated by Hiroshi Nakamura.

Target version set to 1.9.3


----------------------------------------
Bug #4937: trunk@32244 MinGW build failure - thread_win32.c  
http://redmine.ruby-lang.org/issues/4937

Author: Jon Forums
Status: Open
Priority: Normal
Assignee: Koichi Sasada
Category: build
Target version: 1.9.3
ruby -v: ruby 1.9.3dev (2011-06-27 trunk 32242) [i386-mingw32]


The signature of `native_stop_timer_thread` at

    https://github.com/ruby/ruby/blob/trunk/thread_win32.c#L748

conflicts with it's usage by `rb_thread_stop_timer_thread` at

    https://github.com/ruby/ruby/blob/trunk/thread.c#L2989

resulting in the following build error when using the RubyInstaller build recipes and gcc.exe (tdm-1) 4.5.2:

<pre>
compiling ../../../../Users/Jon/Documents/RubyDev/ruby-git/thread.c
../../../../Users/Jon/Documents/RubyDev/ruby-git/thread.c: In function 'rb_thread_stop_timer_thread':
../../../../Users/Jon/Documents/RubyDev/ruby-git/thread.c:2989:5: error: too many arguments to function 'native_stop_timer_thread'
../../../../Users/Jon/Documents/RubyDev/ruby-git/thread_win32.c:748:1: note: declared here
</pre> 


-- 
http://redmine.ruby-lang.org

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [ruby-core:37636] [Ruby 1.9 - Bug #4937] trunk@32244 MinGW build failure - thread_win32.c
  2011-06-27 14:58 [ruby-core:37575] [Ruby 1.9 - Bug #4937][Open] trunk@32244 MinGW build failure - thread_win32.c Jon Forums
  2011-06-28  0:49 ` [ruby-core:37594] [Ruby 1.9 - Bug #4937] " Luis Lavena
  2011-06-28  0:51 ` [ruby-core:37595] " Hiroshi Nakamura
@ 2011-06-28 15:23 ` Jon Forums
  2011-06-29  4:08 ` [ruby-core:37653] [Ruby 1.9 - Bug #4937][Closed] " Usaku NAKAMURA
  3 siblings, 0 replies; 5+ messages in thread
From: Jon Forums @ 2011-06-28 15:23 UTC (permalink / raw
  To: ruby-core


Issue #4937 has been updated by Jon Forums.


fixed by trunk@32268 with `make test` and `make test-all TESTS='openssl fiddle psych'` all passing
----------------------------------------
Bug #4937: trunk@32244 MinGW build failure - thread_win32.c  
http://redmine.ruby-lang.org/issues/4937

Author: Jon Forums
Status: Open
Priority: Normal
Assignee: Koichi Sasada
Category: build
Target version: 1.9.3
ruby -v: ruby 1.9.3dev (2011-06-27 trunk 32242) [i386-mingw32]


The signature of `native_stop_timer_thread` at

    https://github.com/ruby/ruby/blob/trunk/thread_win32.c#L748

conflicts with it's usage by `rb_thread_stop_timer_thread` at

    https://github.com/ruby/ruby/blob/trunk/thread.c#L2989

resulting in the following build error when using the RubyInstaller build recipes and gcc.exe (tdm-1) 4.5.2:

<pre>
compiling ../../../../Users/Jon/Documents/RubyDev/ruby-git/thread.c
../../../../Users/Jon/Documents/RubyDev/ruby-git/thread.c: In function 'rb_thread_stop_timer_thread':
../../../../Users/Jon/Documents/RubyDev/ruby-git/thread.c:2989:5: error: too many arguments to function 'native_stop_timer_thread'
../../../../Users/Jon/Documents/RubyDev/ruby-git/thread_win32.c:748:1: note: declared here
</pre> 


-- 
http://redmine.ruby-lang.org

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [ruby-core:37653] [Ruby 1.9 - Bug #4937][Closed] trunk@32244 MinGW build failure - thread_win32.c
  2011-06-27 14:58 [ruby-core:37575] [Ruby 1.9 - Bug #4937][Open] trunk@32244 MinGW build failure - thread_win32.c Jon Forums
                   ` (2 preceding siblings ...)
  2011-06-28 15:23 ` [ruby-core:37636] " Jon Forums
@ 2011-06-29  4:08 ` Usaku NAKAMURA
  3 siblings, 0 replies; 5+ messages in thread
From: Usaku NAKAMURA @ 2011-06-29  4:08 UTC (permalink / raw
  To: ruby-core


Issue #4937 has been updated by Usaku NAKAMURA.

Status changed from Open to Closed


----------------------------------------
Bug #4937: trunk@32244 MinGW build failure - thread_win32.c  
http://redmine.ruby-lang.org/issues/4937

Author: Jon Forums
Status: Closed
Priority: Normal
Assignee: Koichi Sasada
Category: build
Target version: 1.9.3
ruby -v: ruby 1.9.3dev (2011-06-27 trunk 32242) [i386-mingw32]


The signature of `native_stop_timer_thread` at

    https://github.com/ruby/ruby/blob/trunk/thread_win32.c#L748

conflicts with it's usage by `rb_thread_stop_timer_thread` at

    https://github.com/ruby/ruby/blob/trunk/thread.c#L2989

resulting in the following build error when using the RubyInstaller build recipes and gcc.exe (tdm-1) 4.5.2:

<pre>
compiling ../../../../Users/Jon/Documents/RubyDev/ruby-git/thread.c
../../../../Users/Jon/Documents/RubyDev/ruby-git/thread.c: In function 'rb_thread_stop_timer_thread':
../../../../Users/Jon/Documents/RubyDev/ruby-git/thread.c:2989:5: error: too many arguments to function 'native_stop_timer_thread'
../../../../Users/Jon/Documents/RubyDev/ruby-git/thread_win32.c:748:1: note: declared here
</pre> 


-- 
http://redmine.ruby-lang.org

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2011-06-29  3:58 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-27 14:58 [ruby-core:37575] [Ruby 1.9 - Bug #4937][Open] trunk@32244 MinGW build failure - thread_win32.c Jon Forums
2011-06-28  0:49 ` [ruby-core:37594] [Ruby 1.9 - Bug #4937] " Luis Lavena
2011-06-28  0:51 ` [ruby-core:37595] " Hiroshi Nakamura
2011-06-28 15:23 ` [ruby-core:37636] " Jon Forums
2011-06-29  4:08 ` [ruby-core:37653] [Ruby 1.9 - Bug #4937][Closed] " Usaku NAKAMURA

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).