From: "javanthropus (Jeremy Bopp) via ruby-core" <ruby-core@ml.ruby-lang.org>
To: ruby-core@ml.ruby-lang.org
Cc: "javanthropus (Jeremy Bopp)" <noreply@ruby-lang.org>
Subject: [ruby-core:117778] [Ruby master Bug#18995] IO#set_encoding sometimes set an IO's internal encoding to the default external encoding
Date: Sun, 05 May 2024 15:20:06 +0000 (UTC) [thread overview]
Message-ID: <redmine.journal-108185.20240505152005.692@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-18995.20220904230654.692@ruby-lang.org
Issue #18995 has been updated by javanthropus (Jeremy Bopp).
@jeremyevans, did you ever take a look at this issue when I referenced it in #18899? The behavior is unchanged in Ruby 3.3.
The script above prints the following:
```
external encoding: #<Encoding:UTF-8> internal encoding: #<Encoding:ISO-8859-2>
external encoding: #<Encoding:UTF-8> internal encoding: #<Encoding:ISO-8859-1>
external encoding: #<Encoding:UTF-8> internal encoding: #<Encoding:ISO-8859-3>
```
I expected it to print this:
```
external encoding: #<Encoding:UTF-8> internal encoding: #<Encoding:ISO-8859-2>
external encoding: #<Encoding:UTF-8> internal encoding: #<Encoding:ISO-8859-2>
external encoding: #<Encoding:UTF-8> internal encoding: #<Encoding:ISO-8859-4>
```
----------------------------------------
Bug #18995: IO#set_encoding sometimes set an IO's internal encoding to the default external encoding
https://bugs.ruby-lang.org/issues/18995#change-108185
* Author: javanthropus (Jeremy Bopp)
* Status: Open
* ruby -v: ruby 3.1.2p20 (2022-04-12 revision 4491bb740a) [x86_64-linux]
* Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN
----------------------------------------
This script demonstrates the behavior:
```ruby
def show(io)
printf(
"external encoding: %-25p internal encoding: %-25p\n",
io.external_encoding,
io.internal_encoding
)
end
Encoding.default_external = 'iso-8859-1'
Encoding.default_internal = 'iso-8859-2'
File.open('/dev/null') do |f|
f.set_encoding('utf-8', nil)
show(f) # f.internal_encoding is iso-8859-2, as expected
f.set_encoding('utf-8', 'invalid')
show(f) # f.internal_encoding is now iso-8859-1!
Encoding.default_external = 'iso-8859-3'
Encoding.default_internal = 'iso-8859-4'
show(f) # f.internal_encoding is now iso-8859-3!
end
```
In the 1st case, we see that the IO's internal encoding is set to the current setting of Encoding.default_internal. In the 2nd case, the IO's internal encoding is set to Encoding.default_external instead. The 3rd case is more interesting because it shows that the IO's internal encoding is actually following the current setting of Encoding.default_external. It didn't just copy it when #set_encoding was called. It changes whenever Encoding.default_external changes.
What should the correct behavior be?
--
https://bugs.ruby-lang.org/
______________________________________________
ruby-core mailing list -- ruby-core@ml.ruby-lang.org
To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/
prev parent reply other threads:[~2024-05-05 15:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-04 23:06 [ruby-core:109842] [Ruby master Bug#18995] IO#set_encoding sometimes set an IO's internal encoding to the default external encoding javanthropus (Jeremy Bopp)
2022-09-15 13:28 ` [ruby-core:109902] " javanthropus (Jeremy Bopp)
2024-05-05 15:20 ` javanthropus (Jeremy Bopp) via ruby-core [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-108185.20240505152005.692@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
--cc=noreply@ruby-lang.org \
--cc=ruby-core@ml.ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).