From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from nue.mailmanlists.eu (nue.mailmanlists.eu [IPv6:2a01:4f8:1c0c:6b10::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 0C4D51F44D for ; Thu, 18 Apr 2024 06:56:15 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; secure) header.d=ml.ruby-lang.org header.i=@ml.ruby-lang.org header.a=rsa-sha256 header.s=mail header.b=H6ZbYEXD; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=GPZawser; dkim-atps=neutral Received: from nue.mailmanlists.eu (localhost [127.0.0.1]) by nue.mailmanlists.eu (Postfix) with ESMTP id 96748843CE; Thu, 18 Apr 2024 06:56:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ml.ruby-lang.org; s=mail; t=1713423367; bh=hUEfRwnbORpZzvrYhc8iH0TgOF+pJiTCy3mL8CJ79pE=; h=Date:References:To:Reply-To:Subject:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Cc:From; b=H6ZbYEXDaTWZysCfqh6CffxDVWlNociQqGC3SUzsnlah+8MgW2Xk/fl97CN7hiJbe H6MdDySHKDHVmM+geE+t/KvsQJz03JsxLksNdXxvBxNVg1UjwDcA+SHnOLjez92Bl2 mXIpJRRYTkoASGdhyBvzI2ljoQ7/dsyv8UgJHY8E= Received: from s.wfbtzhsw.outbound-mail.sendgrid.net (s.wfbtzhsw.outbound-mail.sendgrid.net [159.183.224.105]) by nue.mailmanlists.eu (Postfix) with ESMTPS id 9327C843C0 for ; Thu, 18 Apr 2024 06:56:04 +0000 (UTC) Authentication-Results: nue.mailmanlists.eu; dkim=pass (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=GPZawser; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ruby-lang.org; h=from:references:subject:mime-version:content-type: content-transfer-encoding:list-id:to:cc:content-type:from:subject:to; s=s1; bh=0Ufnjttqdhkw2s6VPttO/qqZTJSNOd8yw/DUf+IOrGo=; b=GPZawseryXsSIn5hdGeZ4bZ4rlGESL8AdEF++cr/JPWmTAlrghOqm9esX+b6WiKrxVv5 IUwV8zN5D2k9uu6Ror4j/iVhik6hRl2az38Gx+SG87GQ4PDP6bH1EpvjNqykyHJnuU5Icq 1oPTjtk3IrjyBsKBoxmym3F6vlvBhcw+rg30E9EGRt7WoPBoQu0prVkOhVmghzvnts9D37 qIPIAJaz/0+W57TvHk/+JGWRQ3Cr55mfVDgFguzXYxUwLrgOVRHQRSeo9pJh0/ho7jQ1FT Y9CIleHwlmIU0o+1vpnyjciUY7OOP/gG+7R2WdZHGJVXrhXwmRnjnmrBiBwHDiXg== Received: by recvd-6b888cd74b-gbltt with SMTP id recvd-6b888cd74b-gbltt-1-6620C403-F 2024-04-18 06:56:03.709072749 +0000 UTC m=+464133.118851592 Received: from herokuapp.com (unknown) by geopod-ismtpd-32 (SG) with ESMTP id uQ7E_-GDQFi0gHvnvLe-eA for ; Thu, 18 Apr 2024 06:56:03.599 +0000 (UTC) Date: Thu, 18 Apr 2024 06:56:03 +0000 (UTC) Message-ID: References: Mime-Version: 1.0 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Feature X-Redmine-Issue-Id: 20396 X-Redmine-Issue-Author: byroot X-Redmine-Issue-Priority: Normal X-Redmine-Sender: byroot X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-Redmine-MailingListIntegration-Message-Ids: 94188 X-SG-EID: =?us-ascii?Q?u001=2EKmNZ1u3n1vIpO8NNTdp+Q9c0ai7potxbEDLMO7SOJO=2F4KkRUz0d23466m?= =?us-ascii?Q?naiq=2F5fmA4hb60MdRMUAwHZnjIWVFu=2FrqiBOz5c?= =?us-ascii?Q?nOvkBudsSTi+V0aiE3=2FLwR=2FNeXWpSXvgTNboW6G?= =?us-ascii?Q?t8lbznVGzHHRSC1CsD7321np2Td0obMFvvmqhAY?= =?us-ascii?Q?9hntdQn=2FdBWlPG4Bez3tUZp7KKO8e08Lf7N3D9r?= =?us-ascii?Q?xJwMw5oEHNwBWiaJXiPuExtqJCaZST+AV6p+gFu?= =?us-ascii?Q?JWHuF9vtjPCzXN2Hj2X+Uh+yhg=3D=3D?= To: ruby-core@ml.ruby-lang.org X-Entity-ID: u001.I8uzylDtAfgbeCOeLBYDww== Message-ID-Hash: L74AGACTMVYZGAP3RBD4XJD7472AR6N7 X-Message-ID-Hash: L74AGACTMVYZGAP3RBD4XJD7472AR6N7 X-MailFrom: bounces+313651-b711-ruby-core=ml.ruby-lang.org@em5188.ruby-lang.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list Reply-To: Ruby developers Subject: [ruby-core:117592] [Ruby master Feature#20396] ObjectSpace.dump_all(string_value: false): skip dumping the String contents List-Id: Ruby developers Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: "byroot (Jean Boussier) via ruby-core" Cc: "byroot (Jean Boussier)" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Issue #20396 has been updated by byroot (Jean Boussier). I'm not sure reasoning by analogy with core dumps is sound here. If there was a way to be sure a core dump is stripped of all personally identifiable informations I'd definitely use it to share core dumps when it's useful. > because, I'm pretty sure this is not the last thing you wanted for the output. ... and pretty sure we would end up need an entire SQL engine. I think this is a bit of an unfair argument. Yes I requested multiple additions to this API over the last few years, but in my opinion there is a very long way to go before it can considered a complex API, especially for an API that is intended for very advanced debugging. And it's not like I have a long list of feature requests I'm drip feeding. Also I don't even need that capability myself, I suggested it because I was trying to help @zzak fix a memory leak at his company, and the dumps containing string values made it hard for him to get approval to generate heap dumps from production because of security concerns, and thought this new option it could be useful for the community. ---------------------------------------- Feature #20396: ObjectSpace.dump_all(string_value: false): skip dumping the String contents https://bugs.ruby-lang.org/issues/20396#change-107993 * Author: byroot (Jean Boussier) * Status: Open ---------------------------------------- `ObjectSpace.dump_all` is a very useful method to debug memory leaks and such, hence is frequently needed in production. But since all the 7bit strings content is included in the dump, it incur the risk of leaking personal data, or secrets. Also, in many case the strings content isn't that helpful and is just making the dump much bigger for no good reason. And only pure-ASCII strings are dumped this way, which means all the tools that process these dumps should already be compatible with a dump without any string content. ### Feature I propose to add another optional parameter to `dump_all`: `string_value: false`. When passed, no String content is ever dumped regardless of its coderange. Implementation: https://github.com/ruby/ruby/pull/10382 cc @zzak -- https://bugs.ruby-lang.org/ ______________________________________________ ruby-core mailing list -- ruby-core@ml.ruby-lang.org To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/