From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=0.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET,SPF_HELO_PASS, SPF_PASS autolearn=no autolearn_force=no version=3.4.6 Received: from nue.mailmanlists.eu (nue.mailmanlists.eu [94.130.110.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id E6D131F44D for ; Wed, 17 Apr 2024 19:00:09 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; secure) header.d=ml.ruby-lang.org header.i=@ml.ruby-lang.org header.a=rsa-sha256 header.s=mail header.b=a3TSAXFE; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=TV14QRuZ; dkim-atps=neutral Received: from nue.mailmanlists.eu (localhost [127.0.0.1]) by nue.mailmanlists.eu (Postfix) with ESMTP id 3C4C684397; Wed, 17 Apr 2024 19:00:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ml.ruby-lang.org; s=mail; t=1713380403; bh=lfdsr3IEarDtneBqZu+gF8G12LvxN0Oe8ZMCkG2opiE=; h=Date:References:To:Reply-To:Subject:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Cc:From; b=a3TSAXFEng+WJentid6BgKJ1TZqjTp1Gx/2zFRaFjThlk3STktWtCV/Tqx77TE+0T ebKmEUKuGJT5CKcO4+88X1TliY3X0rVyl2J/iFmlWAkcClv3ABJLFOTEBDH2hAJRsl XJtRSBMA60H399KbAtF8qi/XyU2msX0myMxaCM8s= Received: from s.wrqvtzvf.outbound-mail.sendgrid.net (s.wrqvtzvf.outbound-mail.sendgrid.net [149.72.126.143]) by nue.mailmanlists.eu (Postfix) with ESMTPS id 7AEB68430B for ; Wed, 17 Apr 2024 18:59:59 +0000 (UTC) Authentication-Results: nue.mailmanlists.eu; dkim=pass (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=TV14QRuZ; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ruby-lang.org; h=from:references:subject:mime-version:content-type: content-transfer-encoding:list-id:to:cc:content-type:from:subject:to; s=s1; bh=IndJ8/CUZzkPw30jcvkoBsrygwzBHGmsv4fH2MgBw+8=; b=TV14QRuZ0AWKuJkeIepmqYPBAKJezvtCSjB6KylBoOU2LrLEYJiLpU7AK3e0DetIh+u2 OeNFz1FHP2ttY4CSPBu1ObmbWjbu8sFWXYeHxkNfB45naLNgyC8IMR/VNiuTFdkphpGAy7 6grfhg7qCtLkTfLjJrHDfMhKp9NXny5Xo9krob3hK1CJ5gdlUsMX8d6ZUaEXJDrZH8WcTy EXXKHh5NtDUBT1jl3Lqvci3r39sk4bpG5URMq7bp8lAbiJHw0R10v/FWYVf8dAFrgWTuNv xxdolTG8Ic6+EEKHdY/pAMBU2Gejdv15vVAElGg9t7kNf1C70lHQEaYosuzhCnIg== Received: by recvd-8c7b9fb4f-c4fbj with SMTP id recvd-8c7b9fb4f-c4fbj-1-66201C2E-1D 2024-04-17 18:59:58.480019017 +0000 UTC m=+421105.568397232 Received: from herokuapp.com (unknown) by geopod-ismtpd-6 (SG) with ESMTP id q-nFHot1STaBVYdHEKAbdQ for ; Wed, 17 Apr 2024 18:59:58.444 +0000 (UTC) Date: Wed, 17 Apr 2024 18:59:58 +0000 (UTC) Message-ID: References: Mime-Version: 1.0 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Feature X-Redmine-Issue-Id: 20335 X-Redmine-Issue-Author: byroot X-Redmine-Issue-Priority: Normal X-Redmine-Sender: byroot X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-Redmine-MailingListIntegration-Message-Ids: 94171 X-SG-EID: =?us-ascii?Q?u001=2EKmNZ1u3n1vIpO8NNTdp+Q9c0ai7potxbEDLMO7SOJO=2F4KkRUz0d23466m?= =?us-ascii?Q?naiq=2F5fmA4hb60MdRMUAwHZnjIWVFu=2FrqiBOz5c?= =?us-ascii?Q?nOvkBudsSTgVo7cDj4KXfcptC7r5AWylLmAMORN?= =?us-ascii?Q?qiOtWa4a8MPxnzr=2FyHi4=2FcYQFhYfm52ujPvDxkX?= =?us-ascii?Q?iKWokmDL40NM+vI9V+fQH0gky3ZLCGGTQ9dIGns?= =?us-ascii?Q?CjNtkxC0AAhFF52eI959JaTAJYx=2FD+pu1m6p7hL?= =?us-ascii?Q?8=2FVb72OYTokUA2Vx9aIzAldNDg=3D=3D?= To: ruby-core@ml.ruby-lang.org X-Entity-ID: u001.I8uzylDtAfgbeCOeLBYDww== Message-ID-Hash: L5CY52XRYDWVM4BZ4OATHG7KM3C2JZPO X-Message-ID-Hash: L5CY52XRYDWVM4BZ4OATHG7KM3C2JZPO X-MailFrom: bounces+313651-b711-ruby-core=ml.ruby-lang.org@em5188.ruby-lang.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list Reply-To: Ruby developers Subject: [ruby-core:117575] [Ruby master Feature#20335] `Thread.each_caller_location` should accept the same arguments as `caller` and `caller_locations` List-Id: Ruby developers Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: "byroot (Jean Boussier) via ruby-core" Cc: "byroot (Jean Boussier)" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Issue #20335 has been updated by byroot (Jean Boussier). > I also don't see any valid use case for Thread.each_caller_location with a Range with negative begin or end It's still a slightly cheaper version of `caller_locations(range).each`. I agree that it's not super useful, but I don't think it hurts being there either, and I prefer consistency. ---------------------------------------- Feature #20335: `Thread.each_caller_location` should accept the same arguments as `caller` and `caller_locations` https://bugs.ruby-lang.org/issues/20335#change-107975 * Author: byroot (Jean Boussier) * Status: Closed ---------------------------------------- `Thread.each_caller_location` was added to Ruby 3.2 as part of [Feature #16663] and is a very useful API for emitting warnings with a proper source location and similar use cases. However in many of the cases where I used it, or seen it used, it was needed to skip the first, or a couple frames: Examples: Sorbet: https://github.com/Shopify/sorbet/blob/b27a14c247ace7cabdf0f348bfb11fdf0b7e9ab4/gems/sorbet-runtime/lib/types/private/caller_utils.rb#L6-L18 ```ruby def self.find_caller skiped_first = false Thread.each_caller_location do |loc| unless skiped_first skiped_first = true next end next if loc.path&.start_with?("= 1 frames_to_skip -= 1 next end # snipp... ``` ### Proposal I think it would be very useful if `Thread.each_caller_location` accepted the same arguments as `caller` and `caller_locations`: ```ruby #each_caller_location(start = 1, length = nil) #each_caller_location(range) ``` @jeremyevans0 what do you think? -- https://bugs.ruby-lang.org/ ______________________________________________ ruby-core mailing list -- ruby-core@ml.ruby-lang.org To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/