From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from nue.mailmanlists.eu (nue.mailmanlists.eu [IPv6:2a01:4f8:1c0c:6b10::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id F31631F44D for ; Wed, 17 Apr 2024 10:03:25 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; secure) header.d=ml.ruby-lang.org header.i=@ml.ruby-lang.org header.a=rsa-sha256 header.s=mail header.b=y8K656jo; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=XnQ/IYro; dkim-atps=neutral Received: from nue.mailmanlists.eu (localhost [127.0.0.1]) by nue.mailmanlists.eu (Postfix) with ESMTP id D48348430C; Wed, 17 Apr 2024 10:03:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ml.ruby-lang.org; s=mail; t=1713348196; bh=SwScjME1kbH7Jyd85iq3gfFeanDFXgadsGe4p7YRq7M=; h=Date:References:To:Reply-To:Subject:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Cc:From; b=y8K656jo/Lcwa82xQFVulLD9R8lhF1Vh5s2bemjMLEyiBpqlsY06x9XCz0Gzavi56 b38g27GAr5kyVEaRNbB/EJTks+DcFIWXXpCM3bSonHFwpTRdzH04S02gnVsJMp+Lf3 4Cg0jlekLGOn5EIfJs6UqA8DeZE2NOz/WJ+eHs8k= Received: from s.wfbtzhsv.outbound-mail.sendgrid.net (s.wfbtzhsv.outbound-mail.sendgrid.net [159.183.224.104]) by nue.mailmanlists.eu (Postfix) with ESMTPS id 8CDA284306 for ; Wed, 17 Apr 2024 10:03:13 +0000 (UTC) Authentication-Results: nue.mailmanlists.eu; dkim=pass (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=XnQ/IYro; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ruby-lang.org; h=from:references:subject:mime-version:content-type: content-transfer-encoding:list-id:to:cc:content-type:from:subject:to; s=s1; bh=23dsVYU2zhkxjcq2vn18VANM7IO5IYsbbbXjFSOhqWw=; b=XnQ/IYro8zkEkrOznoMgbLQrtIvNmExWYoKQNf2tqOu8PUkiPTs2dabdw6xoQ8fOoXMl VnZ9UMCroaymLiw+0RP09C8Al4AhV4omZJB5gsCt95lR8OxgvILXkFcuniS0TUESIAhYut kmJ+uncd2/PJgzej3VGF3KQ670NwInWDr11N+lYeCw8tn2EMnn1GwrmeWMd9IlTWmULff7 fOmQyy8ObRL/sr5DNGHZC6ox+zVVdmHIWu+pOP2DxH2oh+1Zuj0z73BaMAlG1KJ3ALI79P AZX/Xtvr+VdWiMhCRGDVPFdYSO0ye7WzNARwuk/6UC1S6YFZRZFj1Sl4ECzL/3/A== Received: by recvd-bb7996b79-fbhg6 with SMTP id recvd-bb7996b79-fbhg6-1-661F9E60-2F 2024-04-17 10:03:12.573685583 +0000 UTC m=+388992.467379025 Received: from herokuapp.com (unknown) by geopod-ismtpd-10 (SG) with ESMTP id yjdRLuMsQFGhhZs2INEILg for ; Wed, 17 Apr 2024 10:03:12.505 +0000 (UTC) Date: Wed, 17 Apr 2024 10:03:12 +0000 (UTC) Message-ID: References: Mime-Version: 1.0 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 20414 X-Redmine-Issue-Author: ioquatix X-Redmine-Issue-Assignee: ioquatix X-Redmine-Issue-Priority: Normal X-Redmine-Sender: ioquatix X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-Redmine-MailingListIntegration-Message-Ids: 94151 X-SG-EID: =?us-ascii?Q?u001=2E3QFJPY5gaRwyNXkncYONHM3OeFnb=2FgeOrLDgg3PYIKrq5rvk81iAipQ1q?= =?us-ascii?Q?cdmuT9o5PIWGjXtTDstodNmslT=2F6xfCuIofWR2K?= =?us-ascii?Q?w8msDgVaVLwyso6gf5wPMukr7o4mUqzPo=2FNekDa?= =?us-ascii?Q?12v2GHnn4V4Lky8OhjUWThDXycotu9SsimxURAh?= =?us-ascii?Q?JfafA88NwS8BQdlqutMdi3ODdEAoWRYB6E+KXPR?= =?us-ascii?Q?40l+FP0nUD4bKZO3n6x2yaEB8uJ4UzYjy6rv3BH?= =?us-ascii?Q?m+qzrTPpRKI=2FNHcz5JTjXuirBw=3D=3D?= To: ruby-core@ml.ruby-lang.org X-Entity-ID: u001.I8uzylDtAfgbeCOeLBYDww== Message-ID-Hash: 3MVZGTAJOYPKGHSJJEX63ZLZKGGAVWDO X-Message-ID-Hash: 3MVZGTAJOYPKGHSJJEX63ZLZKGGAVWDO X-MailFrom: bounces+313651-b711-ruby-core=ml.ruby-lang.org@em5188.ruby-lang.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list Reply-To: Ruby developers Subject: [ruby-core:117555] [Ruby master Bug#20414] `Fiber#raise` should recurse to `resumed_fiber` rather than failing. List-Id: Ruby developers Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: "ioquatix (Samuel Williams) via ruby-core" Cc: "ioquatix (Samuel Williams)" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Issue #20414 has been updated by ioquatix (Samuel Williams). Thanks @matz. To clarify, there are two issues are we addressing. (1) Improve consistency of `Thread.current.raise` and `Fiber.current.raise`. (2) Follow `resuming_fiber` when raising exceptions. They overlap, so are addressed by the same PR. ---------------------------------------- Bug #20414: `Fiber#raise` should recurse to `resumed_fiber` rather than failing. https://bugs.ruby-lang.org/issues/20414#change-107951 * Author: ioquatix (Samuel Williams) * Status: Open * Assignee: ioquatix (Samuel Williams) * Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN ---------------------------------------- The following program will fail with `FiberError`, and is difficult to properly clean up: ```ruby root_fiber = Fiber.current f1 = Fiber.new do root_fiber.transfer end f2 = Fiber.new do f1.resume end f2.transfer f2.raise("error") # => `raise': attempt to transfer to a resuming fiber (FiberError) ``` This program deliberately set's up a scenario where `f2` is resuming `f1`. Trying to raise an exception on `f2` is impossible, because the only way control flow can return to it, is when `f1` yields or exits. We can avoid this problem, by raising the exception on f1, and we can do this automatically using the following logic: ```c static VALUE fiber_raise(rb_fiber_t *fiber, VALUE exception) { // Add this recursive step: if (fiber->resuming_fiber) { return fiber_raise(fiber->resuming_fiber, exception); } // Existing code ... else if (FIBER_SUSPENDED_P(fiber) && !fiber->yielding) { return fiber_transfer_kw(fiber, -1, &exception, RB_NO_KEYWORDS); } else { return fiber_resume_kw(fiber, -1, &exception, RB_NO_KEYWORDS); } } ``` This makes `Fiber#raise` much more robust and useful for the purpose of stopping fibers, without knowing exactly what they are doing. -- https://bugs.ruby-lang.org/ ______________________________________________ ruby-core mailing list -- ruby-core@ml.ruby-lang.org To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/