From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=0.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 Received: from nue.mailmanlists.eu (unknown [IPv6:2a01:4f8:1c0c:6b10::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 8A0E11F44D for ; Wed, 17 Apr 2024 08:38:27 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; secure) header.d=ml.ruby-lang.org header.i=@ml.ruby-lang.org header.a=rsa-sha256 header.s=mail header.b=c4H41u+X; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=sbh5UKep; dkim-atps=neutral Received: from nue.mailmanlists.eu (localhost [127.0.0.1]) by nue.mailmanlists.eu (Postfix) with ESMTP id 48B958437E; Wed, 17 Apr 2024 08:38:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ml.ruby-lang.org; s=mail; t=1713343099; bh=ByZp7qjU+sl+LmPIbhmlytZKXpuSfxzXRvtFE/TzVc0=; h=Date:References:To:Reply-To:Subject:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Cc:From; b=c4H41u+X/VHTOVGTybyrw5QaYZxcW5Bziu9GwqTKfng3quDSq5NPyLcc9nT1cd+dl LKggoP6Naw0uvLdNHiCwj9i7Jv5n2WkWD1FHvDrRXeEjiCBUm0j0kGOB1QNq/phXyg vzjRTfPbx/9F3iqxEJ7+p8i+5msrKWxXiMQCIGL8= Received: from s.wfbtzhsv.outbound-mail.sendgrid.net (s.wfbtzhsv.outbound-mail.sendgrid.net [159.183.224.104]) by nue.mailmanlists.eu (Postfix) with ESMTPS id 584778436C for ; Wed, 17 Apr 2024 08:38:15 +0000 (UTC) Authentication-Results: nue.mailmanlists.eu; dkim=pass (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=sbh5UKep; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ruby-lang.org; h=from:references:subject:mime-version:content-type: content-transfer-encoding:list-id:to:cc:content-type:from:subject:to; s=s1; bh=Gv+QRBCPz250b4EH2KMMMzjxPoxWqX7IHGTCBygGACE=; b=sbh5UKepcx7uAYvwRvpKVS7wcVF+q8OsAH7bLKehYutv9KZSzAyZEGHRG+b1a7Nexxdl KD7NvRE3NWB6ihVfpIPBYXTSQdBDqsBd9YtlWgErLWujOPkp3aPa4Cmue69BXGeiVqXNmB 5qHG/6H0lpMZPTXtaolSMzUzj2sgY5sKzofKeotmqV/NH7+gEni8AdjNY5bHLHQbs/YmZV 8JFBhke1u8kDwQYulqKr5fg0GF1sPu+BNMJ4t+/QknUTL03OfTO1R5eQm8H8gfQh8HlyZ4 uFOKRN+h0Gmi5gJYDyxwcwh36+M9v1W/mpzOlR77DnsX5x973ARJni4ib8mA5VDg== Received: by recvd-8c7b9fb4f-p9bwd with SMTP id recvd-8c7b9fb4f-p9bwd-1-661F8A76-6 2024-04-17 08:38:14.31028691 +0000 UTC m=+383904.123875136 Received: from herokuapp.com (unknown) by geopod-ismtpd-7 (SG) with ESMTP id Z3IK9ntXRa62amou9xf6Dg for ; Wed, 17 Apr 2024 08:38:14.281 +0000 (UTC) Date: Wed, 17 Apr 2024 08:38:14 +0000 (UTC) Message-ID: References: Mime-Version: 1.0 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Feature X-Redmine-Issue-Id: 20396 X-Redmine-Issue-Author: byroot X-Redmine-Issue-Priority: Normal X-Redmine-Sender: shyouhei X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-Redmine-MailingListIntegration-Message-Ids: 94147 X-SG-EID: =?us-ascii?Q?u001=2EYb+gxajettXtIRRbovldwe1q9pj4BbUVLgkglfGACSriEdKOm=2FiYoqOLj?= =?us-ascii?Q?03lPXujlro4oiTXwkRMLtmbf5mY+2Uv33JJiwU+?= =?us-ascii?Q?ZJeKxsg2=2FpYY9WCbuiv0LQ=2FJ8rcpUNSxgE6KQ5v?= =?us-ascii?Q?FU1jpFRHkF1ybMe1sKeSPzHGcVkjlZVW2mywHLR?= =?us-ascii?Q?lNlqQDXCCJrmJARtpxLSUtbOWSbcYLNSD=2FzPjvQ?= =?us-ascii?Q?Z4N0=2FaVRifo+zorA3rYSJ7mzqxHD7zW1aNz024b?= =?us-ascii?Q?awaWyY14mIG6zO2ECJfE37H8Eg=3D=3D?= To: ruby-core@ml.ruby-lang.org X-Entity-ID: u001.I8uzylDtAfgbeCOeLBYDww== Message-ID-Hash: 7TXIC57YNIWMVFGVD5ULMAGCHSI4GJWK X-Message-ID-Hash: 7TXIC57YNIWMVFGVD5ULMAGCHSI4GJWK X-MailFrom: bounces+313651-b711-ruby-core=ml.ruby-lang.org@em5188.ruby-lang.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list Reply-To: Ruby developers Subject: [ruby-core:117551] [Ruby master Feature#20396] ObjectSpace.dump_all(string_value: false): skip dumping the String contents List-Id: Ruby developers Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: "shyouhei (Shyouhei Urabe) via ruby-core" Cc: "shyouhei (Shyouhei Urabe)" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Issue #20396 has been updated by shyouhei (Shyouhei Urabe). Why not just stop dumping string values? I'm proposing this because I see no reason to keep them. It is practically proven unnecessary; all non-ASCII bits are already silently dropped and no one complains. I prefer simple API for ObjectSpace.dump_all. We could add options later, if we find any use cases. ---------------------------------------- Feature #20396: ObjectSpace.dump_all(string_value: false): skip dumping the String contents https://bugs.ruby-lang.org/issues/20396#change-107946 * Author: byroot (Jean Boussier) * Status: Open ---------------------------------------- `ObjectSpace.dump_all` is a very useful method to debug memory leaks and such, hence is frequently needed in production. But since all the 7bit strings content is included in the dump, it incur the risk of leaking personal data, or secrets. Also, in many case the strings content isn't that helpful and is just making the dump much bigger for no good reason. And only pure-ASCII strings are dumped this way, which means all the tools that process these dumps should already be compatible with a dump without any string content. ### Feature I propose to add another optional parameter to `dump_all`: `string_value: false`. When passed, no String content is ever dumped regardless of its coderange. Implementation: https://github.com/ruby/ruby/pull/10382 cc @zzak -- https://bugs.ruby-lang.org/ ______________________________________________ ruby-core mailing list -- ruby-core@ml.ruby-lang.org To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/