From: "matz (Yukihiro Matsumoto) via ruby-core" <ruby-core@ml.ruby-lang.org>
To: ruby-core@ml.ruby-lang.org
Cc: "matz (Yukihiro Matsumoto)" <noreply@ruby-lang.org>
Subject: [ruby-core:117550] [Ruby master Feature#20429] Emit a performance warning when specially optimized core methods are redefined
Date: Wed, 17 Apr 2024 07:57:14 +0000 (UTC) [thread overview]
Message-ID: <redmine.journal-107944.20240417075714.7941@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-20429.20240416062503.7941@ruby-lang.org
Issue #20429 has been updated by matz (Yukihiro Matsumoto).
Sounds reasonable. Accepted.
Matz.
----------------------------------------
Feature #20429: Emit a performance warning when specially optimized core methods are redefined
https://bugs.ruby-lang.org/issues/20429#change-107944
* Author: byroot (Jean Boussier)
* Status: Open
----------------------------------------
MRI has a number of core methods with special handling in the interpreter and both JITs that if they are redefined negatively impact Ruby performance.
The methods currently are (I may be missing a few):
- `Integer`: `#+`, `#-`, `#*`, `#/`, `#%`, `#<`, `#>`, `#<=`, `#>=`
- `Float`: `#+`, `#-`, `#*`, `#/`, `#<`, `#>`, `#<=`, `#>=`
- `String`: `#freeze`, `#size`, `#length`, `#empty?`, `#+`, `#succ`, `#%`, `#-@`
- `Array`: `#size`, `#length`, `#empty?`, `#hash`
- `Hash`: `#size`, `#length`, `#empty?`, `#[]`, `#[]=`
Noticing that a dependency do redefine one of these methods can be non-trivial, so I'd like to emit a `:performance` warning when it happens.
I can't really think of much reasons to redefine these aside from fun hacks, so I believe discouraging it would be valuable.
Patch: https://github.com/ruby/ruby/pull/10532
--
https://bugs.ruby-lang.org/
______________________________________________
ruby-core mailing list -- ruby-core@ml.ruby-lang.org
To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/
prev parent reply other threads:[~2024-04-17 7:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 6:25 [ruby-core:117523] [Ruby master Feature#20429] Emit a performance warning when specially optimized core methods are redefined byroot (Jean Boussier) via ruby-core
2024-04-16 10:11 ` [ruby-core:117529] " Eregon (Benoit Daloze) via ruby-core
2024-04-17 7:57 ` matz (Yukihiro Matsumoto) via ruby-core [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-107944.20240417075714.7941@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
--cc=noreply@ruby-lang.org \
--cc=ruby-core@ml.ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).