From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from nue.mailmanlists.eu (nue.mailmanlists.eu [94.130.110.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id E6BFD1F44D for ; Sun, 31 Mar 2024 23:57:47 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; secure) header.d=ml.ruby-lang.org header.i=@ml.ruby-lang.org header.a=rsa-sha256 header.s=mail header.b=b0nch4Xu; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=UBUpEUB2; dkim-atps=neutral Received: from nue.mailmanlists.eu (localhost [127.0.0.1]) by nue.mailmanlists.eu (Postfix) with ESMTP id 9AA1783AD7; Sun, 31 Mar 2024 23:57:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ml.ruby-lang.org; s=mail; t=1711929458; bh=3rmw0ubYOy17HcCwENFay62vTmliB3ZC5dkJCu2r/d8=; h=Date:References:To:Reply-To:Subject:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Cc:From; b=b0nch4XuWU3oHNGmYSuKajdoupVwDTuALOmGEPh+ReF1FWRjawZq8cgWSP+6nQ187 8zzx587PZM3njLjJeC1aPR1sRIA88X5m7Mvd13CTWG3o2VvhfRGOPwIRiHLwM5WerA 72U19p0hzs8mIOJSQuD6hUGAB5NYkl5uKPe1sncI= Received: from s.wrqvtvvn.outbound-mail.sendgrid.net (s.wrqvtvvn.outbound-mail.sendgrid.net [149.72.120.130]) by nue.mailmanlists.eu (Postfix) with ESMTPS id D9C9B83AC7 for ; Sun, 31 Mar 2024 23:57:35 +0000 (UTC) Authentication-Results: nue.mailmanlists.eu; dkim=pass (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=UBUpEUB2; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ruby-lang.org; h=from:references:subject:mime-version:content-type: content-transfer-encoding:list-id:to:cc:content-type:from:subject:to; s=s1; bh=EdAqVIyza1+hH/3PdeDLDbuHF7NhhSRXO0iD6hriqq8=; b=UBUpEUB23eoR7UxZpp/w13IdPTBQkI/3EwFSU5dmuPy2DJwUFbv9vP2MyIi0gjMuy3hb JY4KJauTovWzCYa8mEuE/F3Yr/k6aHDJi3XKOeqG/mvFD/hNdGRTLx4mTTcxhZcA4iWGt0 9AuIWg5zpZ8Ycmcj7YfzPBTRIEA6qa5d/VxU3mQSWK5wUWFAfmqsGMj6jOsWBzLSOKkHCB wtLrcnoin0614JTHFpq7xEJarrHC/jMgnTBnUccXzeE0ti+CTDhExgXTF9/q8K8qV2nY0J 1dgD9+OaCHWS+w7+zLGId7RYDHH0nL9U3uKS4wzgOj/Hp0K9umu7RGiguoX/hSRQ== Received: by filterdrecv-86675bc4b9-q99c8 with SMTP id filterdrecv-86675bc4b9-q99c8-1-6609F86E-6 2024-03-31 23:57:34.741060451 +0000 UTC m=+1135913.076632176 Received: from herokuapp.com (unknown) by geopod-ismtpd-22 (SG) with ESMTP id lRsurxGETCGBICe6G8_tcw for ; Sun, 31 Mar 2024 23:57:34.707 +0000 (UTC) Date: Sun, 31 Mar 2024 23:57:34 +0000 (UTC) Message-ID: References: Mime-Version: 1.0 X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 20403 X-Redmine-Issue-Author: kjtsanaktsidis X-Redmine-Issue-Assignee: kjtsanaktsidis X-Redmine-Issue-Priority: Normal X-Redmine-Sender: kjtsanaktsidis X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-Redmine-MailingListIntegration-Message-Ids: 93986 X-SG-EID: =?us-ascii?Q?u001=2Ehtvb0C=2FfA7uJxza5ajJoGjWf7D35DJhKe7Y94xYuv7SZnqx0qbu=2F70+zV?= =?us-ascii?Q?XRgEUZlB2KACYgzrNXwJOFqD+GI4v+xLlProPhe?= =?us-ascii?Q?RqFaaJyjkou0xLvKvuiELRONKlj3l3a83+EUfrb?= =?us-ascii?Q?TvydNI3HjtIDIt7cxY0PNiTQJ4T+5wEApdvFd7e?= =?us-ascii?Q?sc3N02dmUSJ9SJY7uzpn7r6+ExBNiZIsvDKVsNy?= =?us-ascii?Q?up11fF52A=2FX5Tnqf=2FBPQdPpMg=2FFnC4cITChfw3X?= =?us-ascii?Q?w9kgG9ILFY+YOOXt5eO0dfxm3IgGDTkjiF3hE7e?= =?us-ascii?Q?H9YzANeo=3D?= To: ruby-core@ml.ruby-lang.org X-Entity-ID: u001.I8uzylDtAfgbeCOeLBYDww== Message-ID-Hash: JKLYYK6RCDJPOGWXIZPK6TRJVNE27CE6 X-Message-ID-Hash: JKLYYK6RCDJPOGWXIZPK6TRJVNE27CE6 X-MailFrom: bounces+313651-b711-ruby-core=ml.ruby-lang.org@em5188.ruby-lang.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list Reply-To: Ruby developers Subject: [ruby-core:117391] [Ruby master Bug#20403] TestResolvDNS#test_query_ipv4_address_truncated_tcp_fallback can flake if TCP port is in use List-Id: Ruby developers Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: "kjtsanaktsidis (KJ Tsanaktsidis) via ruby-core" Cc: "kjtsanaktsidis (KJ Tsanaktsidis)" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Issue #20403 has been updated by kjtsanaktsidis (KJ Tsanaktsidis). Fixed in https://github.com/ruby/resolv/pull/49 ---------------------------------------- Bug #20403: TestResolvDNS#test_query_ipv4_address_truncated_tcp_fallback can flake if TCP port is in use https://bugs.ruby-lang.org/issues/20403#change-107552 * Author: kjtsanaktsidis (KJ Tsanaktsidis) * Status: Closed * Assignee: kjtsanaktsidis (KJ Tsanaktsidis) * Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN ---------------------------------------- The test TestResolvDNS#test_query_ipv4_address_truncated_tcp_fallback wants to make a TCP and UDP DNS server on the same port. It achieves this by binding to a random UDP port (with `:0`), and then trying to bind to that TCP port. However, just because the UDP port was free, does not mean the TCP port was, so this can fail. This leads to test failures like this one: https://github.com/ruby/ruby/actions/runs/8497267556/job/23275642160 ``` 1) Error: TestResolvDNS#test_query_ipv4_address_truncated_tcp_fallback: Errno::EACCES: Permission denied - bind(2) for "127.0.0.1" port 49701 D:/a/ruby/ruby/src/test/resolv/test_dns.rb:48:in 'TCPServer#initialize' D:/a/ruby/ruby/src/test/resolv/test_dns.rb:48:in 'IO.new' D:/a/ruby/ruby/src/test/resolv/test_dns.rb:48:in 'TestResolvDNS#with_tcp' D:/a/ruby/ruby/src/test/resolv/test_dns.rb:181:in 'block in TestResolvDNS#test_query_ipv4_address_truncated_tcp_fallback' D:/a/ruby/ruby/src/test/resolv/test_dns.rb:61:in 'TestResolvDNS#with_udp' D:/a/ruby/ruby/src/test/resolv/test_dns.rb:179:in 'TestResolvDNS#test_query_ipv4_address_truncated_tcp_fallback' Finished tests in 401.425882s, 64.4851 tests/s, 15534.2649 assertions/s. 25886 tests, 6235856 assertions, 0 failures, 1 errors, 502 skips ``` (note - it's EACCESS, not EADDRINUSE, because of this issue on Windows, I think: https://stackoverflow.com/questions/48478869/cannot-bind-to-some-ports-due-to-permission-denied) -- https://bugs.ruby-lang.org/ ______________________________________________ ruby-core mailing list -- ruby-core@ml.ruby-lang.org To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/